)]}'
{"openstackclient/identity/v3/service_provider.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   under the License."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\"\"\"service v3 ServiceProvider action implementations\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d97dcd6e","line":14,"updated":"2015-03-19 18:59:44.000000000","message":"i\u0027d go with 2 words\n\nService v3 Service Provider action blah","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   under the License."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\"\"\"service v3 ServiceProvider action implementations\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_72a6a110","line":14,"in_reply_to":"9a80dd14_d97dcd6e","updated":"2015-03-20 09:57:03.000000000","message":"Done","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--auth_url\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cauth-url\u003e\u0027,"},{"line_number":63,"context_line":"            help\u003d\u0027Authentication URL of remote federated Service Provider\u0027,"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_392b4996","line":62,"updated":"2015-03-19 18:59:44.000000000","message":"we could make these required by setting required\u003dTrue, better to force the user here rather than wait for the database to come back with a notnullable message or schema failed message","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--auth_url\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cauth-url\u003e\u0027,"},{"line_number":63,"context_line":"            help\u003d\u0027Authentication URL of remote federated Service Provider\u0027,"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d2b66d3d","line":62,"in_reply_to":"9a80dd14_392b4996","updated":"2015-03-20 09:57:03.000000000","message":"true.\nIdeally ksc should also has some validation available.","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class DeleteServiceProvider(command.Command):"},{"line_number":89,"context_line":"    \"\"\"Delete an service provider\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteServiceProvider\u0027)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_942b1c81","line":89,"updated":"2015-03-19 18:59:44.000000000","message":"s/an/a*","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class DeleteServiceProvider(command.Command):"},{"line_number":89,"context_line":"    \"\"\"Delete an service provider\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteServiceProvider\u0027)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3287c962","line":89,"in_reply_to":"9a80dd14_942b1c81","updated":"2015-03-20 09:57:03.000000000","message":"Done","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def take_action(self, parsed_args):"},{"line_number":116,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027, parsed_args)"},{"line_number":117,"context_line":"        columns \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Auth URL\u0027, \u0027Sp URL\u0027)"},{"line_number":118,"context_line":"        service_client \u003d self.app.client_manager.service"},{"line_number":119,"context_line":"        data \u003d service_client.federation.service_providers.list()"},{"line_number":120,"context_line":"        return (columns,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_749b08c9","line":117,"updated":"2015-03-19 18:59:44.000000000","message":"ugh Sp looks ugly, create a separate variable for the headers called\n\n  column_headers\n\nthat has different values than `columns`, and write out \u0027Service Provider URL\u0027","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def take_action(self, parsed_args):"},{"line_number":116,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027, parsed_args)"},{"line_number":117,"context_line":"        columns \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Auth URL\u0027, \u0027Sp URL\u0027)"},{"line_number":118,"context_line":"        service_client \u003d self.app.client_manager.service"},{"line_number":119,"context_line":"        data \u003d service_client.federation.service_providers.list()"},{"line_number":120,"context_line":"        return (columns,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_92c5d58f","line":117,"in_reply_to":"9a80dd14_749b08c9","updated":"2015-03-20 09:57:03.000000000","message":"I am wondering whether SP URL is in fact necessary here. While I can agree Auth URL may be used for distinguishing between SPs (ids not always need to be very informative), SP URL is a protocol internal thing. And for listing we might want to fit the standard screen width. (and both AUTH URL and SP URL can make the line very very long)\nIf somebody needs more info about configured SP he is advised to  use \u0027show\u0027 command. \nI will remove SP URL for now and wait for your comment.","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            enabled \u003d True"},{"line_number":169,"context_line":"        elif parsed_args.disable is True:"},{"line_number":170,"context_line":"            enabled \u003d False"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            sys.stdout.write(\"Service Provider not updated, \""},{"line_number":173,"context_line":"                             \"no arguments present\")"},{"line_number":174,"context_line":"            return (None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d46f54c2","line":171,"updated":"2015-03-19 18:59:44.000000000","message":"what about checking the URLs?","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            enabled \u003d True"},{"line_number":169,"context_line":"        elif parsed_args.disable is True:"},{"line_number":170,"context_line":"            enabled \u003d False"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            sys.stdout.write(\"Service Provider not updated, \""},{"line_number":173,"context_line":"                             \"no arguments present\")"},{"line_number":174,"context_line":"            return (None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_32e269d5","line":171,"in_reply_to":"9a80dd14_d46f54c2","updated":"2015-03-20 09:57:03.000000000","message":"i don\u0027t need to provide URL when I want to disable or change SP\u0027s description, do I?","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            sys.stdout.write(\"Service Provider not updated, \""},{"line_number":173,"context_line":"                             \"no arguments present\")"},{"line_number":174,"context_line":"            return (None, None)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        service_provider \u003d federation_client.service_providers.update("},{"line_number":177,"context_line":"            parsed_args.service_provider, enabled\u003denabled)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_327ee9e4","line":174,"updated":"2015-03-20 09:57:03.000000000","message":"In fact I think we don\u0027t need to require user always specify whether SP is enabled or not.","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2c0f9c544757706fc0796c77a4032606616ce8a3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            parsed_args.service_provider, enabled\u003denabled)"},{"line_number":178,"context_line":"        info \u003d {}"},{"line_number":179,"context_line":"        info.update(service_provider._info)"},{"line_number":180,"context_line":"        return zip(*sorted(six.iteritems(info)))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ShowServiceProvider(show.ShowOne):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d4583433","line":180,"updated":"2015-03-19 18:59:44.000000000","message":"condense three lines to one...\n\nreturn zip(*sorted(six.iteritems(service_provider._info)))","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c68324e4cfdab746fcd9ac632f080575400014f7","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            parsed_args.service_provider, enabled\u003denabled)"},{"line_number":178,"context_line":"        info \u003d {}"},{"line_number":179,"context_line":"        info.update(service_provider._info)"},{"line_number":180,"context_line":"        return zip(*sorted(six.iteritems(info)))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ShowServiceProvider(show.ShowOne):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_52e51dda","line":180,"in_reply_to":"9a80dd14_d4583433","updated":"2015-03-20 09:57:03.000000000","message":"Done","commit_id":"a2c642dabf49ebbc8dd413d9bfd50f7203158ba3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateServiceProvider, self).get_parser(prog_name)"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \u0027service_provider_id\u0027,"},{"line_number":36,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":37,"context_line":"            help\u003d\u0027New service provider ID (must be unique)\u0027"},{"line_number":38,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_f5469722","line":35,"updated":"2015-03-23 18:18:48.000000000","message":"Another user-supplied id?  If the APIs are going to keep insisting on these, maybe we should have OSC generate a UUID so user\u0027s don\u0027t need to keep track and ensure uniqueness.","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateServiceProvider, self).get_parser(prog_name)"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \u0027service_provider_id\u0027,"},{"line_number":36,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":37,"context_line":"            help\u003d\u0027New service provider ID (must be unique)\u0027"},{"line_number":38,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_34bad923","line":35,"in_reply_to":"1a6ced46_82db66ec","updated":"2015-03-24 09:50:10.000000000","message":"++","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a960a376dcc53123e5902c81563863365d3f9e83","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateServiceProvider, self).get_parser(prog_name)"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \u0027service_provider_id\u0027,"},{"line_number":36,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":37,"context_line":"            help\u003d\u0027New service provider ID (must be unique)\u0027"},{"line_number":38,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_82db66ec","line":35,"in_reply_to":"1a6ced46_f5469722","updated":"2015-03-23 20:08:59.000000000","message":"this should be the last one for a while... i hope","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            dest\u003d\u0027enabled\u0027,"},{"line_number":49,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":50,"context_line":"            default\u003dTrue,"},{"line_number":51,"context_line":"            help\u003d\u0027Enable service provider\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        enable_service_provider.add_argument("},{"line_number":54,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_65dd8f70","line":51,"updated":"2015-03-23 22:24:46.000000000","message":"Enable service provider (default)","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            dest\u003d\u0027enabled\u0027,"},{"line_number":49,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":50,"context_line":"            default\u003dTrue,"},{"line_number":51,"context_line":"            help\u003d\u0027Enable service provider\u0027,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        enable_service_provider.add_argument("},{"line_number":54,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_f4968193","line":51,"in_reply_to":"1a6ced46_65dd8f70","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027--disable\u0027,"},{"line_number":55,"context_line":"            dest\u003d\u0027enabled\u0027,"},{"line_number":56,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027Disable the service provider\u0027,"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_2542b710","line":57,"updated":"2015-03-23 22:24:46.000000000","message":"For consistency drop \"the\"","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027--disable\u0027,"},{"line_number":55,"context_line":"            dest\u003d\u0027enabled\u0027,"},{"line_number":56,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":57,"context_line":"            help\u003d\u0027Disable the service provider\u0027,"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_3491f999","line":57,"in_reply_to":"1a6ced46_2542b710","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--auth_url\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cauth-url\u003e\u0027,"},{"line_number":63,"context_line":"            required\u003dTrue,"},{"line_number":64,"context_line":"            help\u003d\u0027Authentication URL of remote federated Service Provider\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_95ff2301","line":61,"updated":"2015-03-23 18:18:48.000000000","message":"The underscores here and below need to be changed to dashes \u0027-\u0027.\n\nAlso move these two options above the enable/disable group so they are displayed with description in the help output.","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--sp_url\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027\u003csp-url\u003e\u0027,"},{"line_number":70,"context_line":"            required\u003dTrue,"},{"line_number":71,"context_line":"            help\u003d\u0027A service URL where SAML assertions are being sent\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_35daef78","line":68,"updated":"2015-03-23 18:18:48.000000000","message":"This name isn\u0027t clear and should probably not be so abbreviated.  We use \u0027auth\u0027 in a lot of places so can probably get away with that, but \u0027sp\u0027 implies \u0027service provider\u0027 to me but the help doesn\u0027t say that.\n\n--service-provider-url or --saml-url would be preferable to me, depending on which more accurately describes what the URL is used for.","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--sp_url\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027\u003csp-url\u003e\u0027,"},{"line_number":70,"context_line":"            required\u003dTrue,"},{"line_number":71,"context_line":"            help\u003d\u0027A service URL where SAML assertions are being sent\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_54683587","line":68,"in_reply_to":"1a6ced46_35daef78","updated":"2015-03-24 09:50:10.000000000","message":"i will change to service-provider-url as I don\u0027t want to lock myself to SAML only (we might come up with some crazy idea of having more protocols).","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027--sp_url\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027\u003csp-url\u003e\u0027,"},{"line_number":70,"context_line":"            required\u003dTrue,"},{"line_number":71,"context_line":"            help\u003d\u0027A service URL where SAML assertions are being sent\u0027,"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_4515f3ef","line":71,"updated":"2015-03-23 22:24:46.000000000","message":"Should this be more generic as it can support both SAML and Claim?  Maybe just drop \"SAML\"?","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e987966b3e3694987bd752bc9bf21864eedbe4ca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027--sp_url\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027\u003csp-url\u003e\u0027,"},{"line_number":70,"context_line":"            required\u003dTrue,"},{"line_number":71,"context_line":"            help\u003d\u0027A service URL where SAML assertions are being sent\u0027,"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_b6733b4c","line":71,"in_reply_to":"1a6ced46_4515f3ef","updated":"2015-03-24 00:12:38.000000000","message":"i was thinking this too, but SPs are only used in a K2K scenario, so i\u0027ll let marek make the call","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027--sp_url\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027\u003csp-url\u003e\u0027,"},{"line_number":70,"context_line":"            required\u003dTrue,"},{"line_number":71,"context_line":"            help\u003d\u0027A service URL where SAML assertions are being sent\u0027,"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_20e8d80f","line":71,"in_reply_to":"1a6ced46_b6733b4c","updated":"2015-03-24 09:50:10.000000000","message":"Service Providers are for K2K which supports SAML only at the moment.","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a960a376dcc53123e5902c81563863365d3f9e83","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class DeleteServiceProvider(command.Command):"},{"line_number":91,"context_line":"    \"\"\"Delete a service provider\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteServiceProvider\u0027)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_e2909aee","line":91,"updated":"2015-03-23 20:08:59.000000000","message":"for consistency, drop the \u0027a\u0027...\n\nDelete service provider","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class DeleteServiceProvider(command.Command):"},{"line_number":91,"context_line":"    \"\"\"Delete a service provider\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteServiceProvider\u0027)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_b4108902","line":91,"in_reply_to":"1a6ced46_e2909aee","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027service_provider\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":100,"context_line":"            help\u003d\u0027service provider ID to delete\u0027,"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":"        return parser"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_7500e7aa","line":100,"updated":"2015-03-23 18:18:48.000000000","message":"Capitalize service","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027service_provider\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":100,"context_line":"            help\u003d\u0027service provider ID to delete\u0027,"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":"        return parser"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_d413450b","line":100,"in_reply_to":"1a6ced46_05d69b4f","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027service_provider\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":100,"context_line":"            help\u003d\u0027service provider ID to delete\u0027,"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":"        return parser"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_05d69b4f","line":100,"in_reply_to":"1a6ced46_7500e7aa","updated":"2015-03-23 22:24:46.000000000","message":"Service provider to delete (ID)","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56f2685018b3356e14f3b1e9b68b6a9adc6593af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        service_client \u003d self.app.client_manager.identity"},{"line_number":120,"context_line":"        data \u003d service_client.federation.service_providers.list()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        column_headers \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Auth URL\u0027)"},{"line_number":123,"context_line":"        return (column_headers,"},{"line_number":124,"context_line":"                (utils.get_item_properties("},{"line_number":125,"context_line":"                    s, column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_0dcde731","line":122,"updated":"2015-03-23 20:34:18.000000000","message":"did we decide to chop off SP_URL?","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        service_client \u003d self.app.client_manager.identity"},{"line_number":120,"context_line":"        data \u003d service_client.federation.service_providers.list()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        column_headers \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Description\u0027, \u0027Auth URL\u0027)"},{"line_number":123,"context_line":"        return (column_headers,"},{"line_number":124,"context_line":"                (utils.get_item_properties("},{"line_number":125,"context_line":"                    s, column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_205618d3","line":122,"in_reply_to":"1a6ced46_0dcde731","updated":"2015-03-24 09:50:10.000000000","message":"I proposed this here and on IRC. My rationale is that Auth URL as well as SP URL may be loooong and they may not fit even on a wide screen in one line. I prefer to drop SP URL (which is usually not really required when listing all the SPs) and only provide it on purpose (when showing the exact SP).","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027service_provider\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":140,"context_line":"            help\u003d\u0027service provider ID to change\u0027,"},{"line_number":141,"context_line":"        )"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_45ab33d8","line":140,"updated":"2015-03-23 22:24:46.000000000","message":"Service Provider to modify (ID)","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027service_provider\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":140,"context_line":"            help\u003d\u0027service provider ID to change\u0027,"},{"line_number":141,"context_line":"        )"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_14f5ddca","line":140,"in_reply_to":"1a6ced46_45ab33d8","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        enable_service_provider.add_argument("},{"line_number":145,"context_line":"            \u0027--enable\u0027,"},{"line_number":146,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":147,"context_line":"            help\u003d\u0027Enable the service provider\u0027,"},{"line_number":148,"context_line":"        )"},{"line_number":149,"context_line":"        enable_service_provider.add_argument("},{"line_number":150,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_8548cb2e","line":147,"updated":"2015-03-23 22:24:46.000000000","message":"For consistency drop \"the\"","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        enable_service_provider.add_argument("},{"line_number":145,"context_line":"            \u0027--enable\u0027,"},{"line_number":146,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":147,"context_line":"            help\u003d\u0027Enable the service provider\u0027,"},{"line_number":148,"context_line":"        )"},{"line_number":149,"context_line":"        enable_service_provider.add_argument("},{"line_number":150,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_b4b169e3","line":147,"in_reply_to":"1a6ced46_8548cb2e","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        enable_service_provider.add_argument("},{"line_number":150,"context_line":"            \u0027--disable\u0027,"},{"line_number":151,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":152,"context_line":"            help\u003d\u0027Disable the service provider\u0027,"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":"        parser.add_argument("},{"line_number":155,"context_line":"            \u0027--auth_url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_c552c3dc","line":152,"updated":"2015-03-23 22:24:46.000000000","message":"For consistency drop \"the\"","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        enable_service_provider.add_argument("},{"line_number":150,"context_line":"            \u0027--disable\u0027,"},{"line_number":151,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":152,"context_line":"            help\u003d\u0027Disable the service provider\u0027,"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":"        parser.add_argument("},{"line_number":155,"context_line":"            \u0027--auth_url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_d4b425d3","line":152,"in_reply_to":"1a6ced46_c552c3dc","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":152,"context_line":"            help\u003d\u0027Disable the service provider\u0027,"},{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":"        parser.add_argument("},{"line_number":155,"context_line":"            \u0027--auth_url\u0027,"},{"line_number":156,"context_line":"            metavar\u003d\u0027\u003cauth-url\u003e\u0027,"},{"line_number":157,"context_line":"            help\u003d\u0027Authentication URL of remote federated Service Provider\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_955e43e8","line":154,"updated":"2015-03-23 18:18:48.000000000","message":"Same notes as above for these two options","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56f2685018b3356e14f3b1e9b68b6a9adc6593af","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                             \" present\")"},{"line_number":178,"context_line":"            return (None, None)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        service_provider \u003d federation_client.service_providers.update("},{"line_number":181,"context_line":"            parsed_args.service_provider, enabled\u003denabled)"},{"line_number":182,"context_line":"        return zip(*sorted(six.iteritems(service_provider._info)))"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_ed188b86","line":180,"updated":"2015-03-23 20:34:18.000000000","message":"another weird result:\n\n  steve:python-openstackclient$ openstack service provider set tempo --auth_url http://new.myurl.com\n  ERROR: openstack {} does not have enough properties (HTTP 400) (Request-ID: req-ed23d237-6c28-4173-b646-9d81d80ae706)","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cc6384175537973b569f12e53f2b8036a2228eeb","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                             \" present\")"},{"line_number":178,"context_line":"            return (None, None)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        service_provider \u003d federation_client.service_providers.update("},{"line_number":181,"context_line":"            parsed_args.service_provider, enabled\u003denabled)"},{"line_number":182,"context_line":"        return zip(*sorted(six.iteritems(service_provider._info)))"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_4d72684a","line":180,"in_reply_to":"1a6ced46_ed188b86","updated":"2015-03-24 10:59:29.000000000","message":"Can you try with the newest patch ?","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a960a376dcc53123e5902c81563863365d3f9e83","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class ShowServiceProvider(show.ShowOne):"},{"line_number":186,"context_line":"    \"\"\"Show service provider details\"\"\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowServiceProvider\u0027)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_a2ff8233","line":186,"updated":"2015-03-23 20:08:59.000000000","message":"Use:\n\n\"\"\"Display service provider details\"\"\"","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class ShowServiceProvider(show.ShowOne):"},{"line_number":186,"context_line":"    \"\"\"Show service provider details\"\"\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowServiceProvider\u0027)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_3421f9fb","line":186,"in_reply_to":"1a6ced46_a2ff8233","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"7161c7833df989f4eeeb364562346e22b7bb43da","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        parser.add_argument("},{"line_number":193,"context_line":"            \u0027service_provider\u0027,"},{"line_number":194,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":195,"context_line":"            help\u003d\u0027service provider ID to show\u0027,"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        return parser"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_15f973c8","line":195,"updated":"2015-03-23 18:18:48.000000000","message":"Capitalize service","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a21e6dd7e892667d41f488e86f75ae03f57757e5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        parser.add_argument("},{"line_number":193,"context_line":"            \u0027service_provider\u0027,"},{"line_number":194,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":195,"context_line":"            help\u003d\u0027service provider ID to show\u0027,"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        return parser"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_45741399","line":195,"in_reply_to":"1a6ced46_15f973c8","updated":"2015-03-23 22:24:46.000000000","message":"Service provider to display (ID)","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"72b093b802455cbc8a59ec7b68d48b73ea674e74","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        parser.add_argument("},{"line_number":193,"context_line":"            \u0027service_provider\u0027,"},{"line_number":194,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":195,"context_line":"            help\u003d\u0027service provider ID to show\u0027,"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        return parser"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_5473d514","line":195,"in_reply_to":"1a6ced46_45741399","updated":"2015-03-24 09:50:10.000000000","message":"Done","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56f2685018b3356e14f3b1e9b68b6a9adc6593af","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def take_action(self, parsed_args):"},{"line_number":200,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027, parsed_args)"},{"line_number":201,"context_line":"        service_client \u003d self.app.client_manager.identity"},{"line_number":202,"context_line":"        service_provider \u003d utils.find_resource("},{"line_number":203,"context_line":"            service_client.federation.service_providers,"},{"line_number":204,"context_line":"            parsed_args.service_provider)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_6d02db3f","line":202,"updated":"2015-03-23 20:34:18.000000000","message":"getting something weird here.... always returns back a result\n\n  steve:python-openstackclient$ openstack service provider show adadsadas\n  +-------------+-------------------+\n  | Field       | Value             |\n  +-------------+-------------------+\n  | auth_url    | http://myurl.com  |\n  | description | None              |\n  | enabled     | True              |\n  | id          | tempo             |\n  | sp_url      | http://yoursp.com |\n  +-------------+-------------------+","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cc6384175537973b569f12e53f2b8036a2228eeb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def take_action(self, parsed_args):"},{"line_number":200,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027, parsed_args)"},{"line_number":201,"context_line":"        service_client \u003d self.app.client_manager.identity"},{"line_number":202,"context_line":"        service_provider \u003d utils.find_resource("},{"line_number":203,"context_line":"            service_client.federation.service_providers,"},{"line_number":204,"context_line":"            parsed_args.service_provider)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_ed7cf422","line":202,"in_reply_to":"1a6ced46_6d02db3f","updated":"2015-03-24 10:59:29.000000000","message":"Can you try with the newest patch ?","commit_id":"7427315d250926e8b2b43fbf036daa3e4b3b1715"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5c4984b6ebb2708416802586bb4518bca7151ea3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027service_provider\u0027,"},{"line_number":97,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":98,"context_line":"            help\u003d\u0027Service provider ID to delete (ID)\u0027,"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":"        return parser"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_5284b8d3","line":98,"updated":"2015-03-24 16:40:56.000000000","message":"you mention ID twice here, the first one is unnecessary","commit_id":"e7e2d83a50b2119593a5e68e439103ae8c1d5f98"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5c4984b6ebb2708416802586bb4518bca7151ea3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027service_provider\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":138,"context_line":"            help\u003d\u0027Service provider ID to change (ID)\u0027,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        parser.add_argument("},{"line_number":141,"context_line":"            \u0027--auth-url\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_b0af9fe2","line":138,"updated":"2015-03-24 16:40:56.000000000","message":"same as above","commit_id":"e7e2d83a50b2119593a5e68e439103ae8c1d5f98"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5c4984b6ebb2708416802586bb4518bca7151ea3","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027service_provider\u0027,"},{"line_number":203,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":204,"context_line":"            help\u003d\u0027Service provider ID to display (ID)\u0027,"},{"line_number":205,"context_line":"        )"},{"line_number":206,"context_line":"        return parser"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_f0b9172f","line":204,"updated":"2015-03-24 16:40:56.000000000","message":"same as above","commit_id":"e7e2d83a50b2119593a5e68e439103ae8c1d5f98"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4037bec5ddba98d33098a4e5079c5de3a86e1060","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027service_provider\u0027,"},{"line_number":97,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":98,"context_line":"            help\u003d\u0027Service provider ID to delete (ID)\u0027,"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":"        return parser"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6ced46_ef61353a","line":98,"updated":"2015-03-24 17:37:08.000000000","message":"The standard formatting for help is :  \"Flavor to delete (name or ID)\"\n\nFor this case, I think we can drop the \"ID\" in  \"Service provider ID\". Having mentions of ID twice in the help seems redundant.","commit_id":"a354269c17de0ba46755281c582a61a9be587e0e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4037bec5ddba98d33098a4e5079c5de3a86e1060","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027service_provider\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":138,"context_line":"            help\u003d\u0027Service provider ID to change (ID)\u0027,"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        parser.add_argument("},{"line_number":141,"context_line":"            \u0027--auth-url\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6ced46_8ffe0137","line":138,"updated":"2015-03-24 17:37:08.000000000","message":"\"change\" -\u003e \"modify\" for consistency with other help","commit_id":"a354269c17de0ba46755281c582a61a9be587e0e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4037bec5ddba98d33098a4e5079c5de3a86e1060","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027service_provider\u0027,"},{"line_number":203,"context_line":"            metavar\u003d\u0027\u003cservice-provider-id\u003e\u0027,"},{"line_number":204,"context_line":"            help\u003d\u0027Service provider ID to display (ID)\u0027,"},{"line_number":205,"context_line":"        )"},{"line_number":206,"context_line":"        return parser"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6ced46_0f9a1114","line":204,"updated":"2015-03-24 17:37:08.000000000","message":"same comment about ID","commit_id":"a354269c17de0ba46755281c582a61a9be587e0e"}]}