)]}'
{"openstackclient/compute/v2/security_group.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"ce4cc775e1d87b2d14b3f4baffef62433e4bc55b","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--dst-port\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003cport-range\u003e\","},{"line_number":293,"context_line":"            default\u003d(0, 0),"},{"line_number":294,"context_line":"            action\u003dparseractions.RangeAction,"},{"line_number":295,"context_line":"            help\u003d\"Destination port, may be a range: 137:139 (default: 0; \""},{"line_number":296,"context_line":"                 \"only required for proto tcp and udp)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_7e2c4002","line":293,"updated":"2015-04-21 12:57:54.000000000","message":"What happens on ICMP rules with this?  This doesn\u0027t seem to me like the right approach.  I would think it would make more sense to change the from_port and to_port split down below.  I haven\u0027t tried it though.","commit_id":"9f966785cc620a2b3f97a17c51d9c2f40acaacc3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1221268090987ca30ee7997dcffc9926411210ba","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--dst-port\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003cport-range\u003e\","},{"line_number":293,"context_line":"            default\u003d(0, 0),"},{"line_number":294,"context_line":"            action\u003dparseractions.RangeAction,"},{"line_number":295,"context_line":"            help\u003d\"Destination port, may be a range: 137:139 (default: 0; \""},{"line_number":296,"context_line":"                 \"only required for proto tcp and udp)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_58774b3a","line":293,"updated":"2015-04-21 15:05:41.000000000","message":"why don\u0027t we have:\n\n  type\u003dint\n  default\u003d0","commit_id":"9f966785cc620a2b3f97a17c51d9c2f40acaacc3"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"b4d5c28eaa2374165ab15d16f2920073fa0105cc","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--dst-port\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003cport-range\u003e\","},{"line_number":293,"context_line":"            default\u003d(0, 0),"},{"line_number":294,"context_line":"            action\u003dparseractions.RangeAction,"},{"line_number":295,"context_line":"            help\u003d\"Destination port, may be a range: 137:139 (default: 0; \""},{"line_number":296,"context_line":"                 \"only required for proto tcp and udp)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_c3200c9e","line":293,"in_reply_to":"dac4157f_58774b3a","updated":"2015-04-21 15:12:29.000000000","message":"That RangeAction is supposed to return a tuple","commit_id":"9f966785cc620a2b3f97a17c51d9c2f40acaacc3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2b2e823a039f9a87b4ec748af9d1ab9547e6d0b7","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--dst-port\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003cport-range\u003e\","},{"line_number":293,"context_line":"            default\u003d(0, 0),"},{"line_number":294,"context_line":"            action\u003dparseractions.RangeAction,"},{"line_number":295,"context_line":"            help\u003d\"Destination port, may be a range: 137:139 (default: 0; \""},{"line_number":296,"context_line":"                 \"only required for proto tcp and udp)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_785b7655","line":293,"in_reply_to":"dac4157f_7e2c4002","updated":"2015-04-22 22:14:23.000000000","message":"The point of doing this is to not require --dst-port for ICMP rules, it\u0027s meaningless.\n\nIt might be useful to add sanity checking in take_action(), but I think this is a correct fix for the immediate problem of a bad UI.","commit_id":"9f966785cc620a2b3f97a17c51d9c2f40acaacc3"}]}