)]}'
{"openstackclient/shell.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c919d0da89fa6dccfe61a58f7f1f2b92bba930fe","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            except Exception as e:"},{"line_number":325,"context_line":"                # NOTE(jaosorior): If there is no session then it makes no"},{"line_number":326,"context_line":"                # sense for us to continue."},{"line_number":327,"context_line":"                if not self.client_manager.session:"},{"line_number":328,"context_line":"                    raise"},{"line_number":329,"context_line":"                self.log.warning(\"Possible error authenticating: \" + str(e))"},{"line_number":330,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_07d7c74b","line":327,"updated":"2015-04-27 06:21:35.000000000","message":"i would think that if auth_ref isn\u0027t set then session is definitely not set either, so maybe we should change this to log + raise (and get rid of the pass)?","commit_id":"5c5526ccd131e4512ce71b54e8f30b7acb8527e3"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"87010ad585c34732363bb9a9750dbdd52ac9b7de","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            except Exception as e:"},{"line_number":325,"context_line":"                # NOTE(jaosorior): If there is no session then it makes no"},{"line_number":326,"context_line":"                # sense for us to continue."},{"line_number":327,"context_line":"                if not self.client_manager.session:"},{"line_number":328,"context_line":"                    raise"},{"line_number":329,"context_line":"                self.log.warning(\"Possible error authenticating: \" + str(e))"},{"line_number":330,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_ba57cdc9","line":327,"in_reply_to":"9abe1de1_372078f7","updated":"2015-04-27 08:53:10.000000000","message":"I see this was added since it conflicted with the complete command. And I see this change breaks that. I\u0027ll figure out another solution.","commit_id":"5c5526ccd131e4512ce71b54e8f30b7acb8527e3"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"47af123db112d5fe2d2c3dd41ecf2669f57c958d","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            except Exception as e:"},{"line_number":325,"context_line":"                # NOTE(jaosorior): If there is no session then it makes no"},{"line_number":326,"context_line":"                # sense for us to continue."},{"line_number":327,"context_line":"                if not self.client_manager.session:"},{"line_number":328,"context_line":"                    raise"},{"line_number":329,"context_line":"                self.log.warning(\"Possible error authenticating: \" + str(e))"},{"line_number":330,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_372078f7","line":327,"in_reply_to":"bab921fb_07d7c74b","updated":"2015-04-27 08:38:37.000000000","message":"I was actually considering getting rid of the pass, though it seems that it was introduced here:\n\nhttps://review.openstack.org/#/c/78758/\n\nI could delete the pass, introduce a raise and add Terry as a reviewer to see if he has any insights.","commit_id":"5c5526ccd131e4512ce71b54e8f30b7acb8527e3"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d40d03ff862ef013e4d3c7fc201b5dafb5ccc6f6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def __init__(self):"},{"line_number":75,"context_line":"        # Patch command.Command to add a default auth_required \u003d True"},{"line_number":76,"context_line":"        command.Command.auth_required \u003d True"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Some commands do not need authentication"},{"line_number":79,"context_line":"        help.HelpCommand.auth_required \u003d False"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_16521cde","line":77,"updated":"2015-04-27 13:38:57.000000000","message":"Shouldn\u0027t the complete command have auth_required \u003d False here?","commit_id":"c926ad113048f111df2effc556cd460ea9c8cc0e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"2d4ad08bb582215b016862dd5f53cd271080c367","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def __init__(self):"},{"line_number":75,"context_line":"        # Patch command.Command to add a default auth_required \u003d True"},{"line_number":76,"context_line":"        command.Command.auth_required \u003d True"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Some commands do not need authentication"},{"line_number":79,"context_line":"        help.HelpCommand.auth_required \u003d False"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_36f2b89b","line":77,"in_reply_to":"7ad32947_16521cde","updated":"2015-04-27 13:44:11.000000000","message":"good idea! Let me try that.","commit_id":"c926ad113048f111df2effc556cd460ea9c8cc0e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"95b0718bb2b018b6303c9ecc46051f910ce6bbfc","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            return"},{"line_number":325,"context_line":"        if cmd.auth_required:"},{"line_number":326,"context_line":"            # Trigger the Identity client to initialize"},{"line_number":327,"context_line":"            self.client_manager.auth_ref"},{"line_number":328,"context_line":"        return"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def clean_up(self, cmd, result, err):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_f687a010","line":327,"updated":"2015-04-27 13:40:13.000000000","message":"I never understood why the exception was ignored here.  Was there some reason?","commit_id":"c926ad113048f111df2effc556cd460ea9c8cc0e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"2d4ad08bb582215b016862dd5f53cd271080c367","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            return"},{"line_number":325,"context_line":"        if cmd.auth_required:"},{"line_number":326,"context_line":"            # Trigger the Identity client to initialize"},{"line_number":327,"context_line":"            self.client_manager.auth_ref"},{"line_number":328,"context_line":"        return"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def clean_up(self, cmd, result, err):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_56f53481","line":327,"in_reply_to":"7ad32947_f687a010","updated":"2015-04-27 13:44:11.000000000","message":"I have no idea, I looked at the git blame and thought you had added it. But it seems you had made some changes and that\u0027s why your name appeared there.","commit_id":"c926ad113048f111df2effc556cd460ea9c8cc0e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8d74b9dbb05766ec66a957eb72d7684c8b50297d","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        )"},{"line_number":322,"context_line":"        if cmd.auth_required:"},{"line_number":323,"context_line":"            # Trigger the Identity client to initialize"},{"line_number":324,"context_line":"            self.client_manager.auth_ref"},{"line_number":325,"context_line":"        return"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def clean_up(self, cmd, result, err):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad32947_1c17ddee","line":324,"updated":"2015-04-27 14:14:31.000000000","message":"I think the reason for ignoring this exception went away during the OCC integration, but I don\u0027t completely understand why it was here in the first place.","commit_id":"48b52a0d40013d65e85ebeadcfb80a06c431b6db"}]}