)]}'
{"openstackclient/shell.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a1007685b8ebabb3474af97a0c2209526fe7d71a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            self.verify \u003d not getattr(self.cloud.config, \u0027insecure\u0027, False)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        # Neutralize verify option"},{"line_number":259,"context_line":"        self.options.verify \u003d None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Save default domain"},{"line_number":262,"context_line":"        self.default_domain \u003d self.options.os_default_domain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b1b320e9","side":"PARENT","line":259,"updated":"2015-05-01 17:27:24.000000000","message":"This does need to be removed...","commit_id":"28f65e665045c1c6d0697f856f06020c7c8e656a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a1007685b8ebabb3474af97a0c2209526fe7d71a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        if cacert:"},{"line_number":250,"context_line":"            self.verify \u003d cacert"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            self.verify \u003d not self.cloud.config.get(\u0027insecure\u0027, False)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Neutralize verify option"},{"line_number":255,"context_line":"        self.options.verify \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_51828c95","line":252,"updated":"2015-05-01 17:27:24.000000000","message":"yup, this is a problem...","commit_id":"5756576548dbf2bc1e8e63c46cf25af90c0362b9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1c3ed582357d6d42969a586a8d5b056311bdf7fd","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            self.verify \u003d not self.cloud.config.get(\u0027insecure\u0027, False)"},{"line_number":253,"context_line":"            # NOTE(thowe): verify has to have special conversion handling"},{"line_number":254,"context_line":"            #              because it is not supported as a bool in occ."},{"line_number":255,"context_line":"            verify \u003d self.cloud.config.get(\u0027verify\u0027, None)"},{"line_number":256,"context_line":"            if verify is not None:"},{"line_number":257,"context_line":"                self.verify \u003d str(verify).lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_eeb40ef3","line":254,"updated":"2015-05-02 00:58:02.000000000","message":"This is not true, it actually is ignored in occ, as it should be, and is properly passed along.","commit_id":"40a2945998711440193fefee1786fa535fdc72e5"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7c5ae91753f9681b89eb465246b2451a0f4a42be","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            self.verify \u003d not self.cloud.config.get(\u0027insecure\u0027, False)"},{"line_number":253,"context_line":"            # NOTE(thowe): verify has to have special conversion handling"},{"line_number":254,"context_line":"            #              because it is not supported as a bool in occ."},{"line_number":255,"context_line":"            verify \u003d self.cloud.config.get(\u0027verify\u0027, None)"},{"line_number":256,"context_line":"            if verify is not None:"},{"line_number":257,"context_line":"                self.verify \u003d str(verify).lower() \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_29756097","line":254,"in_reply_to":"3acd31a7_eeb40ef3","updated":"2015-05-02 01:28:44.000000000","message":"OCC handles the string to boolean conversion for insecure.  It does not do that for verify.","commit_id":"40a2945998711440193fefee1786fa535fdc72e5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1c3ed582357d6d42969a586a8d5b056311bdf7fd","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            #              because it is not supported as a bool in occ."},{"line_number":255,"context_line":"            verify \u003d self.cloud.config.get(\u0027verify\u0027, None)"},{"line_number":256,"context_line":"            if verify is not None:"},{"line_number":257,"context_line":"                self.verify \u003d str(verify).lower() \u003d\u003d \u0027true\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # Save default domain"},{"line_number":260,"context_line":"        self.default_domain \u003d self.options.os_default_domain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_0e93ca50","line":257,"updated":"2015-05-02 00:58:02.000000000","message":"It looks like o-c-c (or rather yaml.safe_load()) does proper boolean handling, is there another reason why the string compare is needed here?  And if it is needed, do we need to handle insecure the same way?","commit_id":"40a2945998711440193fefee1786fa535fdc72e5"}]}
