)]}'
{"id":"openstack%2Fpython-openstackclient~179446","triplet_id":"openstack%2Fpython-openstackclient~master~I0a69f3f196a36f267ee85a651b09aa8d3c328121","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1450872","hashtags":[],"change_id":"I0a69f3f196a36f267ee85a651b09aa8d3c328121","subject":"Security group rule delete broken","status":"MERGED","created":"2015-05-01 18:23:27.000000000","updated":"2015-05-07 23:13:25.000000000","submitted":"2015-05-07 23:13:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b68f3ef96e446fb7ff908500b5d3d993816b5909","_number":179446,"virtual_id_number":179446,"owner":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-05-07 23:13:24.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-05-07 20:19:41.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-05-07 22:17:09.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-05-07 22:17:09.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-07 20:19:41.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-05-07 22:17:09.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-05-07 23:13:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e59480844fb1cee136ffc65a1b9ac4ad2335bd7e","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-01 18:23:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3fabd897541d990f9a6762c8b5099f49fa57aa4f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-01 19:04:09.000000000","message":"Patch Set 1:\n\nThis is a major compatibility change, is it possible to do both ways?","accounts_in_message":[],"_revision_number":1},{"id":"bb5b0190ac40ee29096d9cd8f9c510663673bc28","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-01 19:08:36.000000000","message":"Patch Set 1:\n\nYeh, I hear you, but the SecurityGroupRule Manager has no query by proto/port method.  Also, it should be been this way to begin with.  Also, and probably related, this is the way Neutron does it:\n\nhttp://developer.openstack.org/api-ref-networking-v2-ext.html#deleteSecGroupRule","accounts_in_message":[],"_revision_number":1},{"id":"d6c0680b1b2397b241a108112a026cedd76035be","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-01 19:14:21.000000000","message":"Patch Set 1: Code-Review-1\n\nWhat the REST API does really isn\u0027t the point.  If what we had never worked, then CLI compatibility is less of an issue as anything will produce the same non-result.  If it did work then we need to attempt to maintain CLI compatibility.\n\nThe command doc needs updating either way, and if we can not maintain compatibility, a note needs to be added to backwards-incompatible.rst.","accounts_in_message":[],"_revision_number":1},{"id":"341898711dfc358eb2c009b64114439ae715980c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-01 19:31:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/46/179446/1/check/gate-python-openstackclient-python26/61457b2/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/46/179446/1/check/gate-python-openstackclient-pep8/2727575/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/46/179446/1/check/gate-python-openstackclient-docs/b2b8520//doc/build/html/ : SUCCESS in 2m 32s\n- gate-python-openstackclient-python27 http://logs.openstack.org/46/179446/1/check/gate-python-openstackclient-python27/b51249a/ : SUCCESS in 1m 38s\n- gate-python-openstackclient-python34 http://logs.openstack.org/46/179446/1/check/gate-python-openstackclient-python34/6528f23/ : SUCCESS in 3m 38s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/46/179446/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/4e7e3e5/ : SUCCESS in 1h 00m 27s\n- check-osc-dsvm-functional http://logs.openstack.org/46/179446/1/check/check-osc-dsvm-functional/b2a6ede/ : SUCCESS in 20m 05s","accounts_in_message":[],"_revision_number":1},{"id":"52b4580c4e676afe32f11a4d96ae36fa8c5763c3","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-07 19:10:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b1dcaedf5b79d76f467496875ee5408d798414ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-07 20:10:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/46/179446/2/check/gate-python-openstackclient-python26/c83eb9a/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/46/179446/2/check/gate-python-openstackclient-pep8/d7e3e3f/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/46/179446/2/check/gate-python-openstackclient-docs/27f39d9//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/46/179446/2/check/gate-python-openstackclient-python27/93e0cb1/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-python34 http://logs.openstack.org/46/179446/2/check/gate-python-openstackclient-python34/29fc9c2/ : SUCCESS in 1m 55s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/46/179446/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/b747cdb/ : SUCCESS in 44m 14s\n- check-osc-dsvm-functional http://logs.openstack.org/46/179446/2/check/check-osc-dsvm-functional/2e7da97/ : SUCCESS in 19m 36s","accounts_in_message":[],"_revision_number":2},{"id":"89671f41fed274e85c367af5c9b6c8bebf46e714","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-05-07 20:19:41.000000000","message":"Patch Set 2: Code-Review+2\n\nthanks for adding the note","accounts_in_message":[],"_revision_number":2},{"id":"9bda90c3cef18ca7178644799586e90c4d9b227e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-07 22:17:09.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nIt doesn\u0027t look like anything changed here in novaclient in years, maybe Nova itself?  I like this interface better either way.","accounts_in_message":[],"_revision_number":2},{"id":"e381092d635e852e0c330ec7330431e3163292a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-07 22:17:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b4396cf64a3096e6c70047445916de2051d17eb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-07 23:13:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/46/179446/2/gate/gate-python-openstackclient-python26/c2aca9a/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/46/179446/2/gate/gate-python-openstackclient-docs/04e4cd5//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/46/179446/2/gate/gate-python-openstackclient-pep8/77bc1ee/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/46/179446/2/gate/gate-python-openstackclient-python27/3e0a175/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python34 http://logs.openstack.org/46/179446/2/gate/gate-python-openstackclient-python34/25a6807/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/46/179446/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/84b28fd/ : SUCCESS in 55m 57s\n- gate-osc-dsvm-functional http://logs.openstack.org/46/179446/2/gate/gate-osc-dsvm-functional/8244d8d/ : SUCCESS in 16m 21s","accounts_in_message":[],"_revision_number":2},{"id":"b0fa175b892e0867e9acdbdba468ea3042a02f5d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-07 23:13:25.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"62bb88f621140670c1c2f26397f97cd87fd66b18","revisions":{"d41fa0ec43bc284e734599649ab631746e447f4f":{"kind":"REWORK","_number":1,"created":"2015-05-01 18:23:27.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/46/179446/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/179446/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/1"}}},"commit":{"parents":[{"commit":"28f65e665045c1c6d0697f856f06020c7c8e656a","subject":"Merge \"Create 1.2.0 release notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/28f65e665045c1c6d0697f856f06020c7c8e656a"}]}],"author":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-01 18:21:08.000000000","tz":-360},"committer":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-01 18:21:08.000000000","tz":-360},"subject":"Security group rule delete broken","message":"Security group rule delete broken\n\nNova client was changed to take a rule id for security group\nrule delete.\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72\n\nChange-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121\nCloses-Bug: #1450872\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d41fa0ec43bc284e734599649ab631746e447f4f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d41fa0ec43bc284e734599649ab631746e447f4f"}]},"branch":"refs/heads/master"},"62bb88f621140670c1c2f26397f97cd87fd66b18":{"kind":"REWORK","_number":2,"created":"2015-05-07 19:10:17.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/46/179446/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/179446/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/179446/2"}}},"commit":{"parents":[{"commit":"28f65e665045c1c6d0697f856f06020c7c8e656a","subject":"Merge \"Create 1.2.0 release notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/28f65e665045c1c6d0697f856f06020c7c8e656a"}]}],"author":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-01 18:21:08.000000000","tz":-360},"committer":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2015-05-07 19:10:06.000000000","tz":-360},"subject":"Security group rule delete broken","message":"Security group rule delete broken\n\nNova client was changed to take a rule id for security group\nrule delete.\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72\n\nChange-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121\nCloses-Bug: #1450872\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/62bb88f621140670c1c2f26397f97cd87fd66b18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/62bb88f621140670c1c2f26397f97cd87fd66b18"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
