)]}'
{"openstackclient/tests/test_shell.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d9f7391ea1f097d3a59910bcd46c388595147c64","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        }"},{"line_number":558,"context_line":"        self._assert_cli(flag, kwargs)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    @mock.patch(\"os_client_config.config.OpenStackConfig._load_config_file\")"},{"line_number":561,"context_line":"    def test_shell_args_cloud_no_vendor(self, config_mock):"},{"line_number":562,"context_line":"        config_mock.return_value \u003d copy.deepcopy(CLOUD_1)"},{"line_number":563,"context_line":"        _shell \u003d make_shell()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_8b690c28","line":560,"updated":"2015-05-01 23:13:00.000000000","message":"I get what you are after here and do what you like because you will, but \n\n* actually testing code that is not part of OSC here is really strange\n* unit test of shell.py should mock cloud_config.set_default and cloud_config.OpenStackConfig()\n* this is essentially a functional test\n* the fact that you can\u0027t test a method of shell.py, that you have to fake_execute the thing is a bad code smell to shell.py.  It obviously isn\u0027t structured in a way that makes it easily testable which is not a good thing.","commit_id":"90705f191e7f3831ecf9426679d5474ef5e5fecc"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4cd034425ddab9b7311fa7ac6027aba3c5460437","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        }"},{"line_number":558,"context_line":"        self._assert_cli(flag, kwargs)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    @mock.patch(\"os_client_config.config.OpenStackConfig._load_config_file\")"},{"line_number":561,"context_line":"    def test_shell_args_cloud_no_vendor(self, config_mock):"},{"line_number":562,"context_line":"        config_mock.return_value \u003d copy.deepcopy(CLOUD_1)"},{"line_number":563,"context_line":"        _shell \u003d make_shell()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_6e1b5e1c","line":560,"in_reply_to":"3acd31a7_8b690c28","updated":"2015-05-01 23:58:35.000000000","message":"You are right that this really is more of a functional test and should be moved.  (the rest of my reply is in the top-level comment so it is easier to follow...)","commit_id":"90705f191e7f3831ecf9426679d5474ef5e5fecc"}]}