)]}'
{"id":"openstack%2Fpython-openstackclient~180018","triplet_id":"openstack%2Fpython-openstackclient~stable%2Fkilo~Id95a8520e935c1092d5a22ecd8ea01f572334ac8","project":"openstack/python-openstackclient","branch":"stable/kilo","topic":"bug/1445528","hashtags":[],"change_id":"Id95a8520e935c1092d5a22ecd8ea01f572334ac8","subject":"Role operations should not require list object permission","status":"ABANDONED","created":"2015-05-05 03:33:22.000000000","updated":"2015-09-15 23:06:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6e318998b437dc27983512477a4767da327ddc08","_number":180018,"virtual_id_number":180018,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-05-05 12:58:12.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"date":"2015-05-06 14:45:49.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2015-05-05 05:11:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-05 03:33:22.000000000","updated_by":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"reviewer":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"state":"REVIEWER"},{"updated":"2015-05-05 05:11:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-05 12:58:12.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-05-06 14:45:49.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"92b7b17e7592b52601e0ede4e47971c5ca4176fd","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-05-05 03:33:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e3a505d5521a75c3678e5477443ce448e71db78","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-05-05 03:34:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee3490451dcdaff89b18601e3c7212cc9ed34598","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-05 05:11:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/18/180018/2/check/gate-python-openstackclient-python26/4f5833b/ : SUCCESS in 1m 27s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/18/180018/2/check/gate-python-openstackclient-pep8/5481738/ : SUCCESS in 1m 02s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/18/180018/2/check/gate-python-openstackclient-docs/a9b2853//doc/build/html/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/18/180018/2/check/gate-python-openstackclient-python27/3f95715/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/18/180018/2/check/gate-python-openstackclient-python34/35ec4d5/ : SUCCESS in 3m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/18/180018/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/418c973/ : SUCCESS in 58m 54s\n- check-osc-dsvm-functional http://logs.openstack.org/18/180018/2/check/check-osc-dsvm-functional/1eeb5f9/ : SUCCESS in 20m 17s","accounts_in_message":[],"_revision_number":2},{"id":"7ab92aac422317fd8ab77c61f1d32789af1637d3","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-05 12:58:12.000000000","message":"Patch Set 2:\n\nI was real confused because Steve just refactored that code, but I guess it wasn\u0027t on stable/kilo\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/identity/common.py","accounts_in_message":[],"_revision_number":2},{"id":"fe0f522abfcd5218331e69cd6766605046bff412","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-05-06 14:45:49.000000000","message":"Patch Set 2:\n\n@Terry, yeah, that\u0027s weird, i thought that landed before kilo was made.\n\nShould be backport both?","accounts_in_message":[],"_revision_number":2},{"id":"b4f9549b418cbe64a9c49c3b40d78754ff9e75ce","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-06 15:38:14.000000000","message":"Patch Set 2:\n\nI don\u0027t think there is much motivation to backport the refactoring to stable/kilo as long as this change makes it into the refactored master branch.","accounts_in_message":[],"_revision_number":2},{"id":"60f2960298509b93b6df31ba0c51e3eac4eec0f4","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-09-15 23:06:27.000000000","message":"Abandoned\n\nnot going into stable","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ba75f18af21a440d1444c33e6142d54f2a774a69","revisions":{"6ac39ddcaa42a6116f2a1f43a117f2f0fa8eaa6a":{"kind":"REWORK","_number":1,"created":"2015-05-05 03:33:22.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/18/180018/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/18/180018/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/1"}}},"commit":{"parents":[{"commit":"bee11edd327c52c64d0ddef784c52c8e0138ea58","subject":"Merge \"Updated from global requirements\" into stable/kilo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bee11edd327c52c64d0ddef784c52c8e0138ea58"}]}],"author":{"name":"Nathan Kinder","email":"nkinder@redhat.com","date":"2015-04-17 02:12:45.000000000","tz":-420},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-05-05 03:33:08.000000000","tz":600},"subject":"Role operations should not require list object permission","message":"Role operations should not require list object permission\n\nWhen using Keystone\u0027s policy.v3cloudsample.json policy file, a project admin is\nsupposed to be able to manage role assignments.  Unfortunately, a project admin\nisn\u0027t allowed to perform these operations using python-openstackclient, as we\nattempt to perform list operations for any of the object types specified (users,\ngroups, projects). This is done in an attempt to lookup the id of the object by\nname, but we perform this list operation even when the user specifies everything\nby id. This causes 403 errors.\n\nThis patch still attempts to look up the object id by name, but we catch the 403\nand assume that the user specified an id if the list operation is not allowed.\nThis is similar to what we do with the --domain option for other commands.\n\nCloses-bug: #1445528\nChange-Id: Id95a8520e935c1092d5a22ecd8ea01f572334ac8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6ac39ddcaa42a6116f2a1f43a117f2f0fa8eaa6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6ac39ddcaa42a6116f2a1f43a117f2f0fa8eaa6a"}]},"branch":"refs/heads/stable/kilo"},"ba75f18af21a440d1444c33e6142d54f2a774a69":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-05-05 03:34:03.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/18/180018/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/18/180018/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/18/180018/2"}}},"commit":{"parents":[{"commit":"bee11edd327c52c64d0ddef784c52c8e0138ea58","subject":"Merge \"Updated from global requirements\" into stable/kilo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bee11edd327c52c64d0ddef784c52c8e0138ea58"}]}],"author":{"name":"Nathan Kinder","email":"nkinder@redhat.com","date":"2015-04-17 02:12:45.000000000","tz":-420},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-05-05 03:33:47.000000000","tz":600},"subject":"Role operations should not require list object permission","message":"Role operations should not require list object permission\n\nWhen using Keystone\u0027s policy.v3cloudsample.json policy file, a project admin is\nsupposed to be able to manage role assignments.  Unfortunately, a project admin\nisn\u0027t allowed to perform these operations using python-openstackclient, as we\nattempt to perform list operations for any of the object types specified (users,\ngroups, projects). This is done in an attempt to lookup the id of the object by\nname, but we perform this list operation even when the user specifies everything\nby id. This causes 403 errors.\n\nThis patch still attempts to look up the object id by name, but we catch the 403\nand assume that the user specified an id if the list operation is not allowed.\nThis is similar to what we do with the --domain option for other commands.\n\nCloses-bug: #1445528\nChange-Id: Id95a8520e935c1092d5a22ecd8ea01f572334ac8\n(cherry picked from commit 4c107e6f1b1913988e208b31206c84ab851b780c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ba75f18af21a440d1444c33e6142d54f2a774a69"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ba75f18af21a440d1444c33e6142d54f2a774a69"}]},"branch":"refs/heads/stable/kilo"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
