)]}'
{"openstackclient/identity/common.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4117143083fb549cae0a9b8f24e2ac344901ddc3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                   domains.Domain)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def find_group(identity_client, name_or_id, domain\u003dNone):"},{"line_number":52,"context_line":"    kwargs \u003d {\u0027domain_id\u0027: domain.id} if domain is not None else {}"},{"line_number":53,"context_line":"    return _find_identity_resource(identity_client.groups, name_or_id,"},{"line_number":54,"context_line":"                                   groups.Group, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad58531_e116aea6","line":51,"updated":"2015-05-11 21:18:10.000000000","message":"nit: I think it would be more consistent if we\u0027re taking domain_id as argument here rather than a domain object. It would also be less error prone.\n\nAlso trying to figure out how to extract the domain_id from the domain object seems like should not be here.","commit_id":"17dfaec469b874da3c076e0fc64197ce7a4cc3ce"}],"openstackclient/identity/v3/role.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ff29f5afc8f35ea744a87bfce2dd1aac6e418a91","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        return parser"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _needed_arguments_provided(self, parsed_args):"},{"line_number":90,"context_line":"        return (parsed_args.user or parsed_args.domain or"},{"line_number":91,"context_line":"                parsed_args.group or parsed_args.project)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_9cf6f7f7","line":89,"updated":"2015-05-07 17:39:36.000000000","message":"Why did you pull this out?  Do you have plans to use it elsewhere?","commit_id":"944a249a6ab6869779aa2e0297e030533b4d01a5"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9c85749175cc89c13f4bfc883dd6da98ddcf66f8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        return parser"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _needed_arguments_provided(self, parsed_args):"},{"line_number":90,"context_line":"        return (parsed_args.user or parsed_args.domain or"},{"line_number":91,"context_line":"                parsed_args.group or parsed_args.project)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_af5f3240","line":89,"in_reply_to":"1aca2d91_9cf6f7f7","updated":"2015-05-07 20:21:13.000000000","message":"not really, I just found it more readable if I saw a declaration such as\n\nif not self._needed_arguments_provided(parsed_args):\n\nsince then I can see what was intended instead of figuring out what the \"not and\":s were about.\n\nIf you don\u0027t think it\u0027s more readable and there is an issue with the code I can of course change it back.","commit_id":"944a249a6ab6869779aa2e0297e030533b4d01a5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ecd40a696b532b6ccb1e83a6b25372fc21615219","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        return parser"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _needed_arguments_provided(self, parsed_args):"},{"line_number":90,"context_line":"        return (parsed_args.user or parsed_args.domain or"},{"line_number":91,"context_line":"                parsed_args.group or parsed_args.project)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_6a30e801","line":89,"in_reply_to":"1aca2d91_af5f3240","updated":"2015-05-07 20:46:14.000000000","message":"I prefer to leave things like this inlined when it is not large, I don\u0027t see a benefit to look elsewhere for the declaration to see _what_ is required.","commit_id":"944a249a6ab6869779aa2e0297e030533b4d01a5"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4117143083fb549cae0a9b8f24e2ac344901ddc3","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if parsed_args.user and parsed_args.domain:"},{"line_number":103,"context_line":"            user_domain \u003d None"},{"line_number":104,"context_line":"            if parsed_args.user_domain:"},{"line_number":105,"context_line":"                user_domain \u003d common.find_domain("},{"line_number":106,"context_line":"                    identity_client,"},{"line_number":107,"context_line":"                    parsed_args.user_domain,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad58531_61519e62","line":104,"updated":"2015-05-11 21:18:10.000000000","message":"nit: the code for finding user/group/project are duplicated, would be nice if we reduce the code duplication.","commit_id":"17dfaec469b874da3c076e0fc64197ce7a4cc3ce"}]}