)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0dac913e44a38e46e0820b3200027eb8cf115fff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"a CLI optional argument/ENV variable setting. We will name this new"},{"line_number":11,"context_line":"optional argument: --os-endpoint-type (Env: OS_ENDPOINT_TYPE) and"},{"line_number":12,"context_line":"based on the value given, the service API will use that specific"},{"line_number":13,"context_line":"endpoint type. Possible values: public, admin, internal."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"Closes-Bug: #1454392"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa32b979_4cab4076","line":13,"updated":"2015-06-25 22:34:24.000000000","message":"Are these possible values strict?  If so, can we make this an enum and check for invalid endpoint types?","commit_id":"de853b39d38d777bd8b21352eac40d46cbb3a268"}],"doc/source/man/openstack.rst":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b470b35366188c02f48cafd4a6e3abb1cdb768a3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    Additional API version options will be available depending on the installed API libraries."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":":option:`--os-endpoint-type` \u003cendpoint-type\u003e"},{"line_number":124,"context_line":"    Endpoint interface type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"COMMANDS"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_fef2e405","line":124,"updated":"2015-06-29 16:15:37.000000000","message":"Endpoint type. Valid options are `public`, `admin`, and `internal`.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    Additional API version options will be available depending on the installed API libraries."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":":option:`--os-endpoint-type` \u003cendpoint-type\u003e"},{"line_number":124,"context_line":"    Endpoint interface type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"COMMANDS"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_56265069","line":124,"in_reply_to":"ba3cc151_fef2e405","updated":"2015-06-29 19:05:33.000000000","message":"Done","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b470b35366188c02f48cafd4a6e3abb1cdb768a3","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    Additional API version options will be available depending on the installed API libraries."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":":envvar:`OS_ENDPOINT_TYPE`"},{"line_number":350,"context_line":"    Endpoint interface type"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"BUGS"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_1ef8e8e4","line":350,"updated":"2015-06-29 16:15:37.000000000","message":"Endpoint type. Valid options are `public`, `admin`, and `internal`.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    Additional API version options will be available depending on the installed API libraries."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":":envvar:`OS_ENDPOINT_TYPE`"},{"line_number":350,"context_line":"    Endpoint interface type"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"BUGS"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_762b5431","line":350,"in_reply_to":"ba3cc151_1ef8e8e4","updated":"2015-06-29 19:05:33.000000000","message":"Done","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"}],"openstackclient/common/clientmanager.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"0f1a1079399ac381dbd5ec759db31b4f7c7d14d4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_endpoint_for_service_type(self, service_type, region_name\u003dNone,"},{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_4ba54d02","line":188,"updated":"2015-06-29 18:26:15.000000000","message":"note that \u0027if not\u0027 checks for a false value. So theoretically you are catching both an empty string and None here. That should be safe in this case but keep it in mind for the future.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_endpoint_for_service_type(self, service_type, region_name\u003dNone,"},{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_76cfd4b0","line":188,"in_reply_to":"ba3cc151_4ba54d02","updated":"2015-06-29 19:05:33.000000000","message":"understood.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b470b35366188c02f48cafd4a6e3abb1cdb768a3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"},{"line_number":192,"context_line":"        if self.auth_ref:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_9e0078ac","line":189,"updated":"2015-06-29 16:15:37.000000000","message":"How\u0027s this different from defaulting it to \u0027public\u0027 at line 186?","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"},{"line_number":192,"context_line":"        if self.auth_ref:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_d6bee0fe","line":189,"in_reply_to":"ba3cc151_0bde656d","updated":"2015-06-29 19:05:33.000000000","message":"Done","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"0f1a1079399ac381dbd5ec759db31b4f7c7d14d4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"},{"line_number":192,"context_line":"        if self.auth_ref:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_0bde656d","line":189,"in_reply_to":"ba3cc151_9e0078ac","updated":"2015-06-29 18:26:15.000000000","message":"The code would be more clear if the endpoint_type defaulted to \u0027public\u0027 and the check against None is made as well.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                      endpoint_type\u003dNone):"},{"line_number":187,"context_line":"        \"\"\"Return the endpoint URL for the service type.\"\"\""},{"line_number":188,"context_line":"        if not endpoint_type:"},{"line_number":189,"context_line":"            endpoint_type \u003d \u0027public\u0027"},{"line_number":190,"context_line":"        # See if we are using password flow auth, i.e. we have a"},{"line_number":191,"context_line":"        # service catalog to select endpoints from"},{"line_number":192,"context_line":"        if self.auth_ref:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_f600c4ac","line":189,"in_reply_to":"ba3cc151_9e0078ac","updated":"2015-06-29 19:05:33.000000000","message":"this is for the case when we pass a None or empty string value for endpoint_type. auth_ref.service_catalog.url_for will fail if we pass  endpoint_type\u003dNone to it.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"}],"openstackclient/compute/client.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"b6459dc6797ed3c9151c2cd07c8ce6de638e0f2d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    extensions \u003d [extension.Extension(\u0027list_extensions\u0027, list_extensions)]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kwargs \u003d {}"},{"line_number":52,"context_line":"    # If endpoint_type is not set we don\u0027t want to pass None param value"},{"line_number":53,"context_line":"    # to compute_client because it will prevent picking up a default later"},{"line_number":54,"context_line":"    if instance._endpoint_type:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_cd79bfc9","line":51,"updated":"2015-06-25 01:23:26.000000000","message":"There are too many negatives in this comment.\n\nSomething simpler like \"Remember endpoint_type if it is set\" is easier to read.","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"ca5342209c3fd87e81b562f4032ff8b09b3107cb","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    extensions \u003d [extension.Extension(\u0027list_extensions\u0027, list_extensions)]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kwargs \u003d {}"},{"line_number":52,"context_line":"    # If endpoint_type is not set we don\u0027t want to pass None param value"},{"line_number":53,"context_line":"    # to compute_client because it will prevent picking up a default later"},{"line_number":54,"context_line":"    if instance._endpoint_type:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_afd1accd","line":51,"in_reply_to":"fa32b979_cd79bfc9","updated":"2015-06-25 16:56:43.000000000","message":"I agree, I\u0027ll try to re-write the comment in a ore positive and simple manner","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"}],"openstackclient/identity/client.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"b6459dc6797ed3c9151c2cd07c8ce6de638e0f2d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        API_VERSIONS)"},{"line_number":47,"context_line":"    LOG.debug(\u0027Instantiating identity client: %s\u0027, identity_client)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    kwargs \u003d {}"},{"line_number":50,"context_line":"    # If endpoint_type is not set we don\u0027t want to pass None param value"},{"line_number":51,"context_line":"    # to identity_client because it will prevent picking up a default later"},{"line_number":52,"context_line":"    if instance._endpoint_type:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_8d7f37aa","line":49,"updated":"2015-06-25 01:23:26.000000000","message":"There is a bit of a code smell here as each client.py is repeating the exact same check. Is there no way to consolidate this code?","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"aabc7f76a5f36db6f4d6a0ec38292f5a5351f967","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        API_VERSIONS)"},{"line_number":47,"context_line":"    LOG.debug(\u0027Instantiating identity client: %s\u0027, identity_client)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    kwargs \u003d {}"},{"line_number":50,"context_line":"    # If endpoint_type is not set we don\u0027t want to pass None param value"},{"line_number":51,"context_line":"    # to identity_client because it will prevent picking up a default later"},{"line_number":52,"context_line":"    if instance._endpoint_type:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_bfc26232","line":49,"in_reply_to":"fa32b979_8d7f37aa","updated":"2015-06-25 02:10:09.000000000","message":"I think clients use a different parameter for endpoint-type, so each one needs to handle this.","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0dac913e44a38e46e0820b3200027eb8cf115fff","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        client \u003d identity_client("},{"line_number":52,"context_line":"            session\u003dinstance.session,"},{"line_number":53,"context_line":"            region_name\u003dinstance._region_name,"},{"line_number":54,"context_line":"            interface\u003dinstance._endpoint_type,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"    else:"},{"line_number":57,"context_line":"        client \u003d identity_client("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_4cefc0e9","line":54,"updated":"2015-06-25 22:34:24.000000000","message":"I\u0027d probably write this instead as:\n\ninterface \u003d instance._endpoint_type if instance._endpoint_type else None\n\nclient \u003d identity_client(\n    session\u003dinstance.session,\n    region_name\u003dinstance._region_name,\n    interface\u003dinterface\n)","commit_id":"de853b39d38d777bd8b21352eac40d46cbb3a268"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"b6e8cbcc26f456aa269410a630f4ab5f5c6f1366","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        client \u003d identity_client("},{"line_number":52,"context_line":"            session\u003dinstance.session,"},{"line_number":53,"context_line":"            region_name\u003dinstance._region_name,"},{"line_number":54,"context_line":"            interface\u003dinstance._endpoint_type,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"    else:"},{"line_number":57,"context_line":"        client \u003d identity_client("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_0a22d401","line":54,"in_reply_to":"fa32b979_4cefc0e9","updated":"2015-06-26 16:40:39.000000000","message":"I re-wrote this in a more elegant manner in the latest patch. The important thing here is that we do not want to pass the parameter at all if it is None or empty, because it will prevent picking up the default from the client code (in this case from keystoneclient).","commit_id":"de853b39d38d777bd8b21352eac40d46cbb3a268"}],"openstackclient/shell.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"f28ec8d258b76558652ba489d3dafff6eb0a8785","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                default\u003dDEFAULT_DOMAIN),"},{"line_number":204,"context_line":"            help\u003d\u0027Default domain ID, default\u003d\u0027 +"},{"line_number":205,"context_line":"                 DEFAULT_DOMAIN +"},{"line_number":206,"context_line":"                 \u0027 (Env: OS_DEFAULT_DOMAIN)\u0027)"},{"line_number":207,"context_line":"        parser.add_argument("},{"line_number":208,"context_line":"            \u0027--os-endpoint-type\u0027,"},{"line_number":209,"context_line":"            metavar\u003d\u0027\u003cendpoint_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_80dbce7b","line":206,"updated":"2015-05-29 11:25:38.000000000","message":"Maybe set \"valid_endpoint_types \u003d [admin, public, internal]\" here and use it in choices and in the help text.  As far as I\u0027ve seen, those are the only valid endpoint types.","commit_id":"5bf8f8311007705a57506d128bd5bd8ce44ede31"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"0c87303716b73224a56882b93c7ccf12de8f2ccf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                default\u003dDEFAULT_DOMAIN),"},{"line_number":204,"context_line":"            help\u003d\u0027Default domain ID, default\u003d\u0027 +"},{"line_number":205,"context_line":"                 DEFAULT_DOMAIN +"},{"line_number":206,"context_line":"                 \u0027 (Env: OS_DEFAULT_DOMAIN)\u0027)"},{"line_number":207,"context_line":"        parser.add_argument("},{"line_number":208,"context_line":"            \u0027--os-endpoint-type\u0027,"},{"line_number":209,"context_line":"            metavar\u003d\u0027\u003cendpoint_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_aba9aae1","line":206,"in_reply_to":"7a016987_80dbce7b","updated":"2015-06-04 23:01:58.000000000","message":"Yup, good point! I\u0027ll add that enforcement.","commit_id":"5bf8f8311007705a57506d128bd5bd8ce44ede31"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"ad7819fd9cd360a7eb80ade9fa0203d017aad5bc","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        self.default_domain \u003d self.options.default_domain"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # Loop through extensions to get API versions"},{"line_number":296,"context_line":"        for mod in clientmanager.PLUGIN_MODULES:"},{"line_number":297,"context_line":"            version_opt \u003d getattr(self.options, mod.API_VERSION_OPTION, None)"},{"line_number":298,"context_line":"            if version_opt:"},{"line_number":299,"context_line":"                api \u003d mod.API_NAME"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_a7282587","line":296,"updated":"2015-06-24 18:26:23.000000000","message":"Something is breaking functional tests.  i wonder if you should set _endpoint_type to \u0027public\u0027 if it hasn\u0027t been set yet at least for some clients.  Not sure what happens to the clients that were passed None for endpoint type.","commit_id":"74bd1245af10efabe83f9cd7081e84eaa504ec99"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"aa481707b3e53793c38cfc7b720b31d38278fc13","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        self.default_domain \u003d self.options.default_domain"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # Loop through extensions to get API versions"},{"line_number":296,"context_line":"        for mod in clientmanager.PLUGIN_MODULES:"},{"line_number":297,"context_line":"            version_opt \u003d getattr(self.options, mod.API_VERSION_OPTION, None)"},{"line_number":298,"context_line":"            if version_opt:"},{"line_number":299,"context_line":"                api \u003d mod.API_NAME"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_475cb94a","line":296,"in_reply_to":"fa32b979_a7282587","updated":"2015-06-24 18:39:27.000000000","message":"hey Terry, you\u0027re right: we don\u0027t want to pass None value because it\u0027s unpredictable which endpoint it will use. That\u0027s why I have some code that checks if it\u0027s None don\u0027t pass it to the client. \nI would like to avoid having a global default\u003d\u0027public\u0027 because keystone still uses \u0027admin\u0027 by default.","commit_id":"74bd1245af10efabe83f9cd7081e84eaa504ec99"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"b6459dc6797ed3c9151c2cd07c8ce6de638e0f2d","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                 DEFAULT_DOMAIN +"},{"line_number":210,"context_line":"                 \u0027 (Env: OS_DEFAULT_DOMAIN)\u0027)"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--os-endpoint-type\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cendpoint_type\u003e\u0027,"},{"line_number":214,"context_line":"            dest\u003d\u0027endpoint_type\u0027,"},{"line_number":215,"context_line":"            choices\u003d[\u0027admin\u0027, \u0027public\u0027, \u0027internal\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_8d565728","line":212,"updated":"2015-06-25 01:23:26.000000000","message":"Since a new option is being added shouldn\u0027t this patch also include a DocImpact tag?","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"ca5342209c3fd87e81b562f4032ff8b09b3107cb","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                 DEFAULT_DOMAIN +"},{"line_number":210,"context_line":"                 \u0027 (Env: OS_DEFAULT_DOMAIN)\u0027)"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--os-endpoint-type\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cendpoint_type\u003e\u0027,"},{"line_number":214,"context_line":"            dest\u003d\u0027endpoint_type\u0027,"},{"line_number":215,"context_line":"            choices\u003d[\u0027admin\u0027, \u0027public\u0027, \u0027internal\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_af3bece8","line":212,"in_reply_to":"fa32b979_8d565728","updated":"2015-06-25 16:56:43.000000000","message":"Good one. I didn\u0027t know about this DocImpact tag. Let me research where I can add it.","commit_id":"7a7e3ec19f6cc0c011d0cb55aad691f4015bd177"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"45f6148fcb121b9c32c88be3a22e588576477128","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        if tenant_name and not project_name:"},{"line_number":263,"context_line":"            self.options.project_name \u003d tenant_name"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Do configuration file handling"},{"line_number":266,"context_line":"        cc \u003d cloud_config.OpenStackConfig()"},{"line_number":267,"context_line":"        self.log.debug(\"defaults: %s\", cc.defaults)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_bdaa38d1","line":265,"updated":"2015-06-26 00:02:58.000000000","message":"This should now read:\n\n    # Ignore the default value of endpoint_type. Only if it is set later\n    # will it be used.\n    cc \u003d cloud_config.OpenStackConfig(override_defaults\u003d{\u0027endpoint_type\u0027: None,})\n\nWith this change the 404 failure will go away.","commit_id":"de853b39d38d777bd8b21352eac40d46cbb3a268"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"b6e8cbcc26f456aa269410a630f4ab5f5c6f1366","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        if tenant_name and not project_name:"},{"line_number":263,"context_line":"            self.options.project_name \u003d tenant_name"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Do configuration file handling"},{"line_number":266,"context_line":"        cc \u003d cloud_config.OpenStackConfig()"},{"line_number":267,"context_line":"        self.log.debug(\"defaults: %s\", cc.defaults)"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_0a697425","line":265,"in_reply_to":"fa32b979_bdaa38d1","updated":"2015-06-26 16:40:39.000000000","message":"Done. Thanks for the finding!!","commit_id":"de853b39d38d777bd8b21352eac40d46cbb3a268"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b470b35366188c02f48cafd4a6e3abb1cdb768a3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            dest\u003d\u0027endpoint_type\u0027,"},{"line_number":215,"context_line":"            choices\u003d[\u0027admin\u0027, \u0027public\u0027, \u0027internal\u0027],"},{"line_number":216,"context_line":"            default\u003dutils.env(\u0027OS_ENDPOINT_TYPE\u0027),"},{"line_number":217,"context_line":"            help\u003d\u0027Select an endpoint interface type.\u0027"},{"line_number":218,"context_line":"                 \u0027 Valid endpoint types: [admin, public, internal].\u0027"},{"line_number":219,"context_line":"                 \u0027 (Env: OS_ENDPOINT_TYPE)\u0027)"},{"line_number":220,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_de928057","line":217,"updated":"2015-06-29 16:15:37.000000000","message":"s/endpoint interface type/endpoint type/g","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            dest\u003d\u0027endpoint_type\u0027,"},{"line_number":215,"context_line":"            choices\u003d[\u0027admin\u0027, \u0027public\u0027, \u0027internal\u0027],"},{"line_number":216,"context_line":"            default\u003dutils.env(\u0027OS_ENDPOINT_TYPE\u0027),"},{"line_number":217,"context_line":"            help\u003d\u0027Select an endpoint interface type.\u0027"},{"line_number":218,"context_line":"                 \u0027 Valid endpoint types: [admin, public, internal].\u0027"},{"line_number":219,"context_line":"                 \u0027 (Env: OS_ENDPOINT_TYPE)\u0027)"},{"line_number":220,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_d6e7c03e","line":217,"in_reply_to":"ba3cc151_de928057","updated":"2015-06-29 19:05:33.000000000","message":"Done","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"}],"openstackclient/tests/fakes.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"f28ec8d258b76558652ba489d3dafff6eb0a8785","unresolved":false,"context_lines":[{"line_number":27,"context_line":"PASSWORD \u003d \"scratchy\""},{"line_number":28,"context_line":"PROJECT_NAME \u003d \"poochie\""},{"line_number":29,"context_line":"REGION_NAME \u003d \"richie\""},{"line_number":30,"context_line":"ENDPOINT_TYPE \u003d \"catchy\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"TEST_RESPONSE_DICT \u003d fixture.V2Token(token_id\u003dAUTH_TOKEN,"},{"line_number":33,"context_line":"                                     user_name\u003dUSERNAME)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6000d2ab","line":30,"updated":"2015-05-29 11:25:38.000000000","message":"Ha, out of itchy and scratchy characters already!","commit_id":"5bf8f8311007705a57506d128bd5bd8ce44ede31"}],"openstackclient/tests/test_shell.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3f332515c210fe5f046be70248ea5cac390317aa","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def _assert_cloud_config_arg(self, cmd_options, default_args):"},{"line_number":194,"context_line":"        \"\"\"Check the args passed to cloud_config.get_one_cloud()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        The argparse argument to get_one_cloud() is an argparse.Namespace"},{"line_number":197,"context_line":"        object that contains all of the options processed to this point in"},{"line_number":198,"context_line":"        initialize_app()."},{"line_number":199,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_4d1f136c","side":"PARENT","line":196,"updated":"2015-07-02 08:46:51.000000000","message":"revert this change back, the alignment of the doc changed","commit_id":"7e067c6f4f2dddfd9ea4b4a3df90959a7d8f2f0f"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"aece3754720f9d396222f9a38bb49d9bc1eb1ef7","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def _assert_cloud_config_arg(self, cmd_options, default_args):"},{"line_number":194,"context_line":"        \"\"\"Check the args passed to cloud_config.get_one_cloud()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        The argparse argument to get_one_cloud() is an argparse.Namespace"},{"line_number":197,"context_line":"        object that contains all of the options processed to this point in"},{"line_number":198,"context_line":"        initialize_app()."},{"line_number":199,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_7a7f0fe0","side":"PARENT","line":196,"in_reply_to":"ba3cc151_4d1f136c","updated":"2015-07-02 17:14:18.000000000","message":"Done","commit_id":"7e067c6f4f2dddfd9ea4b4a3df90959a7d8f2f0f"}],"openstackclient/volume/client.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"b470b35366188c02f48cafd4a6e3abb1cdb768a3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # Remember endpoint_type only if it is set"},{"line_number":57,"context_line":"    kwargs \u003d {}"},{"line_number":58,"context_line":"    if instance._endpoint_type:"},{"line_number":59,"context_line":"        kwargs[\u0027endpoint_type\u0027] \u003d instance._endpoint_type"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    client \u003d volume_client("},{"line_number":62,"context_line":"        session\u003dinstance.session,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_dec7e043","line":59,"updated":"2015-06-29 16:15:37.000000000","message":"I see this pattern being repeated a few times. May want to consolidate it into a utility method.","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"f6cceec138142d49c033122bfffc6cb6e80e0482","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # Remember endpoint_type only if it is set"},{"line_number":57,"context_line":"    kwargs \u003d {}"},{"line_number":58,"context_line":"    if instance._endpoint_type:"},{"line_number":59,"context_line":"        kwargs[\u0027endpoint_type\u0027] \u003d instance._endpoint_type"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    client \u003d volume_client("},{"line_number":62,"context_line":"        session\u003dinstance.session,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_36db8c7e","line":59,"in_reply_to":"ba3cc151_dec7e043","updated":"2015-06-29 19:05:33.000000000","message":"Done","commit_id":"ef32c08e1e59d9e8513273efa7f740080df48b02"}]}