)]}'
{"id":"openstack%2Fpython-openstackclient~186385","triplet_id":"openstack%2Fpython-openstackclient~master~I68214d2680bad907f9d04ad3ca2f62cf3feee028","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1459629","hashtags":[],"change_id":"I68214d2680bad907f9d04ad3ca2f62cf3feee028","subject":"Fix security group list command","status":"MERGED","created":"2015-05-28 13:29:44.000000000","updated":"2015-06-03 14:37:36.000000000","submitted":"2015-06-03 14:37:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"13141fcadc7101cb4867115f344f6413000c0944","_number":186385,"virtual_id_number":186385,"owner":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-06-03 14:37:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-06-03 13:45:39.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-06-03 07:35:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2015-06-03 09:49:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2015-06-03 12:58:23.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":1,"date":"2015-06-03 13:45:39.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-03 07:35:45.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2015-06-03 09:49:57.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-06-03 12:58:23.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-06-03 14:37:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"42cf3a1102843552a96b6712e235513e9cfa128a","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-28 13:29:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c01832db99e5e43cfadb19f9b15674045984531e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-28 14:22:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python26/1cac444/ : FAILURE in 1m 27s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-pep8/445e467/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/186385/1/check/gate-python-openstackclient-docs/2aba926//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python27/7b9d839/ : FAILURE in 1m 50s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python34/d68614f/ : FAILURE in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/186385/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/04beb49/ : SUCCESS in 53m 01s\n- check-osc-dsvm-functional http://logs.openstack.org/85/186385/1/check/check-osc-dsvm-functional/d2165d9/ : SUCCESS in 19m 31s","accounts_in_message":[],"_revision_number":1},{"id":"a8724382b16edb6526c8c79127bc754363e4cca2","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-05-28 20:25:28.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3b03c90ac0f9a78b8e27de4d7e2ac8ea7a6f3f26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-28 21:11:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python26/9473357/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-pep8/3e66f82/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/186385/1/check/gate-python-openstackclient-docs/aef0b18//doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python27/317bd26/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/186385/1/check/gate-python-openstackclient-python34/1d967f7/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/186385/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fc79276/ : SUCCESS in 45m 32s\n- check-osc-dsvm-functional http://logs.openstack.org/85/186385/1/check/check-osc-dsvm-functional/739f9dd/ : SUCCESS in 20m 08s","accounts_in_message":[],"_revision_number":1},{"id":"249547004bacb2ee9a467c3b7289f17b859a3876","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-05-29 12:46:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c49aa41a99c656bdf1ae4589619f10e0816a9c07","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-06-01 13:14:48.000000000","message":"Patch Set 1: Code-Review-1\n\nThere is a more general problem at hand here, the cloud provider may only make the public endpoint accessible to a user and not the admin endpoint. So trying to access the admin endpoint may result in a long timeout as well as errors like ConnectionRefused, DestinationUnreachble or others, IMO trying to access the admin endpoint should be avoided unless it is really necessary.\n\nThis also affects other commands, at least \"image list\" seems to show the same behaviour.","accounts_in_message":[],"_revision_number":1},{"id":"e6a0d9314f59ec2dcd261470d1f74b80184e73b1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-06-02 13:29:30.000000000","message":"Patch Set 1:\n\nJens, while I agree that the admin endpoint availability is a general problem with a number of commands, I would like to go ahead and push this review in as it fixes a specific issue that does affect a number of users.\n\nIt could even be argued that the admin endpoint should not appear in the service catalog if it is not available to a user, as that is the kind of reason the SC comes _after_ authentication.  I\u0027d be happy for that to be our test as it is simple and global.  However, I don\u0027t think that is the case in practice and we\u0027ll need another general solution.  Would you please to file a bug on this if one does not already exist?","accounts_in_message":[],"_revision_number":1},{"id":"375794f5d1459b110cbabfc61f30787cf08ffc64","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-06-02 14:13:43.000000000","message":"Patch Set 1:\n\n@Dean: Your argument about the service catalog seems valid, is there a way to tell keystone to send a different catalog or would that be a new feature?\n\nOn another note, I tested the patch in the environment from the bug report and the command still fails when the admin endpoint gives a ConnectionRefused instead of a 404. So either the patch should be extended to handle that case, too, or the commit message should only say Partial-Bug instead of Closes-Bug.","accounts_in_message":[],"_revision_number":1},{"id":"e75a074f36c53065483fdd8e0f76a44db7802a64","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-02 15:00:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ab436218013b9be24b38a2ef5de95ea00083dc51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-02 16:01:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/186385/2/check/gate-python-openstackclient-python26/c20ce39/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/186385/2/check/gate-python-openstackclient-pep8/7792dca/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/186385/2/check/gate-python-openstackclient-docs/521dbd7//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/186385/2/check/gate-python-openstackclient-python27/f4d2855/ : SUCCESS in 1m 46s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/186385/2/check/gate-python-openstackclient-python34/4f55225/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/186385/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e1135a4/ : SUCCESS in 55m 12s\n- check-osc-dsvm-functional http://logs.openstack.org/85/186385/2/check/check-osc-dsvm-functional/24dd387/ : SUCCESS in 20m 04s","accounts_in_message":[],"_revision_number":2},{"id":"f01c1acd0b63af57b82704c977a37c33639ed720","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2015-06-03 07:35:45.000000000","message":"Patch Set 2: Code-Review+1\n\nThis works better in my test, thanks.","accounts_in_message":[],"_revision_number":2},{"id":"80e0867fb5ceef94b314cf9333da73f93c01966c","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-06-03 09:49:57.000000000","message":"Patch Set 2: Code-Review+1\n\n@Jens: filtering of the service catalog can be achieved using Endpoint Group filtering: http://specs.openstack.org/openstack/keystone-specs/api/v3/identity-api-v3-os-ep-filter-ext.html\n\nChange LGTM","accounts_in_message":[],"_revision_number":2},{"id":"efdb721ff4478699df3b299d4577e50889308be7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-06-03 12:58:23.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Terry","accounts_in_message":[],"_revision_number":2},{"id":"607b31f62f7ec220a959e7ea857805a7612542a1","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-03 13:45:39.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"192c92fb3fbd18b34d3b505c87b1de3a16e9bf83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-03 13:45:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"531dcadde4441bf83c0c4fb029e7cd75e8ce7b00","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-03 14:37:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/186385/2/gate/gate-python-openstackclient-python26/9669431/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/186385/2/gate/gate-python-openstackclient-docs/adba2a7//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/186385/2/gate/gate-python-openstackclient-pep8/70b51bc/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/186385/2/gate/gate-python-openstackclient-python27/03756a8/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/186385/2/gate/gate-python-openstackclient-python34/db37e26/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/186385/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a86bcc9/ : SUCCESS in 47m 46s\n- gate-osc-dsvm-functional http://logs.openstack.org/85/186385/2/gate/gate-osc-dsvm-functional/763ee08/ : SUCCESS in 16m 15s","accounts_in_message":[],"_revision_number":2},{"id":"e7270e41dfc3a7be4b1e2c0984ce30084cd7b058","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-03 14:37:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b2cf651100b2a6dc1b934b86390eff94ef9f8fdc","revisions":{"676521bfa342ebffb06509d4dadd5afe4e510721":{"kind":"REWORK","_number":1,"created":"2015-05-28 13:29:44.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/85/186385/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/186385/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/1"}}},"commit":{"parents":[{"commit":"cae03c6834baedd45d3962025a6168a70322df64","subject":"Remove oslo incubator config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cae03c6834baedd45d3962025a6168a70322df64"}]}],"author":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-28 13:27:24.000000000","tz":-360},"committer":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-28 13:27:24.000000000","tz":-360},"subject":"Fix security group list command","message":"Fix security group list command\n\nSecurity group list command tries to get a project list and\nthis may fail with a 404 as well as a 401, so add the 404 to\nthe ignore list.\n\nChange-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028\nCloses-Bug: #1459629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/676521bfa342ebffb06509d4dadd5afe4e510721"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/676521bfa342ebffb06509d4dadd5afe4e510721"}]},"branch":"refs/heads/master"},"b2cf651100b2a6dc1b934b86390eff94ef9f8fdc":{"kind":"REWORK","_number":2,"created":"2015-06-02 15:00:52.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/85/186385/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/186385/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/186385/2"}}},"commit":{"parents":[{"commit":"cae03c6834baedd45d3962025a6168a70322df64","subject":"Remove oslo incubator config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cae03c6834baedd45d3962025a6168a70322df64"}]}],"author":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-05-28 13:27:24.000000000","tz":-360},"committer":{"name":"TerryHowe","email":"terrylhowe@gmail.com","date":"2015-06-02 14:55:54.000000000","tz":-360},"subject":"Fix security group list command","message":"Fix security group list command\n\nSecurity group list command tries to get a project list and\nthis may fail with a multitude of exceptions including but\nnot limited to 401, 404, ConnectionRefused and EndpointNotFound.\nRather than try to capture every possibility, this patch just\ncatches the base class.  Converting project ids to names is\nless important than having a working security group list command.\n\nChange-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028\nCloses-Bug: #1459629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b2cf651100b2a6dc1b934b86390eff94ef9f8fdc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b2cf651100b2a6dc1b934b86390eff94ef9f8fdc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}