)]}'
{"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5a3c50ecd1e1523b8e32a0a336a95bdae996c3a0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateVolume\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(CreateVolume, self).get_parser(prog_name)"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \"--size\","},{"line_number":36,"context_line":"            metavar\u003d\"\u003csize\u003e\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_765119d8","line":33,"updated":"2015-06-03 03:14:41.000000000","message":"should probably add new arguments 1) consistencygroup and 2) source_replica","commit_id":"96b0b0fe9e2bf3a5f64b6d03cce7dd7ead9798c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5a3c50ecd1e1523b8e32a0a336a95bdae996c3a0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            required\u003dTrue,"},{"line_number":39,"context_line":"            help\u003d\"New volume size in GB\""},{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \"name\","},{"line_number":43,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":44,"context_line":"            help\u003d\"New volume name\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_96ba5522","line":41,"updated":"2015-06-03 03:14:41.000000000","message":"put name before size as it\u0027s a positional argument","commit_id":"96b0b0fe9e2bf3a5f64b6d03cce7dd7ead9798c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5a3c50ecd1e1523b8e32a0a336a95bdae996c3a0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                identity_client.users,"},{"line_number":130,"context_line":"                parsed_args.user).id"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        volume \u003d volume_client.volumes.create("},{"line_number":133,"context_line":"            size\u003dparsed_args.size,"},{"line_number":134,"context_line":"            snapshot_id\u003dsnapshot,"},{"line_number":135,"context_line":"            name\u003dparsed_args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_966db59a","line":132,"updated":"2015-06-03 03:14:41.000000000","message":"i think calling volumes.create() with named args like this, and skipping consistencygroup_id (and source_replica) will fail. \n\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py#L175-L198","commit_id":"96b0b0fe9e2bf3a5f64b6d03cce7dd7ead9798c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9ececbc9430678c9ed4e0aaa36d72ccdb2956379","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        project \u003d None"},{"line_number":121,"context_line":"        if parsed_args.project:"},{"line_number":122,"context_line":"            project \u003d utils.find_resource("},{"line_number":123,"context_line":"                identity_client.tenants,"},{"line_number":124,"context_line":"                parsed_args.project).id"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        user \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_11b0ecf3","line":123,"updated":"2015-07-20 04:31:03.000000000","message":"identity_client.projects, not tenants","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"change_message_id":"0d24e5e57907c0e872e485e6f34fc5f0b38a60aa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        project \u003d None"},{"line_number":121,"context_line":"        if parsed_args.project:"},{"line_number":122,"context_line":"            project \u003d utils.find_resource("},{"line_number":123,"context_line":"                identity_client.tenants,"},{"line_number":124,"context_line":"                parsed_args.project).id"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        user \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4376b507","line":123,"in_reply_to":"3a50d1a3_11b0ecf3","updated":"2015-07-23 23:14:36.000000000","message":"Done","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9ececbc9430678c9ed4e0aaa36d72ccdb2956379","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            imageRef\u003dimage,"},{"line_number":143,"context_line":"            source_volid\u003dsource_volume"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        # Remove key links from being displayed"},{"line_number":146,"context_line":"        volume._info.pop(\"links\", None)"},{"line_number":147,"context_line":"        return zip(*sorted(six.iteritems(volume._info)))"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_31888822","line":145,"updated":"2015-07-20 04:31:03.000000000","message":"need to format the metadata into properties after creation, see the following:\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v1/volume.py#L155-L161","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"change_message_id":"0d24e5e57907c0e872e485e6f34fc5f0b38a60aa","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            imageRef\u003dimage,"},{"line_number":143,"context_line":"            source_volid\u003dsource_volume"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        # Remove key links from being displayed"},{"line_number":146,"context_line":"        volume._info.pop(\"links\", None)"},{"line_number":147,"context_line":"        return zip(*sorted(six.iteritems(volume._info)))"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_6373b116","line":145,"in_reply_to":"3a50d1a3_31888822","updated":"2015-07-23 23:14:36.000000000","message":"Done","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9ececbc9430678c9ed4e0aaa36d72ccdb2956379","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \u0027--property\u0027,"},{"line_number":295,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":296,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":297,"context_line":"            default\u003d[],"},{"line_number":298,"context_line":"            help\u003d\u0027Property to remove from volume \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_b17c9821","line":295,"updated":"2015-07-20 04:31:03.000000000","message":"add required\u003dTrue here","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"change_message_id":"0d24e5e57907c0e872e485e6f34fc5f0b38a60aa","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \u0027--property\u0027,"},{"line_number":295,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":296,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":297,"context_line":"            default\u003d[],"},{"line_number":298,"context_line":"            help\u003d\u0027Property to remove from volume \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_035f4d76","line":295,"in_reply_to":"3a50d1a3_b17c9821","updated":"2015-07-23 23:14:36.000000000","message":"Done","commit_id":"fdec0416abda79cf3796bc7009ef01478ce4b329"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbb7bd93056789419d37be8ea5b4d6a2910e0ae1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from openstackclient.common import utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class CreateVolume(show.ShowOne):"},{"line_number":28,"context_line":"    \"\"\"Create new volume\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateVolume\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9c917a55","line":27,"updated":"2015-07-24 01:03:53.000000000","message":"to be consistent with v1, can you change the order of the arguments?\n\nname should be first, since it\u0027s positional.\n\nfollowed by --size, then --snapshot, then --description? \n\nthen rest is fine, see this for reference: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v1/volume.py#L35-L101","commit_id":"f513ae0a53d7e376cc83b65bf700ebdbc967520a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbb7bd93056789419d37be8ea5b4d6a2910e0ae1","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        volume \u003d utils.find_resource("},{"line_number":314,"context_line":"            volume_client.volumes, parsed_args.volume)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        if parsed_args.property:"},{"line_number":317,"context_line":"            volume_client.volumes.delete_metadata("},{"line_number":318,"context_line":"                volume.id,"},{"line_number":319,"context_line":"                parsed_args.property,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_fc867e15","line":316,"updated":"2015-07-24 01:03:53.000000000","message":"you can remove the conditional and the else, since --property is required","commit_id":"f513ae0a53d7e376cc83b65bf700ebdbc967520a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"6b8ec0099d42267d8bd0436e94f5b07afeba1827","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":89,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":90,"context_line":"            help\u003d\"Set a property to this volume \""},{"line_number":91,"context_line":"                 \"(repeat option to set multiple properties\""},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_32f93fc9","line":91,"updated":"2015-07-24 20:14:14.000000000","message":"Missing closing ) here^","commit_id":"9c64a1dbc5182caf695f8489fcca205f7a864040"}]}