)]}'
{"functional/tests/volume/v1/test_volume.py":[{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"395c70ccecb8343e510004c1c9253d60d3746684","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def tearDownClass(cls):"},{"line_number":35,"context_line":"        # Rename test"},{"line_number":36,"context_line":"        raw_output \u003d cls.openstack("},{"line_number":37,"context_line":"            \u0027volume set --name \u0027 + cls.OTHER_NAME + \u0027 \u0027 + cls.NAME)"},{"line_number":38,"context_line":"        cls.assertOutput(\u0027\u0027, raw_output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_1322d3b9","line":35,"updated":"2015-06-03 18:12:05.000000000","message":"Why is the rename test in the teardown (i.e. runs with every test). Should this not be it\u0027s own test.","commit_id":"8d185a6a6f72ecdffc0fb90bd7e6625ad6c071a0"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"fa9230a942d85980783025037b18038471a86ee2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def tearDownClass(cls):"},{"line_number":35,"context_line":"        # Rename test"},{"line_number":36,"context_line":"        raw_output \u003d cls.openstack("},{"line_number":37,"context_line":"            \u0027volume set --name \u0027 + cls.OTHER_NAME + \u0027 \u0027 + cls.NAME)"},{"line_number":38,"context_line":"        cls.assertOutput(\u0027\u0027, raw_output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_2e9322a5","line":35,"in_reply_to":"5afe65bd_1322d3b9","updated":"2015-06-03 18:17:39.000000000","message":"The other tests are run in a random order, so a rename outside this teardown would cause random failures unless I created another volume just for this test.  I\u0027ve been trying to minimize the number of transactions so the tests run as fast as possible.  creating another volume just to test rename would add at least 2 more commands (create and delete)","commit_id":"8d185a6a6f72ecdffc0fb90bd7e6625ad6c071a0"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"c9ad444c2296ddf7f7e9d0836efcb1d4fadc5cfa","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def tearDownClass(cls):"},{"line_number":35,"context_line":"        # Rename test"},{"line_number":36,"context_line":"        raw_output \u003d cls.openstack("},{"line_number":37,"context_line":"            \u0027volume set --name \u0027 + cls.OTHER_NAME + \u0027 \u0027 + cls.NAME)"},{"line_number":38,"context_line":"        cls.assertOutput(\u0027\u0027, raw_output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_eeff4aa8","line":35,"in_reply_to":"5afe65bd_2e9322a5","updated":"2015-06-03 18:23:52.000000000","message":"Those are all valid points, especially the desire to optimize for speed.","commit_id":"8d185a6a6f72ecdffc0fb90bd7e6625ad6c071a0"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"395c70ccecb8343e510004c1c9253d60d3746684","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027volume set --description RAMAC \u0027 + self.NAME)"},{"line_number":69,"context_line":"        opts \u003d self.get_show_opts([\"display_description\", \"display_name\"])"},{"line_number":70,"context_line":"        raw_output \u003d self.openstack(\u0027volume show \u0027 + self.NAME + opts)"},{"line_number":71,"context_line":"        self.assertEqual(\"RAMAC\\n\" + self.NAME + \"\\n\", raw_output)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_ce27eeb4","line":71,"updated":"2015-06-03 18:12:05.000000000","message":"You may want to make RAMAC a local variable and reference it in both places, .e.g like NAME (but not need to be a class constant.\n\nSome could be said for c\u003d\u0027d\u0027.   There is a point of diminishing return however, so this is more a subjective observation.","commit_id":"8d185a6a6f72ecdffc0fb90bd7e6625ad6c071a0"}]}