)]}'
{"id":"openstack%2Fpython-openstackclient~188285","triplet_id":"openstack%2Fpython-openstackclient~master~Ib521ef628da2ccb8d50a4e7a8bb1c5f81cb2b3f6","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1461817","hashtags":[],"change_id":"Ib521ef628da2ccb8d50a4e7a8bb1c5f81cb2b3f6","subject":"Do not update existing image on create by default","status":"ABANDONED","created":"2015-06-04 07:38:05.000000000","updated":"2015-06-23 13:15:07.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0072c4231b31add82d3b41dbe5ac5d9cee808dc2","_number":188285,"virtual_id_number":188285,"owner":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2015-06-05 13:21:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"date":"2015-06-08 18:04:39.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-06-18 19:21:49.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},{"date":"2015-06-05 13:22:57.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-04 14:15:26.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-06-04 19:58:36.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-06-05 13:21:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-06-05 13:22:57.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-06-08 18:04:39.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"8f0b768100217289d98b7ad39137ba8c85751be3","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-04 07:38:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e170fa49c03065786032865507faf12418d9e460","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-04 08:23:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/188285/1/check/gate-python-openstackclient-python26/27df744/ : FAILURE in 1m 30s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/188285/1/check/gate-python-openstackclient-pep8/8a34a28/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/188285/1/check/gate-python-openstackclient-docs/e0c3ada//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/188285/1/check/gate-python-openstackclient-python27/d61bffe/ : FAILURE in 1m 35s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/188285/1/check/gate-python-openstackclient-python34/416af6e/ : FAILURE in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/188285/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8cb4d4d/ : SUCCESS in 44m 54s\n- check-osc-dsvm-functional http://logs.openstack.org/85/188285/1/check/check-osc-dsvm-functional/2e519da/ : SUCCESS in 16m 11s","accounts_in_message":[],"_revision_number":1},{"id":"3e1a34d25c35f56e3f0d88de0d9ec07327df672a","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-04 09:09:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a77008a51bfca04cf578de5df6d24c0458bd85e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-04 10:09:28.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/188285/2/check/gate-python-openstackclient-python26/0366b54/ : FAILURE in 1m 35s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/188285/2/check/gate-python-openstackclient-pep8/7d4a0b8/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/188285/2/check/gate-python-openstackclient-docs/2b817fa//doc/build/html/ : SUCCESS in 2m 36s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/188285/2/check/gate-python-openstackclient-python27/8a03940/ : FAILURE in 1m 46s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/188285/2/check/gate-python-openstackclient-python34/d0c3a4a/ : FAILURE in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/188285/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0498ea4/ : SUCCESS in 53m 18s\n- check-osc-dsvm-functional http://logs.openstack.org/85/188285/2/check/check-osc-dsvm-functional/5f2c574/ : SUCCESS in 25m 54s","accounts_in_message":[],"_revision_number":2},{"id":"eac0d2eef54cabea9ac3e1fe04962b4d3156f8b8","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-04 14:15:26.000000000","message":"Patch Set 2:\n\nI think create should just do a find for the name and raise an exception if it exists.","accounts_in_message":[],"_revision_number":2},{"id":"ed0a8178f01a55d280ef2275ef0d5e60a7939e0a","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-04 19:58:36.000000000","message":"Patch Set 2:\n\nTerry, glance allows duplicate names. Raising an exception if it exists already doesn\u0027t work. Also if this was to support the reserve image uuid and then update it later, the equivalent in glance-client is to use image-update after image-create, not image-create again.","accounts_in_message":[],"_revision_number":2},{"id":"8b88035fe34b69231cddfdc2a8c6ea52a34b1c85","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-05 12:26:06.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"942e3efe4c1b31ed9b0f3af8bae76a8e49270646","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-05 13:21:17.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/85/188285/3/check/gate-python-openstackclient-python26/e9a6899/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/188285/3/check/gate-python-openstackclient-pep8/329add3/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/188285/3/check/gate-python-openstackclient-docs/ce4eae5//doc/build/html/ : SUCCESS in 2m 38s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/188285/3/check/gate-python-openstackclient-python27/86df059/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/188285/3/check/gate-python-openstackclient-python34/7ecf51e/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/188285/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1a8ff9b/ : SUCCESS in 51m 11s\n- check-osc-dsvm-functional http://logs.openstack.org/85/188285/3/check/check-osc-dsvm-functional/f87478b/ : SUCCESS in 21m 17s","accounts_in_message":[],"_revision_number":3},{"id":"8a7859488b9ea050661a23437b562f2399858a44","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-08 18:04:39.000000000","message":"Patch Set 3:\n\n@marek, i think i steered you down the wrong path. dtroyer and I spoke about this, and i think ian agrees too. Lets remove any \"update\" capabilities from the create command.\n\nWe should remove the look up by name and proceed with creation.","accounts_in_message":[],"_revision_number":3},{"id":"11d466a3a94b4b16a734b93102247b825aefa6da","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-18 19:21:49.000000000","message":"Patch Set 3: Workflow-1\n\nThanks Steve, so update code will be removed from create action.\n\nBut then we should add image update command. Would adding image update command (and restrict image set only to properties) be acceptable?\n\nDetails at https://etherpad.openstack.org/p/osc-image-create-update\n\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"d795179455a2cfd7d3b5932314ac1a54d474497d","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-23 13:14:43.000000000","message":"Patch Set 3:\n\nGoind to abandon this patch. A new patch which split create and update action is at https://review.openstack.org/#/c/194654/","accounts_in_message":[],"_revision_number":3},{"id":"fcff1b1ff5298c346c754eb4ead096224c1b8dd9","author":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"date":"2015-06-23 13:15:07.000000000","message":"Abandoned\n\nUpdated at https://review.openstack.org/#/c/194654/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ab1662b50d04fa19bc81287908e022c1319b2b71","revisions":{"e9910ea2d4baa1a1c02e860abe918c718c2f3e67":{"kind":"REWORK","_number":1,"created":"2015-06-04 07:38:05.000000000","uploader":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"ref":"refs/changes/85/188285/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/188285/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/1"}}},"commit":{"parents":[{"commit":"bf99218292addf025f56ad726967635928389a04","subject":"Add a reference to the IRC channels","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bf99218292addf025f56ad726967635928389a04"}]}],"author":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-04 07:31:55.000000000","tz":120},"committer":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-04 07:31:55.000000000","tz":120},"subject":"Do not update existing image on create by default","message":"Do not update existing image on create by default\n\nOpenstack image create command updates existing image (with same name) by\ndefault. Glance client allow create multiple images with same name, what\ncan lead to unwanted update of existing image when creating a new one.\n\nParameter --or-update was added to openstack image create to allow\nupdate existing image, otherwise image create does not update existing\nimage with same name.\n\nChange-Id: Ib521ef628da2ccb8d50a4e7a8bb1c5f81cb2b3f6\nCloses-Bug: #1461817\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e9910ea2d4baa1a1c02e860abe918c718c2f3e67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e9910ea2d4baa1a1c02e860abe918c718c2f3e67"}]},"branch":"refs/heads/master"},"8b921c27ef613b39ce43b586e16be9a5f2c1b527":{"kind":"REWORK","_number":2,"created":"2015-06-04 09:09:17.000000000","uploader":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"ref":"refs/changes/85/188285/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/188285/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/2"}}},"commit":{"parents":[{"commit":"bf99218292addf025f56ad726967635928389a04","subject":"Add a reference to the IRC channels","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bf99218292addf025f56ad726967635928389a04"}]}],"author":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-04 07:31:55.000000000","tz":120},"committer":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-04 09:09:01.000000000","tz":120},"subject":"Do not update existing image on create by default","message":"Do not update existing image on create by default\n\nOpenstack image create command updates existing image (with same name) by\ndefault. Glance client allow create multiple images with same name, what\ncan lead to unwanted update of existing image when creating a new one.\n\nParameter --or-update was added to openstack image create to allow\nupdate existing image, otherwise image create does not update existing\nimage with same name.\n\nChange-Id: Ib521ef628da2ccb8d50a4e7a8bb1c5f81cb2b3f6\nCloses-Bug: #1461817\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8b921c27ef613b39ce43b586e16be9a5f2c1b527"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8b921c27ef613b39ce43b586e16be9a5f2c1b527"}]},"branch":"refs/heads/master"},"ab1662b50d04fa19bc81287908e022c1319b2b71":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-06-05 12:26:06.000000000","uploader":{"_account_id":15192,"name":"Marek Aufart","email":"maufart@redhat.com","username":"maufart"},"ref":"refs/changes/85/188285/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/188285/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/188285/3"}}},"commit":{"parents":[{"commit":"56163aa7bc7ab1ea98b94611158dbe2df727069a","subject":"Merge \"Create 1.4.0 release notes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/56163aa7bc7ab1ea98b94611158dbe2df727069a"}]}],"author":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-04 07:31:55.000000000","tz":120},"committer":{"name":"Marek Aufart","email":"maufart@redhat.com","date":"2015-06-05 12:26:05.000000000","tz":0},"subject":"Do not update existing image on create by default","message":"Do not update existing image on create by default\n\nOpenstack image create command updates existing image (with same name) by\ndefault. Glance client allow create multiple images with same name, what\ncan lead to unwanted update of existing image when creating a new one.\n\nParameter --or-update was added to openstack image create to allow\nupdate existing image, otherwise image create does not update existing\nimage with same name.\n\nChange-Id: Ib521ef628da2ccb8d50a4e7a8bb1c5f81cb2b3f6\nCloses-Bug: #1461817\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab1662b50d04fa19bc81287908e022c1319b2b71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab1662b50d04fa19bc81287908e022c1319b2b71"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}