)]}'
{"id":"openstack%2Fpython-openstackclient~194922","triplet_id":"openstack%2Fpython-openstackclient~master~I72ea1b9a4d0bd0e35eda03071ea438b75439fce9","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1467967","hashtags":[],"change_id":"I72ea1b9a4d0bd0e35eda03071ea438b75439fce9","subject":"Add support for volume API v1 QoS commands","status":"MERGED","created":"2015-06-24 03:21:44.000000000","updated":"2015-06-27 15:55:51.000000000","submitted":"2015-06-27 15:55:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":74,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1ba88234d49cf705f8e69123bfe4292899e8a6dc","_number":194922,"virtual_id_number":194922,"owner":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-06-27 15:55:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-06-27 12:12:20.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-06-27 15:00:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2015-06-27 15:00:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-27 12:12:20.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-06-27 15:00:51.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-06-27 15:55:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9c09a2073abf39dcb60d94e5ab7de5d7825b59ca","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-24 03:21:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7354fec8c190572f1ef4acaef137c52d4e836a6c","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-24 03:23:54.000000000","message":"Patch Set 1: Workflow-1\n\nHi guys,\n\nSubmitting a first draft for the introduction of qos commands for the Cinder v1 API as per bug https://launchpad.net/bugs/1467967\n\nThere are no tests yet, I figured I\u0027d get feedback on the implementation first and then work on the tests if everything looks good.\n\nI\u0027ve tested this implementation in my environment and every command works well.\n\nAppreciate your feedback.","accounts_in_message":[],"_revision_number":1},{"id":"02fec988fd5bb972d22cb9f88180c97be35971e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-24 04:10:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/1/check/gate-python-openstackclient-python26/58512f7/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/1/check/gate-python-openstackclient-pep8/cac5268/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/1/check/gate-python-openstackclient-docs/4f124d4//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/1/check/gate-python-openstackclient-python27/b48bdec/ : SUCCESS in 2m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/1/check/gate-python-openstackclient-python34/90c03d2/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/cd75b44/ : SUCCESS in 48m 46s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/1/check/check-osc-dsvm-functional/0dec007/ : SUCCESS in 15m 10s","accounts_in_message":[],"_revision_number":1},{"id":"4c65fd8e4582e1d4fb6409db793429ec366919a0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-24 05:47:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(22 comments)\n\ni added suggestions for wording, we are trying hard to keep things consistent, so please take them as more than suggestions :)\n\n\nalso, the \u0027associate\u0027 commands seem like they could be tacked on to create or set or list. is there a reason we don\u0027t want to do this?","accounts_in_message":[],"_revision_number":1},{"id":"2e32ea53b12cf120ee96fc5ff5883294237f0c9d","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-24 13:03:00.000000000","message":"Patch Set 1:\n\n(5 comments)\n\nSome comments for more discussion.","accounts_in_message":[],"_revision_number":1},{"id":"f6af53ee11505a503a4c15da6c5c34f8be416708","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-24 14:33:56.000000000","message":"Patch Set 1:\n\n(15 comments)\n\nHey guys, thanks for the feedback.\nThis is my first contribution to Openstackclient so obviously learning how things work still.\nI\u0027m actually an operator but haven\u0027t yet got to use openstackclient too much.\n\nSo, to give a bit of context here, I was mostly mapping Cinder commands one-to-one with new commands in Openstackclient (aside from cinder qos-key which was remapped to set and unset).\n\nI didn\u0027t know we had a little bit of freedom in remapping commands or changing the input/output of commands but it looks like this is the case. With this in mind, I have my own personal ideas on how to improve several things and I\u0027ll submit a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"64a22a98bbf98c911d105694eb20d71e140ef9c7","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 01:56:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"78ad35b00a97a641ca4dc939d87925ec4e63d6d3","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 01:58:26.000000000","message":"Patch Set 1:\n\n(10 comments)","accounts_in_message":[],"_revision_number":1},{"id":"780a0928a8f48b7aa2edd3627d0337f084449c16","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 02:04:12.000000000","message":"Patch Set 2:\n\nSo this patchset is more opinionated on how things probably should be - also starting to better learn how things work. Thanks a lot for the feedback so far.\nNotably:\n- Removed getassociations (melded into \u0027show\u0027 and \u0027list\u0027)\n- Removed disassociateall (can\u0027t find a good way to implement this without feeling clunky, can be left for another different commit)\n\nAlso note that I ran into a bug where a find by name for a qos_spec does not currently work due to https://review.openstack.org/#/c/178588/. This might be worthwhile to note so that we can bump the cinderclient requirement on next release. I tested with the qos_specs from cinder client patched locally. Search by ID works fine.","accounts_in_message":[],"_revision_number":2},{"id":"f288f7b0ae306102b6fcc844f904f36db388f637","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 02:40:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/2/check/gate-python-openstackclient-python26/6391797/ : SUCCESS in 1m 33s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/2/check/gate-python-openstackclient-pep8/cd905d4/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/2/check/gate-python-openstackclient-docs/8727d14//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/2/check/gate-python-openstackclient-python27/5db04c5/ : SUCCESS in 1m 45s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/2/check/gate-python-openstackclient-python34/b7a70c1/ : SUCCESS in 2m 10s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2ea09f9/ : SUCCESS in 40m 00s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/2/check/check-osc-dsvm-functional/8129df4/ : SUCCESS in 20m 35s","accounts_in_message":[],"_revision_number":2},{"id":"47778a203bd23e44f48361b72e9ec81be403207a","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-26 11:43:21.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"323069c8b6d2b7067c263fcb3dfaa78a34064020","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 15:53:30.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"8e199dc25adfda2d24bfab6638ddb15262eecbfe","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-26 16:08:04.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"388208661d6f2e31c05052ac159b02053d5eff5a","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 16:59:01.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3c2b231ff77d509d31a265fbae26d1e513ffdca1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-26 17:45:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)\n\njust gotta clean up the disassociate all bits and add some tests, looks great otherwise","accounts_in_message":[],"_revision_number":2},{"id":"f8e65a996553906e69f598e635b4e661124dbde8","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-26 17:49:10.000000000","message":"Patch Set 2:\n\nre: the cinderclient issue, i\u0027m OK with merging this as is, and having it only work for IDs. if we can get a release of cinderclient before we release that would be great, but i don\u0027t want to hold us up. \n\nwhen the fix for cinderclient is eventually merged and released, we\u0027ll pick it up automagically.","accounts_in_message":[],"_revision_number":2},{"id":"0b6dd3a8069ea8244ebd8e37df0d95e228804a54","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 19:26:41.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"79e8ea5f79a9ad8af55789e7f74cbe990e820404","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-26 19:34:46.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2908f34ff761259af8d6f8a1d567e777f532654b","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 22:14:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b62411bef4cb034adf548e8a57c62c60797138c9","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 22:14:38.000000000","message":"Patch Set 3:\n\nThis implements the feedback from previous patchset. Will now work on tests.","accounts_in_message":[],"_revision_number":3},{"id":"c0b007e23bd85b79b1b35d003e1ca8dab9f2c672","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-26 22:18:58.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8cf86e01a5232a7e212bdbf8dac9e526ee46bed9","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 22:51:13.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f6cb2bb6509850ab86b38565f6894bb1ca4624f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 23:12:54.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python26/50c013d/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-pep8/3ed1de0/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/4/check/gate-python-openstackclient-docs/86a0fde//doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python27/5acb8cf/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python34/2915e7d/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/749d9da/ : FAILURE in 16m 33s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/4/check/check-osc-dsvm-functional/c75a8ef/ : SUCCESS in 21m 31s","accounts_in_message":[],"_revision_number":4},{"id":"3a21df569f2ab907cfb96c454c00ea531bb2bf38","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-26 23:35:37.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"a57692fb020af72baa55d91d1665ea29a50dccc8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 00:16:49.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python26/f9f4a86/ : SUCCESS in 1m 33s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-pep8/f8491d3/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/4/check/gate-python-openstackclient-docs/c5a8296//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python27/72568ac/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/4/check/gate-python-openstackclient-python34/3963b20/ : SUCCESS in 1m 44s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7acdf1c/ : SUCCESS in 41m 06s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/4/check/check-osc-dsvm-functional/9c13c77/ : SUCCESS in 25m 45s","accounts_in_message":[],"_revision_number":4},{"id":"f5150b369f9431a40d4914cba9fa9c9e4b5a3796","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-27 01:35:20.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nlooking good! just gotta do tests","accounts_in_message":[],"_revision_number":4},{"id":"ae39d643def0fda1eebdf947b197ee11f093078e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-27 01:35:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"79d2c8d5f0e45305b00cca8313e3c235fcc3445e","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-27 01:42:26.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"87617baa2c382fcbd741f8ac35576e0c6f7e7e03","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-27 01:44:54.000000000","message":"Patch Set 5:\n\nHere\u0027s the tests. I haven\u0027t been able to write tests for show and list.. getting \"TypeError: \u0027Mock\u0027 object is not iterable\" errors, it looks like it\u0027s due to how associations are fetched ? This exceeds my current abilities but would love to add tests for these if you can point me in the right direction.","accounts_in_message":[],"_revision_number":5},{"id":"99f69694ccf971031862a23191c2de00dbe30702","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-27 02:11:19.000000000","message":"Patch Set 5: Code-Review+2\n\nlooks good, just a reminder about the comment i made in ps4","accounts_in_message":[],"_revision_number":5},{"id":"f30167e2f0fda7e64fec0f921ed676e95d3c439b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 02:34:59.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/5/check/gate-python-openstackclient-python26/a875395/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/5/check/gate-python-openstackclient-pep8/8abcbd6/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/5/check/gate-python-openstackclient-docs/f85c405//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/5/check/gate-python-openstackclient-python27/af7168f/ : FAILURE in 1m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/5/check/gate-python-openstackclient-python34/7b84efb/ : FAILURE in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/5/check/gate-tempest-dsvm-neutron-src-python-openstackclient/aaf7e90/ : SUCCESS in 52m 24s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/5/check/check-osc-dsvm-functional/5641414/ : SUCCESS in 15m 57s","accounts_in_message":[],"_revision_number":5},{"id":"f3da2ae563c38718448bccfdd4ddc91daad7f24f","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-27 03:07:21.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"dcbc6d6ea21131bb0d1ae7e4a32eaf5a85407879","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-27 03:19:16.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"1b524f6ba19b90c7ad81b73d9f0eb22339d69baf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 04:12:18.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/7/check/gate-python-openstackclient-python26/f249340/ : SUCCESS in 1m 33s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/7/check/gate-python-openstackclient-pep8/b9cd02b/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/7/check/gate-python-openstackclient-docs/91556b4//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/7/check/gate-python-openstackclient-python27/6a420d0/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/7/check/gate-python-openstackclient-python34/8c51311/ : SUCCESS in 1m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/7/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1d02975/ : SUCCESS in 52m 51s\n- check-osc-dsvm-functional http://logs.openstack.org/22/194922/7/check/check-osc-dsvm-functional/e01451b/ : SUCCESS in 19m 46s","accounts_in_message":[],"_revision_number":7},{"id":"5aeab1bc9c100fd26ff9d782e18b6231d34ec622","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-06-27 12:12:20.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"c7540215c70169b3ddd755663f656ae27087348e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-27 15:00:51.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nthanks!!!!","accounts_in_message":[],"_revision_number":7},{"id":"b1131baa5e63911d6e30359d206d5ec49130c081","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 15:00:57.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"70eaa64335bbbcd233fc019105fe4b8682c0cb58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 15:55:48.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/194922/7/gate/gate-python-openstackclient-python26/31f1d95/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/194922/7/gate/gate-python-openstackclient-docs/4071956//doc/build/html/ : SUCCESS in 2m 25s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/194922/7/gate/gate-python-openstackclient-pep8/ebb4b25/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/194922/7/gate/gate-python-openstackclient-python27/9581169/ : SUCCESS in 2m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/194922/7/gate/gate-python-openstackclient-python34/03d207f/ : SUCCESS in 1m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/194922/7/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/d21706d/ : SUCCESS in 54m 50s\n- gate-osc-dsvm-functional http://logs.openstack.org/22/194922/7/gate/gate-osc-dsvm-functional/08c8abe/ : SUCCESS in 15m 25s","accounts_in_message":[],"_revision_number":7},{"id":"024d09e4f8c3df1f15cd326c139a057ecfa5fca0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-27 15:55:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"7bb038c4a77c396d1831a4e48dfe1f3a3202c279","revisions":{"7087089fcd5d0293956b9631c5ee2a5b05abcc7c":{"kind":"REWORK","_number":1,"created":"2015-06-24 03:21:44.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/1"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:20:36.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos disassociateall\n  volume qos getassociations\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7087089fcd5d0293956b9631c5ee2a5b05abcc7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7087089fcd5d0293956b9631c5ee2a5b05abcc7c"}]},"branch":"refs/heads/master"},"7b03b4365a2b7265be204b038ca6d3493f2c1d97":{"kind":"REWORK","_number":2,"created":"2015-06-26 01:56:35.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/2"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-26 01:55:54.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7b03b4365a2b7265be204b038ca6d3493f2c1d97"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7b03b4365a2b7265be204b038ca6d3493f2c1d97"}]},"branch":"refs/heads/master"},"69b995c6ec2751f19f0cfd6b00173513dfae080b":{"kind":"REWORK","_number":3,"created":"2015-06-26 22:14:02.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/3"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-26 22:13:49.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/69b995c6ec2751f19f0cfd6b00173513dfae080b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/69b995c6ec2751f19f0cfd6b00173513dfae080b"}]},"branch":"refs/heads/master"},"86ef18e438a34166f48de260558c9a177a939150":{"kind":"REWORK","_number":4,"created":"2015-06-26 22:51:13.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/4"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-26 22:50:56.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86ef18e438a34166f48de260558c9a177a939150"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86ef18e438a34166f48de260558c9a177a939150"}]},"branch":"refs/heads/master"},"923fc37acb4e979d771e0ac93468c33cb9540cfe":{"kind":"REWORK","_number":5,"created":"2015-06-27 01:42:26.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/5"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-27 01:42:11.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/923fc37acb4e979d771e0ac93468c33cb9540cfe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/923fc37acb4e979d771e0ac93468c33cb9540cfe"}]},"branch":"refs/heads/master"},"570b1ce5fb173b2e1db9a59701228fb9e162d8ab":{"kind":"REWORK","_number":6,"created":"2015-06-27 03:07:21.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/6"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-27 03:07:13.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/570b1ce5fb173b2e1db9a59701228fb9e162d8ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/570b1ce5fb173b2e1db9a59701228fb9e162d8ab"}]},"branch":"refs/heads/master"},"7bb038c4a77c396d1831a4e48dfe1f3a3202c279":{"kind":"REWORK","_number":7,"created":"2015-06-27 03:19:16.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/22/194922/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/194922/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/194922/7"}}},"commit":{"parents":[{"commit":"af7f64eae5c89ca5faf380ec03d1d9f31707b2a9","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/af7f64eae5c89ca5faf380ec03d1d9f31707b2a9"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-24 03:16:31.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-06-27 03:19:08.000000000","tz":-240},"subject":"Add support for volume API v1 QoS commands","message":"Add support for volume API v1 QoS commands\n\nThis commit adds the following commands:\n  volume qos associate\n  volume qos create\n  volume qos delete\n  volume qos disassociate\n  volume qos list\n  volume qos set\n  volume qos show\n  volume qos unset\n\nChange-Id: I72ea1b9a4d0bd0e35eda03071ea438b75439fce9\nPartial-Bug: #1467967\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bb038c4a77c396d1831a4e48dfe1f3a3202c279"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bb038c4a77c396d1831a4e48dfe1f3a3202c279"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}