)]}'
{"id":"openstack%2Fpython-openstackclient~19720","triplet_id":"openstack%2Fpython-openstackclient~master~Ib0325e62a7e50aa94e852a73f9a2cb95daa8d5f6","project":"openstack/python-openstackclient","branch":"master","topic":"image_support","hashtags":[],"change_id":"Ib0325e62a7e50aa94e852a73f9a2cb95daa8d5f6","subject":"Adds Glance API v2 support.","status":"MERGED","created":"2013-01-15 18:24:24.000000000","updated":"2013-01-17 01:53:17.000000000","submitted":"2013-01-17 01:53:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ab842fa5d9075613dc52524b0eb85b8f46fa8a13","_number":19720,"virtual_id_number":19720,"owner":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2013-01-17 01:53:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"recommended":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-01-16 20:39:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-01-17 01:50:48.000000000","_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-01-17 01:50:48.000000000","_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-16 00:51:33.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-01-16 20:39:36.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-01-17 01:50:48.000000000","updated_by":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"reviewer":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"state":"REVIEWER"},{"updated":"2013-01-17 01:53:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f4c7cf0900f30e4f8e221b26dd85b798983a55bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 18:26:58.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/19720/1/check/gate-python-openstackclient-docs/48 : SUCCESS\n- http://logs.openstack.org/19720/1/check/gate-python-openstackclient-pep8/117 : SUCCESS\n- http://logs.openstack.org/19720/1/check/gate-python-openstackclient-python26/116 : SUCCESS\n- http://logs.openstack.org/19720/1/check/gate-python-openstackclient-python27/120 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"d3d05811446ae9b69448a3e8ba1527431c40dcba","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-15 18:28:16.000000000","message":"Patch Set 1:\n\nI\u0027ll test this out in a bit.  Rebuilding devstack atm.","accounts_in_message":[],"_revision_number":1},{"id":"eda0e4cab005d65c82280af7df887398e2914273","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-15 18:30:34.000000000","message":"Patch Set 1:\n\nOnce this lands, I\u0027ll go back and add support for V1 API. I also plan to add missing unit test coverage for the whole package.","accounts_in_message":[],"_revision_number":1},{"id":"f0045911321e0225576ca5a98479f33bc1141c9b","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-15 22:40:15.000000000","message":"Patch Set 1:\n\nFrom a functional standpoint the code works.  I just ran some tests in devstack and I am seeing basic glance API functionality working. So that\u0027s great!","accounts_in_message":[],"_revision_number":1},{"id":"14c4fa3a1c0db407ca5b4658133666cc951dbb75","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-15 22:48:36.000000000","message":"Patch Set 1:\n\nQuestion though.  Save image can save to an existing image id.  But how do you create a new image id?","accounts_in_message":[],"_revision_number":1},{"id":"8aa1ec9d1a26d831566b12a1c786af5f51191849","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-15 22:50:05.000000000","message":"Patch Set 1:\n\nThat functionality is coming soon. :)","accounts_in_message":[],"_revision_number":1},{"id":"5f205e02d3273d47c578f414e5fb12849902a576","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-15 22:50:28.000000000","message":"Patch Set 1:\n\nI wanted to get this in now since it seems to be pretty solid, before the patch got too big.","accounts_in_message":[],"_revision_number":1},{"id":"6f365608700523017ccefea7a852b90132e29da9","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-15 22:55:22.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI am giving this a plus 1.  Would like to see some other input though.","accounts_in_message":[],"_revision_number":1},{"id":"8840737dfd8d079a31c786c9771664e6714be977","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-16 00:02:53.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"f0a49516f5dfada40c2152779dcc21f8a968c3b4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-01-16 00:51:33.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nmake_client() can be simplified a bit.  We already have authenticated when this is called, the goods are in \u0027instance\u0027.","accounts_in_message":[],"_revision_number":1},{"id":"d68518858b9f9dfc9cc03c2c147b966529722c65","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-16 17:29:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"309e952d0b4a94ea9e64e54c9031d2185d94e861","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-16 17:32:52.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/19720/2/check/gate-python-openstackclient-docs/53 : SUCCESS\n- http://logs.openstack.org/19720/2/check/gate-python-openstackclient-pep8/122 : SUCCESS\n- http://logs.openstack.org/19720/2/check/gate-python-openstackclient-python26/121 : SUCCESS\n- http://logs.openstack.org/19720/2/check/gate-python-openstackclient-python27/125 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"639af4dcfe2b9a4576c4801cbf1e5e495c97cf10","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-16 20:15:50.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nFunctional testing works.  And it looks like all the commentary has been addressed.","accounts_in_message":[],"_revision_number":2},{"id":"40654e5f77df8cb98178490ad4eab7c56a06f224","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-16 20:39:36.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b8da40a65b8393214aeb73101cb4adeebe02f7a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 01:50:49.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"bd0927768ff89ea2096bd4974fed910e5756c2a4","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-17 01:50:49.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"130b362422fa900546dbae4ffb97bd7d4b683aec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 01:53:17.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/19720/2/gate/gate-python-openstackclient-docs/54 : SUCCESS\n- http://logs.openstack.org/19720/2/gate/gate-python-openstackclient-pep8/123 : SUCCESS\n- http://logs.openstack.org/19720/2/gate/gate-python-openstackclient-python26/122 : SUCCESS\n- http://logs.openstack.org/19720/2/gate/gate-python-openstackclient-python27/126 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"f81e1e48a53e36bee4d9a29c8c139a16685340d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 01:53:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb1ae2e9f23d618069e5eee7abedbd5a049d2878","revisions":{"e1bd81c4d555dc3650ed79ddc266eb3ff7f8b17b":{"kind":"REWORK","_number":1,"created":"2013-01-15 18:24:24.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/20/19720/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/19720/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/1"}}},"commit":{"parents":[{"commit":"67e413a224d8bec7729ec1aa703c6e4c91ee243b","subject":"Fixes setup compatibility issue on Windows","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/67e413a224d8bec7729ec1aa703c6e4c91ee243b"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-12-26 20:22:23.000000000","tz":-360},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-15 18:24:23.000000000","tz":-360},"subject":"Adds Glance API v2 support.","message":"Adds Glance API v2 support.\n\nChange-Id: Ib0325e62a7e50aa94e852a73f9a2cb95daa8d5f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e1bd81c4d555dc3650ed79ddc266eb3ff7f8b17b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e1bd81c4d555dc3650ed79ddc266eb3ff7f8b17b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"67e413a224d8bec7729ec1aa703c6e4c91ee243b","is_merged_in_target_branch":true,"change_id":"I33d38e0f96b6d124248c4a31959952d61cf1eb16","change_number":15301,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"eb1ae2e9f23d618069e5eee7abedbd5a049d2878":{"kind":"REWORK","_number":2,"created":"2013-01-16 17:29:51.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/20/19720/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/19720/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/19720/2"}}},"commit":{"parents":[{"commit":"67e413a224d8bec7729ec1aa703c6e4c91ee243b","subject":"Fixes setup compatibility issue on Windows","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/67e413a224d8bec7729ec1aa703c6e4c91ee243b"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-12-26 20:22:23.000000000","tz":-360},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-16 17:29:34.000000000","tz":-360},"subject":"Adds Glance API v2 support.","message":"Adds Glance API v2 support.\n\nChange-Id: Ib0325e62a7e50aa94e852a73f9a2cb95daa8d5f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb1ae2e9f23d618069e5eee7abedbd5a049d2878"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb1ae2e9f23d618069e5eee7abedbd5a049d2878"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"67e413a224d8bec7729ec1aa703c6e4c91ee243b","is_merged_in_target_branch":true,"change_id":"I33d38e0f96b6d124248c4a31959952d61cf1eb16","change_number":15301,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
