)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b93ec3575dad0e7e38ee714297a0f34f8a6cccc0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds support for showing which host aggregates"},{"line_number":10,"context_line":"a hypervisor is member of, if any."},{"line_number":11,"context_line":"It supports hypervisors with or without nova cells."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0cfe4f15fa8f8ba0be3295b79cd438998893114c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_38d20b5d","line":12,"updated":"2015-07-02 08:51:54.000000000","message":"can you open a bug for this patch","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"}],"openstackclient/compute/v2/hypervisor.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d267af22abf2ea24efdaaa91b1745c51d90eab7b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        hypervisor \u003d utils.find_resource(compute_client.hypervisors,"},{"line_number":78,"context_line":"                                         parsed_args.hypervisor)._info.copy()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        aggregates \u003d compute_client.aggregates.list()"},{"line_number":81,"context_line":"        hypervisor[\"aggregates\"] \u003d list()"},{"line_number":82,"context_line":"        if aggregates:"},{"line_number":83,"context_line":"            # Hypervisors in nova cells are prefixed by \"\u003ccell\u003e@\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c0932f4e","line":80,"updated":"2015-07-01 02:43:17.000000000","message":"i\u0027ll confess that i don\u0027t know all that much about aggregates, is there any way this will toss up an exception? maybe consider wrapping this with a try/except?","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"34f7e25f6f96f6664b50ccd534fc669f9fb8500f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        hypervisor \u003d utils.find_resource(compute_client.hypervisors,"},{"line_number":78,"context_line":"                                         parsed_args.hypervisor)._info.copy()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        aggregates \u003d compute_client.aggregates.list()"},{"line_number":81,"context_line":"        hypervisor[\"aggregates\"] \u003d list()"},{"line_number":82,"context_line":"        if aggregates:"},{"line_number":83,"context_line":"            # Hypervisors in nova cells are prefixed by \"\u003ccell\u003e@\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e6fe6fad","line":80,"in_reply_to":"ba3cc151_c0932f4e","updated":"2015-07-01 14:35:30.000000000","message":"Looking up novaclient and nova, it looks like the worst case scenario is that an empty list will be returned. There are no exception or errors if this happens and the aggregates key will be set to [] in the key/value table.\nFWIW I tested this with and without aggregates and with and without nova cells in my own environments.\nI would\u0027ve added tests but there are no tests at all for hypervisor yet, I\u0027ll leave it for another commit.\n\nWhat I thought about, however, is that we might want not to set the aggregates key at all if the hypervisor is not member of an aggregate. I went with an empty list at the end for consistency.","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b93ec3575dad0e7e38ee714297a0f34f8a6cccc0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if aggregates:"},{"line_number":83,"context_line":"            # Hypervisors in nova cells are prefixed by \"\u003ccell\u003e@\""},{"line_number":84,"context_line":"            if \"@\" in hypervisor[\u0027service\u0027][\u0027host\u0027]:"},{"line_number":85,"context_line":"                cell \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[0]"},{"line_number":86,"context_line":"                service_host \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[1]"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                cell \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f8a263fb","line":85,"updated":"2015-07-02 08:51:54.000000000","message":"could be simplified with:\n\ncell, service_host \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c54924b406c9d96bf3ed4b70b86947d3b2436bad","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if aggregates:"},{"line_number":83,"context_line":"            # Hypervisors in nova cells are prefixed by \"\u003ccell\u003e@\""},{"line_number":84,"context_line":"            if \"@\" in hypervisor[\u0027service\u0027][\u0027host\u0027]:"},{"line_number":85,"context_line":"                cell \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[0]"},{"line_number":86,"context_line":"                service_host \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[1]"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                cell \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a2d33a5f","line":85,"in_reply_to":"ba3cc151_f8a263fb","updated":"2015-07-02 14:24:35.000000000","message":"Done","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d930a8c43a64042c78abc5814f070dc847df2a55","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if aggregates:"},{"line_number":83,"context_line":"            # Hypervisors in nova cells are prefixed by \"\u003ccell\u003e@\""},{"line_number":84,"context_line":"            if \"@\" in hypervisor[\u0027service\u0027][\u0027host\u0027]:"},{"line_number":85,"context_line":"                cell \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[0]"},{"line_number":86,"context_line":"                service_host \u003d hypervisor[\u0027service\u0027][\u0027host\u0027].split(\u0027@\u0027)[1]"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                cell \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8afad673","line":85,"in_reply_to":"ba3cc151_f8a263fb","updated":"2015-07-02 12:36:24.000000000","message":"Make it split(\u0027@\u0027, 1) and it will be less likely to blow up.","commit_id":"e728d550e0dbb53fb4b790e583f58e1ab09df352"}]}