)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7677d32f10c42baf95cebebf21d05a6e53e51663","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        for network in parsed_args.network:"},{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                self.log.warning(\"Network not found: %s\" % network)"},{"line_number":136,"context_line":"            else:"},{"line_number":137,"context_line":"                client.delete_network(obj)"},{"line_number":138,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7b854405","line":135,"updated":"2015-12-11 01:21:50.000000000","message":"Since the network could be a name or ID, how about \"No network found associated with name or ID %s\" % network ?","commit_id":"191e1dfcea5af478b1cb209bf9c973c241a934da"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"68d62e9e39ea230a8ecdc34e840539e1c75b14b5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        for network in parsed_args.network:"},{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                self.log.warning(\"Network not found: %s\" % network)"},{"line_number":136,"context_line":"            else:"},{"line_number":137,"context_line":"                client.delete_network(obj)"},{"line_number":138,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_fbcb5851","line":135,"in_reply_to":"7a740942_7b854405","updated":"2015-12-11 13:49:58.000000000","message":"Sounds good.","commit_id":"191e1dfcea5af478b1cb209bf9c973c241a934da"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9afa0bacd06534fbef6b0e05fc3431243d640602","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                msg \u003d \"No network found with name or ID %s\" % network"},{"line_number":136,"context_line":"                self.log.warning(msg)"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                client.delete_network(obj)"},{"line_number":139,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_bb03900f","line":136,"updated":"2015-12-11 13:59:08.000000000","message":"My concern here is that this changes behavior and no longer results in the command returning a 0 (success) exit code.","commit_id":"68ad44b615a960bd98dd3ded4a4b31f2992e1e0b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"e45bfff90d1381c3fff43d7d9e7948c6f976a912","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                msg \u003d \"No network found with name or ID %s\" % network"},{"line_number":136,"context_line":"                self.log.warning(msg)"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                client.delete_network(obj)"},{"line_number":139,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_fd573cc8","line":136,"updated":"2015-12-15 04:15:16.000000000","message":"There are lots of similar problems in network in osc.  Actually, all the commands I have added didn\u0027t handle error.  They will simply return the http error when failed. \n\nI think the error msg is necessary. I prefer to delete as many resources as we can, and print out those who are failed to delete, and the command returns 0.","commit_id":"68ad44b615a960bd98dd3ded4a4b31f2992e1e0b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fdf64a05b25f65e2b163a8e0cd14707b2b92d761","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                msg \u003d \"No network found with name or ID %s\" % network"},{"line_number":136,"context_line":"                self.log.warning(msg)"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                client.delete_network(obj)"},{"line_number":139,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_222d8aa7","line":136,"in_reply_to":"5a710552_fd573cc8","updated":"2015-12-15 12:48:33.000000000","message":"I don\u0027t think the command should return 0 unless all resources have been deleted.","commit_id":"68ad44b615a960bd98dd3ded4a4b31f2992e1e0b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f30dbddca893687f4d1c06e332f579254216f174","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                msg \u003d \"No network found with name or ID %s\" % network"},{"line_number":136,"context_line":"                self.log.warning(msg)"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                client.delete_network(obj)"},{"line_number":139,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_7806781d","line":136,"in_reply_to":"7a740942_99ea5c0e","updated":"2015-12-11 19:46:06.000000000","message":"I agree that delete with nargs should try to delete all the args, print errors on failures and return 1 for partial failure.","commit_id":"68ad44b615a960bd98dd3ded4a4b31f2992e1e0b"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"9f6142ad08dcea645cfae178c6d72518063e0661","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            obj \u003d client.find_network(network)"},{"line_number":134,"context_line":"            if not obj:"},{"line_number":135,"context_line":"                msg \u003d \"No network found with name or ID %s\" % network"},{"line_number":136,"context_line":"                self.log.warning(msg)"},{"line_number":137,"context_line":"            else:"},{"line_number":138,"context_line":"                client.delete_network(obj)"},{"line_number":139,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_99ea5c0e","line":136,"in_reply_to":"7a740942_bb03900f","updated":"2015-12-11 14:20:45.000000000","message":"Yeh, there is no consistent story here.  In my opinion, any delete that supports nargs should try to delete all the args, print errors on failures and return 1 for partial failure, but most will just fail on the first failure.  Perhaps I should abandon this.","commit_id":"68ad44b615a960bd98dd3ded4a4b31f2992e1e0b"}]}