)]}'
{"openstackclient/identity/v2_0/catalog.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"2cecdf4cec7ccba5bb518d557d31ff94509b921d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        region \u003d eps[index].get(\u0027region\u0027, \u0027\u003cnone\u003e\u0027)"},{"line_number":32,"context_line":"        ret +\u003d region + \u0027\\n\u0027"},{"line_number":33,"context_line":"        for url in [\u0027publicURL\u0027, \u0027internalURL\u0027, \u0027adminURL\u0027]:"},{"line_number":34,"context_line":"            ret +\u003d \"  %s: %s\\n\" % (url, eps[index].get(url, \u0027\u003cnone\u003e\u0027))"},{"line_number":35,"context_line":"    return ret"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_567b127b","line":34,"updated":"2015-07-15 14:57:51.000000000","message":"I think it would be better if we add nothing to ret if there is no endpoint of the url type.\n\nUnrelated, but kind of confusing that the url variable here is url_type.","commit_id":"fec7b74856883ede28c1d460c13ded7d5785648f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e9062170fb27d7bdfa95f6216abd22fe731c798a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        region \u003d eps[index].get(\u0027region\u0027, \u0027\u003cnone\u003e\u0027)"},{"line_number":32,"context_line":"        ret +\u003d region + \u0027\\n\u0027"},{"line_number":33,"context_line":"        for url in [\u0027publicURL\u0027, \u0027internalURL\u0027, \u0027adminURL\u0027]:"},{"line_number":34,"context_line":"            ret +\u003d \"  %s: %s\\n\" % (url, eps[index].get(url, \u0027\u003cnone\u003e\u0027))"},{"line_number":35,"context_line":"    return ret"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_f04d89c4","line":34,"in_reply_to":"9a41bdd9_567b127b","updated":"2015-07-15 15:52:26.000000000","message":"i think this should clean things up a bit:\n\n  for endpoint_type in  [\u0027publicURL\u0027, \u0027internalURL\u0027, \u0027adminURL\u0027]:\n    url \u003d eps[index].get(endpoint_type)\n    if url:\n      ret +\u003d \"  %s: %s\\n\" % (endpoint_type, url)","commit_id":"fec7b74856883ede28c1d460c13ded7d5785648f"},{"author":{"_account_id":13744,"name":"Guojian Shao","email":"tjusgj@gmail.com","username":"gjshao"},"change_message_id":"c0c0b99429f079971640c17ee8b1cc7e0c7525d1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        region \u003d eps[index].get(\u0027region\u0027, \u0027\u003cnone\u003e\u0027)"},{"line_number":32,"context_line":"        ret +\u003d region + \u0027\\n\u0027"},{"line_number":33,"context_line":"        for url in [\u0027publicURL\u0027, \u0027internalURL\u0027, \u0027adminURL\u0027]:"},{"line_number":34,"context_line":"            ret +\u003d \"  %s: %s\\n\" % (url, eps[index].get(url, \u0027\u003cnone\u003e\u0027))"},{"line_number":35,"context_line":"    return ret"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_33177b49","line":34,"in_reply_to":"9a41bdd9_f04d89c4","updated":"2015-07-15 15:59:20.000000000","message":"Done","commit_id":"fec7b74856883ede28c1d460c13ded7d5785648f"}]}
