)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9edc0f6b4aed62e3c43ea085180e2278741d63ba","unresolved":false,"context_lines":[{"line_number":17,"context_line":"volume. And the bug is only about the above five, all is compute quota."},{"line_number":18,"context_line":"Keep things short and concise,this bug is only about compute quota set."},{"line_number":19,"context_line":"So there is no need to change volume quota set."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ic1028d561f5a0030cf65ac18fc117bf01e945478"},{"line_number":22,"context_line":"Partial-Bug: #1420104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a50d1a3_f74fdb8f","line":20,"updated":"2015-07-28 13:40:07.000000000","message":"This is too complicated a commit message.  you need to clearly state the problem you are fixing, but with our resorting to code","commit_id":"f69bea9bb905973fda505d3f6e9a8d9c381974d1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7870a76a8290279aa207276a9293587aa4985f9b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in nova, can make \u0027quota set injected-file-size\u0027 ok.It\u0027s a nova bug."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"And the bug is only about the above five, all is compute quota."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic1028d561f5a0030cf65ac18fc117bf01e945478"},{"line_number":20,"context_line":"Partial-Bug: #1420104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a50d1a3_5ab1168e","line":18,"updated":"2015-07-28 13:56:56.000000000","message":"Sorry, imho, still too complicated.  Isn\u0027t it the case of something like:\n\n\"The setting of compute quotas would cause incorrect values to be assigned (...or whatever the actual failure is...), which is fixed in this patch.\"\n\nIf there are other issues you have found in the code that will be fixed by other patches, then you should make these as a TODO and reference a different defect number.","commit_id":"ab295442dc5f30669bd7b3293f2eebf472f5aa1b"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"31db3030c3075e25f0d39fb4ded98735579c21f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in nova, can make \u0027quota set injected-file-size\u0027 ok.It\u0027s a nova bug."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"And the bug is only about the above five, all is compute quota."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic1028d561f5a0030cf65ac18fc117bf01e945478"},{"line_number":20,"context_line":"Partial-Bug: #1420104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a50d1a3_2dbe56ae","line":18,"in_reply_to":"3a50d1a3_5ab1168e","updated":"2015-07-29 12:39:07.000000000","message":"Done","commit_id":"ab295442dc5f30669bd7b3293f2eebf472f5aa1b"}],"openstackclient/common/quota.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"446601e035d3f77e81cc17b61622a775c0465ba4","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        compute_kwargs \u003d {}"},{"line_number":99,"context_line":"        for k, v in COMPUTE_QUOTAS.items():"},{"line_number":100,"context_line":"            value \u003d getattr(parsed_args, v, getattr(parsed_args, k, None))"},{"line_number":101,"context_line":"            if value is not None:"},{"line_number":102,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_813a1fcc","line":100,"updated":"2015-07-18 11:37:52.000000000","message":"I\u0027m a little confused, but I wouldn\u0027t think it possible that parsed_args would have any of the values, just the keys.","commit_id":"90c8fd6e2a6b229d691bc93cff41d6d6cc820f82"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"02821daddc685988f188387c97a4c5c4ce216773","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        compute_kwargs \u003d {}"},{"line_number":99,"context_line":"        for k, v in COMPUTE_QUOTAS.items():"},{"line_number":100,"context_line":"            value \u003d getattr(parsed_args, v, getattr(parsed_args, k, None))"},{"line_number":101,"context_line":"            if value is not None:"},{"line_number":102,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_a1bf23fb","line":100,"in_reply_to":"9a41bdd9_813a1fcc","updated":"2015-07-29 05:58:49.000000000","message":"in openstackclient/common/quota.py\n \n30 COMPUTE_QUOTAS \u003d {\n 31     \u0027cores\u0027: \u0027cores\u0027,\n 32     \u0027fixed_ips\u0027: \u0027fixed-ips\u0027,\n 33     \u0027floating_ips\u0027: \u0027floating-ips\u0027,\n 34     \u0027injected_file_content_bytes\u0027: \u0027injected-file-size\u0027,\n 35     \u0027injected_file_path_bytes\u0027: \u0027injected-path-size\u0027,\n 36     \u0027injected_files\u0027: \u0027injected-files\u0027,\n 37     \u0027instances\u0027: \u0027instances\u0027,                                                                                           \n 38     \u0027key_pairs\u0027: \u0027key-pairs\u0027,\n 39     \u0027metadata_items\u0027: \u0027properties\u0027,\n 40     \u0027ram\u0027: \u0027ram\u0027,\n 41     \u0027security_group_rules\u0027: \u0027secgroup-rules\u0027,\n 42     \u0027security_groups\u0027: \u0027secgroups\u0027,\n 43 }\n\nwhen  openstack quota set --floating-ips 11 testproject_dx \n\nthe value of floating-ip will be store in a dict, the key is floating_ip.\nBut\n 99         for k, v in COMPUTE_QUOTAS.items():\n100             value \u003d getattr(parsed_args, v, None)\n\nwe use v  (\u0027floating-ips\u0027) as a key to get value of floating_ip, so got None.\ncores,instance is normal.The reason is the key \u003d\u003d value \nfor them in COMPUTE_QUOTAS above.","commit_id":"90c8fd6e2a6b229d691bc93cff41d6d6cc820f82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"831f08a9e1724d8dcdfc3a2534c45a80bcaee979","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        compute_kwargs \u003d {}"},{"line_number":99,"context_line":"        for k, v in COMPUTE_QUOTAS.items():"},{"line_number":100,"context_line":"            value \u003d getattr(parsed_args, v, getattr(parsed_args, k, None))"},{"line_number":101,"context_line":"            if value is not None:"},{"line_number":102,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_085e4f76","line":100,"in_reply_to":"9a41bdd9_813a1fcc","updated":"2015-07-21 00:10:51.000000000","message":"yeah, where is \"k\" set?\n\nare you planning to set this manually in the calling code? sounds like hacky to me and hard to maintain","commit_id":"90c8fd6e2a6b229d691bc93cff41d6d6cc820f82"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"c86180a6638e82599605f4b36b74cc200d565ded","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        compute_kwargs \u003d {}"},{"line_number":99,"context_line":"        for k, v in COMPUTE_QUOTAS.items():"},{"line_number":100,"context_line":"            v \u003d v.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":101,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":102,"context_line":"            if value is not None:"},{"line_number":103,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_fa9b4216","line":101,"updated":"2015-07-22 14:20:14.000000000","message":"instead of that replace there, should this be k instead of v? ^","commit_id":"821373a436c56fefb9007d8ad57653a9d8b08f50"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"416b0084f89096739f0c323b20c8eb26facdb70c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        compute_kwargs \u003d {}"},{"line_number":99,"context_line":"        for k, v in COMPUTE_QUOTAS.items():"},{"line_number":100,"context_line":"            v \u003d v.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":101,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":102,"context_line":"            if value is not None:"},{"line_number":103,"context_line":"                compute_kwargs[k] \u003d value"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4d15e23d","line":101,"in_reply_to":"3a50d1a3_fa9b4216","updated":"2015-07-29 05:59:21.000000000","message":"I think both will work.  Use k instead of v will be better.\n\nDone.","commit_id":"821373a436c56fefb9007d8ad57653a9d8b08f50"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2d9b933e197f3dfed06c65b024e06a988bc34ce6","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_c49e9662","side":"PARENT","line":106,"updated":"2015-07-22 21:38:37.000000000","message":"Is not the same bug present here?","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"9464d4779037d24d642e671737b534f3b320d241","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_ae61e0aa","side":"PARENT","line":106,"in_reply_to":"3a50d1a3_c49e9662","updated":"2015-07-29 12:38:43.000000000","message":"@Dean Troyer\nNO!!!\nBecause in VOLUME_QUOTAS. k \u003d v.","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"82287883f7463af191d84a4ab845dc265cd3e855","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1929188a","side":"PARENT","line":106,"updated":"2015-07-23 14:28:18.000000000","message":"The same bug is here too, I\u0027d just fix it now as fixing quotas is the whole point of this review and this code was clearly duplicated from above.","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"d19b2e878e8e3a79fcd2f194f18fdc144103fd0e","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f771b7a9","side":"PARENT","line":106,"in_reply_to":"3a50d1a3_1929188a","updated":"2015-07-29 12:38:52.000000000","message":"Done","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ba18597e65df846dcb563d8b5e82370520d631fa","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_776619ee","side":"PARENT","line":106,"in_reply_to":"3a50d1a3_1929188a","updated":"2015-07-23 17:36:04.000000000","message":"good catch\n\n add  test coverage for the volume quota fields too?","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"d19b2e878e8e3a79fcd2f194f18fdc144103fd0e","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_37787f8f","side":"PARENT","line":106,"in_reply_to":"3a50d1a3_776619ee","updated":"2015-07-29 12:38:52.000000000","message":"Done","commit_id":"8175ce5985ae1c9846a8b67ac6abbb2e3ba360e1"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"e788652198fa1c8f61d2903a5225598fe498f80e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                volume_client.quota_classes.update("},{"line_number":123,"context_line":"                    parsed_args.project,"},{"line_number":124,"context_line":"                    **volume_kwargs)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            if compute_kwargs:"},{"line_number":127,"context_line":"                compute_client.quotas.update("},{"line_number":128,"context_line":"                    parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_9e9ee7b6","line":125,"updated":"2015-07-27 14:53:02.000000000","message":"This is the case being tested.","commit_id":"71d67d20046bed0e8a00e3186387d5746c564a1a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7870a76a8290279aa207276a9293587aa4985f9b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_1a9cee68","line":106,"updated":"2015-07-28 13:56:56.000000000","message":"why is this different from the test in compute quotas?","commit_id":"ab295442dc5f30669bd7b3293f2eebf472f5aa1b"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"31db3030c3075e25f0d39fb4ded98735579c21f2","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":107,"context_line":"            if value is not None:"},{"line_number":108,"context_line":"                if parsed_args.volume_type:"},{"line_number":109,"context_line":"                    k \u003d k + \u0027_%s\u0027 % parsed_args.volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_6d11be51","line":106,"in_reply_to":"3a50d1a3_1a9cee68","updated":"2015-07-29 12:39:07.000000000","message":"My dear sir.All the quota of volume can be set successfully. You can verify that by yourself.In commit log, I have said that only five quotas of compute will be set failed","commit_id":"ab295442dc5f30669bd7b3293f2eebf472f5aa1b"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d7797f1cd459ae39718df69e17a9087f36f9f702","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            # TODO: it works fine now. about use \u0027v\u0027 or \u0027k\u0027"},{"line_number":107,"context_line":"            # needs discuss and needs to report a bug if it\u0027s"},{"line_number":108,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":109,"context_line":"            if value is not None:"},{"line_number":110,"context_line":"                if parsed_args.volume_type:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_a70a6cd0","line":107,"updated":"2015-07-28 21:43:31.000000000","message":"Just skip this comment k \u003d\u003d v for volume","commit_id":"ccd0d19ab731a382d64d532782ebddb9003384c2"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"f150cac1d26cbc3a7a1aa6574b85a979b363861f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        volume_kwargs \u003d {}"},{"line_number":105,"context_line":"        for k, v in VOLUME_QUOTAS.items():"},{"line_number":106,"context_line":"            # TODO: it works fine now. about use \u0027v\u0027 or \u0027k\u0027"},{"line_number":107,"context_line":"            # needs discuss and needs to report a bug if it\u0027s"},{"line_number":108,"context_line":"            value \u003d getattr(parsed_args, v, None)"},{"line_number":109,"context_line":"            if value is not None:"},{"line_number":110,"context_line":"                if parsed_args.volume_type:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_b32b8a81","line":107,"in_reply_to":"3a50d1a3_a70a6cd0","updated":"2015-07-29 12:39:15.000000000","message":"Delelte this comment ???","commit_id":"ccd0d19ab731a382d64d532782ebddb9003384c2"}],"openstackclient/tests/common/test_quota.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b47245c9c4c6bdabd492dcde9b1033663764b111","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Symantec Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_2b01576a","line":1,"updated":"2015-07-22 16:47:39.000000000","message":"umm don\u0027t think this is accurate","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2d9b933e197f3dfed06c65b024e06a988bc34ce6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Symantec Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_6411c203","line":1,"in_reply_to":"3a50d1a3_2b01576a","updated":"2015-07-22 21:38:37.000000000","message":"Copyright lines are only required if the author\u0027s company requires them.  The foundation does not require them in each individual source file.","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1e172288e7c0a924ca3d7bae91eb2c39e2f6dbfd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Symantec Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_e44392ad","line":1,"in_reply_to":"3a50d1a3_6411c203","updated":"2015-07-22 21:41:51.000000000","message":"I mean the author is not from symantec :)","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"9464d4779037d24d642e671737b534f3b320d241","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Symantec Corporation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_ae0800db","line":1,"in_reply_to":"3a50d1a3_e44392ad","updated":"2015-07-29 12:38:43.000000000","message":"I will delete it.","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"03dea556b7ca4dde398fdc99d6d9ae63a0781444","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_eb2db646","line":76,"updated":"2015-07-22 14:47:04.000000000","message":"Ideally, I guess it would be nice to see that update was called with the expected args","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b47245c9c4c6bdabd492dcde9b1033663764b111","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8bf0ab92","line":76,"in_reply_to":"3a50d1a3_eb2db646","updated":"2015-07-22 16:47:39.000000000","message":"++","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"9464d4779037d24d642e671737b534f3b320d241","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_cb00fa68","line":76,"in_reply_to":"3a50d1a3_eb2db646","updated":"2015-07-29 12:38:43.000000000","message":"@Terry Howe: Sorry, More details ?\n@Lin Hua Cheng: What do you mean? What does he mean ?","commit_id":"216c8dba00fdd1ce155d3a130097fb34f93d6a18"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"b945de8f378c088690aaa79f559023d5db751ba1","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_ddf6438e","line":74,"updated":"2015-07-23 12:56:09.000000000","message":"Can we get a self.quotas_mock.update.assert_called_with(...) here?","commit_id":"aa933701c0960c3594ae88fd256089c508e23f4d"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"d19b2e878e8e3a79fcd2f194f18fdc144103fd0e","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_5df47359","line":74,"in_reply_to":"3a50d1a3_ddf6438e","updated":"2015-07-29 12:38:52.000000000","message":"Would you please teach me how ? Add a new function? I\u0027m a newer.","commit_id":"aa933701c0960c3594ae88fd256089c508e23f4d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"26e39a35f8bcf754c23e0c2eb031d73b42ddc9c5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.cmd \u003d quota.SetQuota(self.app, None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_quota_set(self):"},{"line_number":57,"context_line":"        arglist \u003d ["},{"line_number":58,"context_line":"            \u0027--floating-ips\u0027, \u0027110\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_2e9a69c6","line":55,"updated":"2015-07-24 04:05:44.000000000","message":"instead of using 110/project_test, re-use the value from fakes.py","commit_id":"a1495011f51cd9704f5120098cd0a478ff7b9121"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"e788652198fa1c8f61d2903a5225598fe498f80e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestQuota, self).setUp()"},{"line_number":39,"context_line":"        self.quotas_mock \u003d self.app.client_manager.compute.quotas"},{"line_number":40,"context_line":"        self.quotas_mock.reset_mock()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_9eeca72a","line":39,"updated":"2015-07-27 14:53:02.000000000","message":"I think the quotas mock needs an update mock.","commit_id":"71d67d20046bed0e8a00e3186387d5746c564a1a"}]}