)]}'
{"doc/source/command-objects/volume-type.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9f6c58a6b195b0e68b0f72af6da7bb4a1a90d213","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    os volume type set"},{"line_number":86,"context_line":"        [--property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":87,"context_line":"        \u003cvolume-type\u003e"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a50d1a3_129471e6","line":87,"updated":"2015-07-24 02:37:50.000000000","message":"these docs should include --description and --name too","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"857d3e8d4efc981ba8d8c67f87ca960648d1fbe4","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    os volume type set"},{"line_number":86,"context_line":"        [--property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":87,"context_line":"        \u003cvolume-type\u003e"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a4dcd0f_be8fbe73","line":87,"in_reply_to":"3a50d1a3_129471e6","updated":"2015-08-07 01:44:16.000000000","message":"Done","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"}],"openstackclient/volume/v2/volume_type.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"4fbc9e32cf081522e8bc550b076f115ecab9e219","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if parsed_args.property:"},{"line_number":210,"context_line":"            volume_type.unset_keys(parsed_args.property)"},{"line_number":211,"context_line":"        else:"},{"line_number":212,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":213,"context_line":"        return"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_8d02f108","line":212,"updated":"2015-07-22 22:41:53.000000000","message":"Normally, I think we are throwing a command error and this thing already has a log object.  i think we could get rid of this if --property gets required\u003dTrue,","commit_id":"5055e21e74b2a574de2c03de197e9ad6aa15ca19"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"76a5cd745c41fbdd9dfe443c2e70672bd270225f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":162,"context_line":"            help\u003d\u0027Property to add or modify for this volume type \u0027"},{"line_number":163,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":164,"context_line":"            required\u003dTrue,"},{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":"        return parser"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_971adac4","line":164,"updated":"2015-07-23 12:26:48.000000000","message":"I assume because of the action that required\u003dTrue does not work for this.  My mistake, sorry about that.","commit_id":"576985417fe0085a7df4dfa5670f7795e1419756"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b13e94901e8d13c33cd06a393ef4cd9e2a1dde","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":162,"context_line":"            help\u003d\u0027Property to add or modify for this volume type \u0027"},{"line_number":163,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":164,"context_line":"            required\u003dTrue,"},{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":"        return parser"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_42633242","line":164,"in_reply_to":"3a50d1a3_971adac4","updated":"2015-07-23 12:41:51.000000000","message":"Ignore this, I was using v1","commit_id":"576985417fe0085a7df4dfa5670f7795e1419756"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"76a5cd745c41fbdd9dfe443c2e70672bd270225f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            default\u003d[],"},{"line_number":194,"context_line":"            help\u003d\u0027Property to remove from volume type \u0027"},{"line_number":195,"context_line":"                 \u0027(repeat option to remove multiple properties)\u0027,"},{"line_number":196,"context_line":"            required\u003dTrue,"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":"        return parser"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_d7d942f4","line":196,"updated":"2015-07-23 12:26:48.000000000","message":"required\u003dTrue doesn\u0027t work.","commit_id":"576985417fe0085a7df4dfa5670f7795e1419756"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b13e94901e8d13c33cd06a393ef4cd9e2a1dde","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            default\u003d[],"},{"line_number":194,"context_line":"            help\u003d\u0027Property to remove from volume type \u0027"},{"line_number":195,"context_line":"                 \u0027(repeat option to remove multiple properties)\u0027,"},{"line_number":196,"context_line":"            required\u003dTrue,"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":"        return parser"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_225ce67b","line":196,"in_reply_to":"3a50d1a3_d7d942f4","updated":"2015-07-23 12:41:51.000000000","message":"Ignore this, I was using v1","commit_id":"576985417fe0085a7df4dfa5670f7795e1419756"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9f6c58a6b195b0e68b0f72af6da7bb4a1a90d213","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cvolume-type\u003e\u0027,"},{"line_number":156,"context_line":"            help\u003d\u0027Volume type to modify (name or ID)\u0027,"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        parser.add_argument("},{"line_number":159,"context_line":"            \u0027--property\u0027,"},{"line_number":160,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":161,"context_line":"            action\u003dparseractions.KeyValueAction,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_d258498d","line":158,"updated":"2015-07-24 02:37:50.000000000","message":"missing a few options here, looks like in v2 you can change description and name too: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volume_types.py#L131-L148\n\n  --name - New volume type name\n  -- description - New volume type description","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"857d3e8d4efc981ba8d8c67f87ca960648d1fbe4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cvolume-type\u003e\u0027,"},{"line_number":156,"context_line":"            help\u003d\u0027Volume type to modify (name or ID)\u0027,"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":"        parser.add_argument("},{"line_number":159,"context_line":"            \u0027--property\u0027,"},{"line_number":160,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":161,"context_line":"            action\u003dparseractions.KeyValueAction,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_81662728","line":158,"in_reply_to":"3a50d1a3_d258498d","updated":"2015-08-07 01:44:16.000000000","message":"Done","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9f6c58a6b195b0e68b0f72af6da7bb4a1a90d213","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--property\u0027,"},{"line_number":195,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":196,"context_line":"            default\u003d[],"},{"line_number":197,"context_line":"            help\u003d\u0027Property to remove from volume type \u0027"},{"line_number":198,"context_line":"                 \u0027(repeat option to remove multiple properties)\u0027,"},{"line_number":199,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_32cbad20","line":196,"updated":"2015-07-24 02:37:50.000000000","message":"add\n\n  required\u003dTrue\n\nhere","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9f6c58a6b195b0e68b0f72af6da7bb4a1a90d213","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            parsed_args.volume_type,"},{"line_number":208,"context_line":"        )"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if parsed_args.property:"},{"line_number":211,"context_line":"            volume_type.unset_keys(parsed_args.property)"},{"line_number":212,"context_line":"        else:"},{"line_number":213,"context_line":"            self.app.log.error(\"No changes requested\\n\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_f2d465be","line":210,"updated":"2015-07-24 02:37:50.000000000","message":"remove the conditionals here, since --property will be required","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b4b13be2c908ca1c03a3d6e9704113a173c91a31","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class UnsetVolumeType(command.Command):"},{"line_number":208,"context_line":"    \"\"\"Unset volume type properties\"\"\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.UnsetVolumeType\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_7415d799","line":207,"updated":"2015-08-07 02:28:03.000000000","message":"should be moved under Show, keep things alpha friendly","commit_id":"942560fa024428354489d525144b7afb0fb7e073"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b4b13be2c908ca1c03a3d6e9704113a173c91a31","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        parser.add_argument("},{"line_number":220,"context_line":"            \u0027--property\u0027,"},{"line_number":221,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":222,"context_line":"            default\u003d[],"},{"line_number":223,"context_line":"            help\u003d\u0027Property to remove from volume type \u0027"},{"line_number":224,"context_line":"                 \u0027(repeat option to remove multiple properties)\u0027,"},{"line_number":225,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_540e9b8c","line":222,"updated":"2015-08-07 02:28:03.000000000","message":"i think we got into the trend of adding:\n\n  required\u003dTrue","commit_id":"942560fa024428354489d525144b7afb0fb7e073"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b4b13be2c908ca1c03a3d6e9704113a173c91a31","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            parsed_args.volume_type,"},{"line_number":234,"context_line":"        )"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        if parsed_args.property:"},{"line_number":237,"context_line":"            volume_type.unset_keys(parsed_args.property)"},{"line_number":238,"context_line":"        else:"},{"line_number":239,"context_line":"            self.app.log.error(\"No changes requested\\n\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_14257307","line":236,"updated":"2015-08-07 02:28:03.000000000","message":"and then removing this conditional","commit_id":"942560fa024428354489d525144b7afb0fb7e073"}],"setup.cfg":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9f6c58a6b195b0e68b0f72af6da7bb4a1a90d213","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    volume_type_delete \u003d openstackclient.volume.v2.volume_type:DeleteVolumeType"},{"line_number":400,"context_line":"    volume_type_list \u003d openstackclient.volume.v2.volume_type:ListVolumeType"},{"line_number":401,"context_line":"    volume_type_set \u003d openstackclient.volume.v2.volume_type:SetVolumeType"},{"line_number":402,"context_line":"    volume_type_show \u003d openstackclient.volume.v2.volume_type:ShowVolumeType"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    volume_qos_associate \u003d openstackclient.volume.v2.qos_specs:AssociateQos"},{"line_number":405,"context_line":"    volume_qos_create \u003d openstackclient.volume.v2.qos_specs:CreateQos"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"3a50d1a3_f2eb0577","line":402,"updated":"2015-07-24 02:37:50.000000000","message":"missing unset from here","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"857d3e8d4efc981ba8d8c67f87ca960648d1fbe4","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    volume_type_delete \u003d openstackclient.volume.v2.volume_type:DeleteVolumeType"},{"line_number":400,"context_line":"    volume_type_list \u003d openstackclient.volume.v2.volume_type:ListVolumeType"},{"line_number":401,"context_line":"    volume_type_set \u003d openstackclient.volume.v2.volume_type:SetVolumeType"},{"line_number":402,"context_line":"    volume_type_show \u003d openstackclient.volume.v2.volume_type:ShowVolumeType"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    volume_qos_associate \u003d openstackclient.volume.v2.qos_specs:AssociateQos"},{"line_number":405,"context_line":"    volume_qos_create \u003d openstackclient.volume.v2.qos_specs:CreateQos"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"1a4dcd0f_aa00dd02","line":402,"in_reply_to":"3a50d1a3_f2eb0577","updated":"2015-08-07 01:44:16.000000000","message":"Done","commit_id":"9b5ed548b736ca8a41d65368a3f1b0cd32aa176c"}]}