)]}'
{"id":"openstack%2Fpython-openstackclient~205306","triplet_id":"openstack%2Fpython-openstackclient~master~Iba57211014caca16be7c9a28d15d4db2a6c51b8d","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1477629","hashtags":[],"change_id":"Iba57211014caca16be7c9a28d15d4db2a6c51b8d","subject":"Properly handle port arguments for ICMP","status":"MERGED","created":"2015-07-23 21:58:48.000000000","updated":"2015-09-08 21:18:07.000000000","submitted":"2015-09-08 21:18:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1ae3ec56f026ccde12495f61ddf693238a515053","_number":205306,"virtual_id_number":205306,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-09-08 21:18:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-08 18:18:24.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"recommended":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"all":[{"value":1,"date":"2015-09-03 18:08:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},{"value":2,"date":"2015-09-03 18:53:18.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-09-05 05:09:48.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2015-09-08 18:38:06.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-03 18:08:28.000000000","updated_by":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"reviewer":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"state":"REVIEWER"},{"updated":"2015-09-03 18:53:18.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-09-08 18:38:06.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-09-08 21:18:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cd434c13da1693a84426ae9744c243bd0aac155b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-07-23 21:58:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4cd89177ed23b15a2cbfaa279979a2ad6f237da","author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"date":"2015-07-23 23:28:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d4258822b33101b9201d731958051a6ac56878bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 00:14:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/06/205306/1/check/gate-python-openstackclient-python26/6ee7705/ : SUCCESS in 1m 54s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/205306/1/check/gate-python-openstackclient-pep8/cd92e41/ : SUCCESS in 1m 46s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/205306/1/check/gate-python-openstackclient-docs/3e15131//doc/build/html/ : SUCCESS in 3m 12s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/205306/1/check/gate-python-openstackclient-python27/02793a1/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/205306/1/check/gate-python-openstackclient-python34/db1734d/ : SUCCESS in 2m 23s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/205306/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/f63f165/ : SUCCESS in 52m 46s\n- gate-osc-dsvm-functional http://logs.openstack.org/06/205306/1/check/gate-osc-dsvm-functional/7337226/ : SUCCESS in 24m 14s","accounts_in_message":[],"_revision_number":1},{"id":"f2c94c30841d681515c14897729828833dfd8732","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-03 18:06:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"053937345f2d84ce65842ada0a813861cc926220","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-03 18:06:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bbfe60b826df626211961dd5d1c6dfdc5eb4ef5e","author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"date":"2015-09-03 18:08:28.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0626fca33fab30752e6114fccd03a1e2ccd00e1e","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-09-03 18:53:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c0a28f424cda6a958d43e419450a40fce7e95c1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 19:41:44.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python26/6494810/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-pep8/2b4d370/ : SUCCESS in 1m 01s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/205306/2/check/gate-python-openstackclient-docs/6dd83e7//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python27/2b504f2/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python34/beaa653/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/205306/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8e8792b/ : SUCCESS in 1h 15m 02s\n- gate-osc-dsvm-functional http://logs.openstack.org/06/205306/2/check/gate-osc-dsvm-functional/3304115/ : FAILURE in 20m 14s","accounts_in_message":[],"_revision_number":2},{"id":"ea6f7f02850e0a91efb46d00eac0903437ab4de7","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-05 05:09:48.000000000","message":"Patch Set 2: Code-Review+2\n\ngate needs to be unwedged","accounts_in_message":[],"_revision_number":2},{"id":"fbb5b9468d10ea7346286e7852cfe89f59491b41","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-08 18:18:24.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"8141f14225fc37d06a25e74d46dcf416a428c98f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-08 18:38:06.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"dd61ba3d2aab78466541dd3096d8b333dec220b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 19:56:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python26/9f98e43/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-pep8/c2eedb2/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/205306/2/check/gate-python-openstackclient-docs/f43ed38//doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python27/a0c44b0/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/205306/2/check/gate-python-openstackclient-python34/1e5d07c/ : SUCCESS in 2m 58s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/205306/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/805d526/ : SUCCESS in 1h 18m 07s\n- gate-osc-dsvm-functional http://logs.openstack.org/06/205306/2/check/gate-osc-dsvm-functional/34221c3/ : SUCCESS in 26m 34s","accounts_in_message":[],"_revision_number":2},{"id":"c4e8d5dd51b32bd84128dce23acb70fa9228065f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 19:56:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"815d9d64c4a82a9891187785e3bef62732eedfb2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 21:18:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/06/205306/2/gate/gate-python-openstackclient-python26/763feb1/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/205306/2/gate/gate-python-openstackclient-docs/d0521a1//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/205306/2/gate/gate-python-openstackclient-pep8/9d37033/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/205306/2/gate/gate-python-openstackclient-python27/7a9bc89/ : SUCCESS in 1m 27s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/205306/2/gate/gate-python-openstackclient-python34/cb3c606/ : SUCCESS in 2m 02s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/205306/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/5833a7c/ : SUCCESS in 1h 21m 35s\n- gate-osc-dsvm-functional http://logs.openstack.org/06/205306/2/gate/gate-osc-dsvm-functional/58ce2b0/ : SUCCESS in 32m 14s","accounts_in_message":[],"_revision_number":2},{"id":"75567f26f103db695d0319455c591410539267d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 21:18:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e6706f252642e52dd9de556b92edb769afa57868","revisions":{"4530c75ed7dda2c86067433b14966a56f9367d0d":{"kind":"REWORK","_number":1,"created":"2015-07-23 21:58:48.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/06/205306/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/06/205306/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/1"}}},"commit":{"parents":[{"commit":"e54a15aabbfa8df04de53dcc53466e683e5f633b","subject":"Merge \"add doc for floatingip\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e54a15aabbfa8df04de53dcc53466e683e5f633b"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-07-23 20:08:52.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-07-23 21:57:26.000000000","tz":-300},"subject":"Properly handle port arguments for ICMP","message":"Properly handle port arguments for ICMP\n\nThe Compute API requires \u0027from_port\u0027 and \u0027to_port\u0027 to be -1 for\nICMP security group rules.  It happily accepts them empty or None\nbut the resulting rules do not work.  So we force the values for\nICMP rules.\n\nCloses-bug: #1477629\nChange-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4530c75ed7dda2c86067433b14966a56f9367d0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4530c75ed7dda2c86067433b14966a56f9367d0d"}]},"branch":"refs/heads/master"},"e6706f252642e52dd9de556b92edb769afa57868":{"kind":"REWORK","_number":2,"created":"2015-09-03 18:06:57.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/06/205306/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/06/205306/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/06/205306/2"}}},"commit":{"parents":[{"commit":"9210cac86a2d5d3df9989f40b1fcc605e5f78ed8","subject":"Merge \"Ignore flavor and image find errors on server show\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9210cac86a2d5d3df9989f40b1fcc605e5f78ed8"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-07-23 20:08:52.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-09-03 18:06:45.000000000","tz":-300},"subject":"Properly handle port arguments for ICMP","message":"Properly handle port arguments for ICMP\n\nThe Compute API requires \u0027from_port\u0027 and \u0027to_port\u0027 to be -1 for\nICMP security group rules.  It happily accepts them empty or None\nbut the resulting rules do not work.  So we force the values for\nICMP rules.\n\nCloses-bug: #1477629\nChange-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e6706f252642e52dd9de556b92edb769afa57868"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e6706f252642e52dd9de556b92edb769afa57868"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}