)]}'
{"functional/tests/identity/v3/test_identity.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"198892780b7e99484eedad1f2410b7201058b210","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                \u0027endpoint delete %s\u0027 % endpoint[\u0027id\u0027])"},{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        username \u003d data_utils.rand_name(\u0027TestUser\u0027)"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0cd758c0","line":259,"updated":"2015-07-30 19:16:51.000000000","message":"Why is this here instead of in test_idp?  If some other test needed to created an idp, it sees like that test should use test_idp","commit_id":"392f0bf3bc3da9146b9ea799c151647aa34d0de9"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8406797fbcbbdb6e40d1bca06bd82e94c3644bbb","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                \u0027endpoint delete %s\u0027 % endpoint[\u0027id\u0027])"},{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        username \u003d data_utils.rand_name(\u0027TestUser\u0027)"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_98815fc6","line":259,"in_reply_to":"3a50d1a3_0cd758c0","updated":"2015-07-30 20:22:24.000000000","message":"this actually matches the structure of the other identity tests, so i\u0027m okay with it.\n\nfor idp_list/set/show, i assume Kelvin will just call _create_dummy_idp()","commit_id":"392f0bf3bc3da9146b9ea799c151647aa34d0de9"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"4b719e25a352660496a67f67d9289168f5cb7d05","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                \u0027endpoint delete %s\u0027 % endpoint[\u0027id\u0027])"},{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        username \u003d data_utils.rand_name(\u0027TestUser\u0027)"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5b5d1147","line":259,"in_reply_to":"3a50d1a3_98815fc6","updated":"2015-07-30 20:51:00.000000000","message":"Fair enough, I didn\u0027t notice.","commit_id":"392f0bf3bc3da9146b9ea799c151647aa34d0de9"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"4b719e25a352660496a67f67d9289168f5cb7d05","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        username \u003d data_utils.rand_name(\u0027TestUser\u0027)"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("},{"line_number":263,"context_line":"            \u0027identity provider create \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_bbb9b57b","line":260,"updated":"2015-07-30 20:51:00.000000000","message":"Is username and TestUser right here?  Seems like it should be name or provider_name","commit_id":"392f0bf3bc3da9146b9ea799c151647aa34d0de9"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"10c550083377d460aa36665a3deb53fff9434a6e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        username \u003d data_utils.rand_name(\u0027TestUser\u0027)"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("},{"line_number":263,"context_line":"            \u0027identity provider create \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e48f6373","line":260,"in_reply_to":"3a50d1a3_bbb9b57b","updated":"2015-07-31 22:57:03.000000000","message":"good catch. this is the identifier for the Identity provider, not a user.","commit_id":"392f0bf3bc3da9146b9ea799c151647aa34d0de9"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"733b672379db1c9b79ac2be1dba7c94c624815a5","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        return endpoint[\u0027id\u0027]"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _create_dummy_idp(self, add_clean_up\u003dTrue):"},{"line_number":260,"context_line":"        identity_provider \u003d \u0027IdentityProvider\u0027"},{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("},{"line_number":263,"context_line":"            \u0027identity provider create \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1e9e5754","line":260,"updated":"2015-08-01 04:27:07.000000000","message":"use the rand_name() function here too :)","commit_id":"83ec404b08f470c410853b369c64155d3be38c38"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"300f77f860073302da55d4020b2abca3f46c3991","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        description \u003d data_utils.rand_name(\u0027description\u0027)"},{"line_number":262,"context_line":"        raw_output \u003d self.openstack("},{"line_number":263,"context_line":"            \u0027identity provider create \u0027"},{"line_number":264,"context_line":"            \u0027 %(name)s \u0027"},{"line_number":265,"context_line":"            \u0027--description %(description)s \u0027"},{"line_number":266,"context_line":"            \u0027--enable \u0027 % {\u0027name\u0027: identity_provider,"},{"line_number":267,"context_line":"                           \u0027description\u0027: description})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_7691b745","line":264,"updated":"2015-08-02 04:50:18.000000000","message":"nit: name should idp","commit_id":"cd98e063eb3bbf5e2e574f61f1062f611707321d"}]}