)]}'
{"functional/tests/volume/v1/test_volume_type.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5a9232358fe9b16612000bc08890ed7b28999e73","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_volume_type_properties(self):"},{"line_number":48,"context_line":"        opts \u003d self.get_show_opts(self.FIELDS)"},{"line_number":49,"context_line":"        raw_output \u003d self.openstack("},{"line_number":50,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd\u0027"},{"line_number":51,"context_line":"            + self.NAME + opts)"},{"line_number":52,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":53,"context_line":"        self.assertOutput(expected, raw_output)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_22546352","line":50,"updated":"2015-07-31 20:23:12.000000000","message":"so close! add a white space before you put the final quote.\n\nas it stands now, it thinks you are missing the NAME argument:\n\nhttp://logs.openstack.org/81/207581/2/check/gate-osc-dsvm-functional/65d5961/console.html#_2015-07-31_13_52_37_517\n\n  Command \u0027openstack volume type create --property a\u003db --property c\u003ddf45e5e61f29c461b81c38a51f12e9147 -f value -c name\u0027","commit_id":"f492caf8e37db016f1b3df18d6b7ee7c92388fdb"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"bbbb3c23d2ebca68749e3ad7056d3f1534caab3a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertEqual(self.NAME + \"\\n\", raw_output)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_volume_type_properties(self):"},{"line_number":48,"context_line":"        opts \u003d self.get_show_opts(self.FIELDS)"},{"line_number":49,"context_line":"        raw_output \u003d self.openstack("},{"line_number":50,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":51,"context_line":"            + self.NAME + opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a4115bb1","line":48,"updated":"2015-07-31 23:10:56.000000000","message":"delete those opts","commit_id":"6a44c425ab8836c01b908d31b6c713ef4aa783b9"},{"author":{"_account_id":16550,"name":"Robert Francis","email":"robefran@ca.ibm.com","username":"robefran"},"change_message_id":"d865e7b1652f6e6b154fc436934a739f6a23a823","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertEqual(self.NAME + \"\\n\", raw_output)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_volume_type_properties(self):"},{"line_number":48,"context_line":"        opts \u003d self.get_show_opts(self.FIELDS)"},{"line_number":49,"context_line":"        raw_output \u003d self.openstack("},{"line_number":50,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":51,"context_line":"            + self.NAME + opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_351de066","line":48,"in_reply_to":"3a50d1a3_a4115bb1","updated":"2015-08-03 15:14:31.000000000","message":"Done","commit_id":"6a44c425ab8836c01b908d31b6c713ef4aa783b9"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"bbbb3c23d2ebca68749e3ad7056d3f1534caab3a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":51,"context_line":"            + self.NAME + opts)"},{"line_number":52,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":53,"context_line":"        self.assertOutput(expected, raw_output)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":56,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_640b537e","line":53,"updated":"2015-07-31 23:10:56.000000000","message":"Add these properties to the create in setUpClass","commit_id":"6a44c425ab8836c01b908d31b6c713ef4aa783b9"},{"author":{"_account_id":16550,"name":"Robert Francis","email":"robefran@ca.ibm.com","username":"robefran"},"change_message_id":"bac9f32d112d881ec17464a275a5b851e575690c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":51,"context_line":"            + self.NAME + opts)"},{"line_number":52,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":53,"context_line":"        self.assertOutput(expected, raw_output)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":56,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_6ac4e791","line":53,"in_reply_to":"3a50d1a3_640b537e","updated":"2015-08-03 14:58:01.000000000","message":"I\u0027m not sure that we want the properties to also be applied in setUpClass() for test_volume_type_list() and test_volume_type_show() ? I was trying to keep the properties specific to test_volume_type_properties()","commit_id":"6a44c425ab8836c01b908d31b6c713ef4aa783b9"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8447b22fb63935ffb3bf3ef3ea18b3378c700fb7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_volume_type_properties(self):"},{"line_number":48,"context_line":"        raw_output \u003d self.openstack("},{"line_number":49,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":50,"context_line":"            + self.NAME)"},{"line_number":51,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":52,"context_line":"        self.assertOutput(expected, raw_output)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_1df32675","line":50,"updated":"2015-08-03 16:51:46.000000000","message":"Well, we aren\u0027t trying to be comprehensive with these tests, so alternatively, skip testing properties on create.  Test \u0027volume set\u0027 insteada.  Either way, setting those properties in create should not hurt the show and list tests.  What we don\u0027t want is another volume type to create and delete.  The fewer commands we can run the better so tests run as quickly as possible.","commit_id":"50b5af5b356eaffb55b6750ffd30b553ff3d674a"},{"author":{"_account_id":16550,"name":"Robert Francis","email":"robefran@ca.ibm.com","username":"robefran"},"change_message_id":"804d7f6d471528908ead78cfac7dc7011b4bc0c8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_volume_type_properties(self):"},{"line_number":48,"context_line":"        raw_output \u003d self.openstack("},{"line_number":49,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":50,"context_line":"            + self.NAME)"},{"line_number":51,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":52,"context_line":"        self.assertOutput(expected, raw_output)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_023f0cd7","line":50,"in_reply_to":"1a4dcd0f_1df32675","updated":"2015-08-04 14:58:23.000000000","message":"Done\n\nUse volume type set to add first properties.","commit_id":"50b5af5b356eaffb55b6750ffd30b553ff3d674a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"1415038431eaf89a110d24ff6045eeec7480cd40","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_volume_type_create_and_delete_with_properties(self):"},{"line_number":59,"context_line":"        raw_output \u003d self.openstack("},{"line_number":60,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":61,"context_line":"            + self.NAME)"},{"line_number":62,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":63,"context_line":"        self.assertOutput(expected, raw_output)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_c13b59d0","line":60,"updated":"2015-08-04 17:23:07.000000000","message":"s/create/set","commit_id":"201a155ac4ac5424c02e85b8cd2c650d0cb648fd"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"1415038431eaf89a110d24ff6045eeec7480cd40","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \u0027volume type create --property a\u003db --property c\u003dd \u0027"},{"line_number":61,"context_line":"            + self.NAME)"},{"line_number":62,"context_line":"        expected \u003d self.NAME + \u0027\\n\u0027"},{"line_number":63,"context_line":"        self.assertOutput(expected, raw_output)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":66,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_c142793e","line":63,"updated":"2015-08-04 17:23:07.000000000","message":"s/assertOutput/assertEqual  also expected is probably an empty string","commit_id":"201a155ac4ac5424c02e85b8cd2c650d0cb648fd"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"000e94ae46ee54a4c445cfaf59a242e1fc5a635c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":64,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"},{"line_number":65,"context_line":"        self.assertEqual(\"a\u003d\u0027b\u0027, c\u003d\u0027d\u0027\\n\", raw_output)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        raw_output \u003d self.openstack(\u0027volume type unset --property a \u0027"},{"line_number":68,"context_line":"                                    + self.NAME)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_c2e82d7f","line":65,"updated":"2015-08-04 22:29:18.000000000","message":"bah, looks like it\u0027s picking up the other property set in test_volume_set_one_property. the failure message is:\n\n  \"a\u003d\u0027b\u0027, c\u003d\u0027d\u0027\\n\" !\u003d \"a\u003d\u0027b\u0027, c\u003d\u0027d\u0027, foo\u003d\u0027bar\u0027\\n\"\n\nlet me think on how we want to proceed... maybe have this test simply try and set 2 properties... i\u0027m not sure","commit_id":"51d06c6f05957c521a3aa10eee4f0367a821adb5"},{"author":{"_account_id":16550,"name":"Robert Francis","email":"robefran@ca.ibm.com","username":"robefran"},"change_message_id":"f49837cb74ba1606b164b26dd06e4f88797aac48","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":64,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"},{"line_number":65,"context_line":"        self.assertEqual(\"a\u003d\u0027b\u0027, c\u003d\u0027d\u0027\\n\", raw_output)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        raw_output \u003d self.openstack(\u0027volume type unset --property a \u0027"},{"line_number":68,"context_line":"                                    + self.NAME)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_f573857e","line":65,"in_reply_to":"1a4dcd0f_bd58a0fb","updated":"2015-08-05 11:28:04.000000000","message":"Done","commit_id":"51d06c6f05957c521a3aa10eee4f0367a821adb5"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"4058b4a99daaa17f2d094263af1f2a5690276082","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        opts \u003d self.get_show_opts([\"properties\"])"},{"line_number":64,"context_line":"        raw_output \u003d self.openstack(\u0027volume type show \u0027 + self.NAME + opts)"},{"line_number":65,"context_line":"        self.assertEqual(\"a\u003d\u0027b\u0027, c\u003d\u0027d\u0027\\n\", raw_output)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        raw_output \u003d self.openstack(\u0027volume type unset --property a \u0027"},{"line_number":68,"context_line":"                                    + self.NAME)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_bd58a0fb","line":65,"in_reply_to":"1a4dcd0f_c2e82d7f","updated":"2015-08-04 22:46:30.000000000","message":"That makes sense, why not just combine the two tests?\n* set\n* show\n* unset\n* show","commit_id":"51d06c6f05957c521a3aa10eee4f0367a821adb5"}]}