)]}'
{"id":"openstack%2Fpython-openstackclient~20827","triplet_id":"openstack%2Fpython-openstackclient~master~Iefbfbcfd35270b06ed65edb34708fa9b4d5bf563","project":"openstack/python-openstackclient","branch":"master","topic":"unit_tests","hashtags":[],"change_id":"Iefbfbcfd35270b06ed65edb34708fa9b4d5bf563","subject":"Clean up test_shell so that the tests are captured though the test framework.","status":"MERGED","created":"2013-01-30 19:57:38.000000000","updated":"2013-01-31 03:52:30.000000000","submitted":"2013-01-31 03:52:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2af885928a524961e45898f386d25dd17595a8e9","_number":20827,"virtual_id_number":20827,"owner":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2013-01-31 03:52:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"all":[{"value":0,"date":"2013-01-30 23:54:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-01-30 21:51:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},{"value":2,"date":"2013-01-31 03:49:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"date":"2013-01-30 23:54:49.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-30 21:51:53.000000000","_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},{"value":1,"date":"2013-01-31 03:49:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-30 21:51:53.000000000","updated_by":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"reviewer":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"state":"REVIEWER"},{"updated":"2013-01-31 03:49:45.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-01-31 03:52:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f5aa8809cfd254fc438662187f8e676f59047e66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 20:00:31.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20827/1/check/gate-python-openstackclient-docs/113 : SUCCESS\n- http://logs.openstack.org/20827/1/check/gate-python-openstackclient-pep8/182 : SUCCESS\n- http://logs.openstack.org/20827/1/check/gate-python-openstackclient-python26/181 : SUCCESS\n- http://logs.openstack.org/20827/1/check/gate-python-openstackclient-python27/185 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"45f164f9328b4f89375e39912e3198a4d69ecca9","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-30 20:02:01.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"356aef54811e36839b1d4fec00136c9e43317a0d","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-30 20:02:54.000000000","message":"Patch Set 1:\n\nOops, those weren\u0027t supposed to make it in. Uploading fix.","accounts_in_message":[],"_revision_number":1},{"id":"71a85aee6b29850063c3e444fb8ef591c3d87584","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-30 20:05:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"859c3c515397de23f6fa2f0e563ad804123852bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 20:08:50.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20827/2/check/gate-python-openstackclient-docs/114 : SUCCESS\n- http://logs.openstack.org/20827/2/check/gate-python-openstackclient-pep8/183 : SUCCESS\n- http://logs.openstack.org/20827/2/check/gate-python-openstackclient-python26/182 : SUCCESS\n- http://logs.openstack.org/20827/2/check/gate-python-openstackclient-python27/186 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"273f0e6202518bf9f04537be2c498006cfb977ba","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-30 20:59:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"99fcd4270083f57dc6045fcd83364e1c7b4e2a4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 21:02:50.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20827/3/check/gate-python-openstackclient-docs/115 : SUCCESS\n- http://logs.openstack.org/20827/3/check/gate-python-openstackclient-pep8/184 : SUCCESS\n- http://logs.openstack.org/20827/3/check/gate-python-openstackclient-python26/183 : SUCCESS\n- http://logs.openstack.org/20827/3/check/gate-python-openstackclient-python27/187 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"fe5ffe94cee41e35c824c3be5b9a6b978dc934e3","author":{"_account_id":1699,"name":"Matt Joyce","email":"mjoyce@hp.com","username":"matt-nycresistor"},"date":"2013-01-30 21:51:53.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nI can\u0027t even seem to execute run_tests.sh on devstack atm.  Not sure what is hosing me up.\n\nThis all looks fine to me though but I\u0027d rather someone else approve if they can get it to run.\n\n-Matt\n\nErrors seen with and without this patchset:\n\n\nroot@devstack:/opt/stack/python-openstackclient# ./run_tests.sh \nNo virtual environment found...create one? (Y/n) y\nTraceback (most recent call last):\n  File \"tools/install_venv.py\", line 23, in \u003cmodule\u003e\n    import install_venv_common as install_venv\n  File \"/opt/stack/python-openstackclient/tools/install_venv_common.py\", line 28, in \u003cmodule\u003e\n    from openstackclient.openstack.common import cfg\nImportError: cannot import name cfg\nroot@devstack:/opt/stack/python-openstackclient# ./run_tests.sh \nNo virtual environment found...create one? (Y/n) n\n./run_tests.sh: line 67: testr: command not found","accounts_in_message":[],"_revision_number":3},{"id":"79672b275b3ccdd4a1bdf12f8ae3fb54af98eaa4","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-30 23:54:49.000000000","message":"Patch Set 3:\n\nLooks like an import issue caused by the Oslo sync. I will look into that.\n\nThe tests will pass if they have an existing venv to run in.","accounts_in_message":[],"_revision_number":3},{"id":"249a4da0459f0ba034f7f6091abdb6241ef769a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-31 03:49:45.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"3418688dff468a107e20c973e248539b3f0bf7ed","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-01-31 03:49:45.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nI just pushed up https://review.openstack.org/20871 for the oslo bits.  With that in place venv creation works again.","accounts_in_message":[],"_revision_number":3},{"id":"cbb11db7b9caf7130ff49f93c1520af03ff1a178","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-31 03:52:30.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20827/3/gate/gate-python-openstackclient-docs/118 : SUCCESS\n- http://logs.openstack.org/20827/3/gate/gate-python-openstackclient-pep8/187 : SUCCESS\n- http://logs.openstack.org/20827/3/gate/gate-python-openstackclient-python26/186 : SUCCESS\n- http://logs.openstack.org/20827/3/gate/gate-python-openstackclient-python27/190 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"bb1d424f3b549ce3e586052c9168787722ba3c21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-31 03:52:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"17a87b9c0270053fc3ecfaade6606d135894e51c","revisions":{"92349647cc9145ea90fa06eee6f6951e2892eebc":{"kind":"REWORK","_number":1,"created":"2013-01-30 19:57:38.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/27/20827/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/27/20827/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/1"}}},"commit":{"parents":[{"commit":"26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb","subject":"Merge \"Remove old/unsupported options from run_tests help message.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 19:56:12.000000000","tz":-360},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 19:56:12.000000000","tz":-360},"subject":"Clean up test_shell so that the tests are captured though the test framework.","message":"Clean up test_shell so that the tests are captured though the test framework.\n\nAlso makes a small modification to gitignore.\n\nChange-Id: Iefbfbcfd35270b06ed65edb34708fa9b4d5bf563\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/92349647cc9145ea90fa06eee6f6951e2892eebc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/92349647cc9145ea90fa06eee6f6951e2892eebc"}]},"branch":"refs/heads/master"},"3aced796ceb8e591c89a5ca7aed56137c43a3121":{"kind":"REWORK","_number":2,"created":"2013-01-30 20:05:52.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/27/20827/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/27/20827/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/2"}}},"commit":{"parents":[{"commit":"26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb","subject":"Merge \"Remove old/unsupported options from run_tests help message.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 19:56:12.000000000","tz":-360},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 20:05:43.000000000","tz":-360},"subject":"Clean up test_shell so that the tests are captured though the test framework.","message":"Clean up test_shell so that the tests are captured though the test framework.\n\nAlso makes a small modification to gitignore.\n\nChange-Id: Iefbfbcfd35270b06ed65edb34708fa9b4d5bf563\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3aced796ceb8e591c89a5ca7aed56137c43a3121"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3aced796ceb8e591c89a5ca7aed56137c43a3121"}]},"branch":"refs/heads/master"},"17a87b9c0270053fc3ecfaade6606d135894e51c":{"kind":"REWORK","_number":3,"created":"2013-01-30 20:59:44.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/27/20827/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/27/20827/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/27/20827/3"}}},"commit":{"parents":[{"commit":"26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb","subject":"Merge \"Remove old/unsupported options from run_tests help message.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/26fcc303b29e5fdfc09baa363ba2ac4a5f77c7eb"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 19:56:12.000000000","tz":-360},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2013-01-30 20:59:29.000000000","tz":-360},"subject":"Clean up test_shell so that the tests are captured though the test framework.","message":"Clean up test_shell so that the tests are captured though the test framework.\n\nAlso makes a small modification to gitignore.\n\nChange-Id: Iefbfbcfd35270b06ed65edb34708fa9b4d5bf563\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/17a87b9c0270053fc3ecfaade6606d135894e51c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/17a87b9c0270053fc3ecfaade6606d135894e51c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}