)]}'
{"id":"openstack%2Fpython-openstackclient~214360","triplet_id":"openstack%2Fpython-openstackclient~master~I9f67b9758b7ff454b59ed3bf3137e0b2c49c6415","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1485694","hashtags":[],"change_id":"I9f67b9758b7ff454b59ed3bf3137e0b2c49c6415","subject":"Check command line arguments for UTF-8","status":"ABANDONED","created":"2015-08-18 21:30:28.000000000","updated":"2016-09-07 22:34:03.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ecc8b42ab4c2d1bdfc82ab8b8e8850e7c63e5419","_number":214360,"virtual_id_number":214360,"owner":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-08-19 16:35:29.000000000","_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":-1,"date":"2015-09-08 20:49:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-08-20 05:41:58.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-20 05:41:58.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2015-09-08 20:49:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0d4cfc345482f392c454e6b99c6b944833b46c3e","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-08-18 21:30:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e795d07ef43c9d4bbb0c7d2af186fb4656a832bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 22:45:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/60/214360/1/check/gate-python-openstackclient-python26/a517c75/ : SUCCESS in 1m 49s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/60/214360/1/check/gate-python-openstackclient-pep8/904a05e/ : SUCCESS in 1m 39s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/60/214360/1/check/gate-python-openstackclient-docs/78c8637//doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-python27 http://logs.openstack.org/60/214360/1/check/gate-python-openstackclient-python27/0a01dd8/ : SUCCESS in 2m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/60/214360/1/check/gate-python-openstackclient-python34/40089eb/ : FAILURE in 2m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/60/214360/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fafa4ce/ : SUCCESS in 1h 11m 54s\n- gate-osc-dsvm-functional http://logs.openstack.org/60/214360/1/check/gate-osc-dsvm-functional/0394e12/ : SUCCESS in 28m 42s","accounts_in_message":[],"_revision_number":1},{"id":"733877ad4088241663b9e2bb6f9abd3769b733aa","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-08-18 22:57:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f355ec67c78a3c8f54886c4021bc733d173dfc85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 00:15:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/60/214360/2/check/gate-python-openstackclient-python26/9808b0b/ : SUCCESS in 1m 59s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/60/214360/2/check/gate-python-openstackclient-pep8/21d0664/ : SUCCESS in 2m 03s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/60/214360/2/check/gate-python-openstackclient-docs/ac363f7//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-openstackclient-python27 http://logs.openstack.org/60/214360/2/check/gate-python-openstackclient-python27/e4b6781/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/60/214360/2/check/gate-python-openstackclient-python34/b40d62a/ : SUCCESS in 2m 29s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/60/214360/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/5c9c640/ : SUCCESS in 1h 15m 24s\n- gate-osc-dsvm-functional http://logs.openstack.org/60/214360/2/check/gate-osc-dsvm-functional/48c1f93/ : SUCCESS in 26m 42s","accounts_in_message":[],"_revision_number":2},{"id":"ac4de79656a2ce14eee27f0a009f05ab75254146","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-08-19 11:18:37.000000000","message":"Patch Set 2: Code-Review-2\n\n* I find it real strange that before OSC does *anything* it is going to validate data for keystone.\n* OSC is going to look at all the arguments, not just the ones that are supposed to be names/ids.\n* I\u0027m concerned that basicConfig on the logger might mess up  the actual desired logging we configure later.  That basicConfig in the exception was supposed to be if all else fails.","accounts_in_message":[],"_revision_number":2},{"id":"d13b8835241d180399fee7511d21ca26ad920b35","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-08-19 16:35:29.000000000","message":"Patch Set 2:\n\n\u003e\u003e    I find it real strange that before OSC does *anything* it is going to validate data for keystone.\n\nThis came up in our testing. If you paste in using an incorrectly configured Putty the wrong data is sent to the server. This is not JUST keystone this is any service. URL params are supposed to be UTF8 encoded and OSC is not honoring its end of the contract. Those curl examples are straight out of OSC --verbose\n\n   \n\u003e\u003e    I\u0027m concerned that basicConfig on the logger might mess up the actual desired logging we configure later. That basicConfig in the exception was supposed to be if all else fails.\n\nThis is a fair concern. I am open to whatever the right thing is.","accounts_in_message":[],"_revision_number":2},{"id":"f186591ae08be841e0ab2d4ea7c002ad356ab79d","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-08-19 17:14:45.000000000","message":"Patch Set 2:\n\nIt is a bit of garbage in, garbage out, but a little less of a heavy handed approach may be to put something in\n\n https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/utils.py#L29\n\nMost services use that as I recall.","accounts_in_message":[],"_revision_number":2},{"id":"628d3f776289944d4da4d472aa1fa8db2b6b1f25","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-08-19 17:37:49.000000000","message":"Patch Set 2:\n\nThis is command line argument validation so yeah I did it early and heavy.\n\nI will look at the routine you referenced and see if it makes as much sense.","accounts_in_message":[],"_revision_number":2},{"id":"2d3df2a551f6c811dbcc96f062d4bb563bc56262","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2015-08-20 05:41:58.000000000","message":"Patch Set 2:\n\nI think either we do it here\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/session.py#L38\n\nor here\n\nhttps://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L239\n\nThe expectation is that all OpenStack service will be using keystoneauth for authentication and session management. In other words, keystoneauth is the lowest denominator. So best place to make the change would be keystoneauth.\n\nBut since not all services had migrated over to keystoneauth, we may need to make the changes here as well.\n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/session.py#L212","accounts_in_message":[],"_revision_number":2},{"id":"2e2e784bc39ac5ff7f06aebeea1c6228023e2d14","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 20:49:06.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"d858a4765e98470f649f652521f0d7586f9bed44","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2016-06-02 03:47:32.000000000","message":"Removed the following votes:\n\n* Code-Review-2 by Terry Howe \u003cterrylhowe@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"11761752d1dfca34a060b9f7309537f5e5082d62","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2016-09-07 22:34:03.000000000","message":"Abandoned\n\nUnwanted.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5915e520f14f480ea71ca99910f0a824c069d1b9","revisions":{"9cc382e673291cf53d1130d49b083b1c6a2cb91a":{"kind":"REWORK","_number":1,"created":"2015-08-18 21:30:28.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/60/214360/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/60/214360/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/1"}}},"commit":{"parents":[{"commit":"ac5e289476911d8db13fce8411a062814a069d4b","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ac5e289476911d8db13fce8411a062814a069d4b"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-08-18 21:25:54.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-08-18 21:25:54.000000000","tz":-420},"subject":"Check command line arguments for UTF-8","message":"Check command line arguments for UTF-8\n\nURL parameters should be UTF-8 encoded. Verify that the input from the user\ncan be properly encoded.\n\nChange-Id: I9f67b9758b7ff454b59ed3bf3137e0b2c49c6415\nRelated-Bug: 1485694\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9cc382e673291cf53d1130d49b083b1c6a2cb91a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9cc382e673291cf53d1130d49b083b1c6a2cb91a"}]},"branch":"refs/heads/master"},"5915e520f14f480ea71ca99910f0a824c069d1b9":{"kind":"REWORK","_number":2,"created":"2015-08-18 22:57:01.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/60/214360/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/60/214360/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/60/214360/2"}}},"commit":{"parents":[{"commit":"ac5e289476911d8db13fce8411a062814a069d4b","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ac5e289476911d8db13fce8411a062814a069d4b"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-08-18 21:25:54.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-08-18 22:56:48.000000000","tz":-420},"subject":"Check command line arguments for UTF-8","message":"Check command line arguments for UTF-8\n\nURL parameters should be UTF-8 encoded. Verify that the input from the user\ncan be properly encoded.\n\nChange-Id: I9f67b9758b7ff454b59ed3bf3137e0b2c49c6415\nRelated-Bug: 1485694\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5915e520f14f480ea71ca99910f0a824c069d1b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5915e520f14f480ea71ca99910f0a824c069d1b9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}