)]}'
{"doc/source/command-objects/network.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"abf56988ec9aee7b2c845f5365ef689b447069a8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Do not share the network between projects"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --qos-policy"},{"line_number":48,"context_line":"    Attach Qos policy ID to the network"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. _network_create-name:"},{"line_number":51,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_6bebcedc","line":48,"updated":"2015-09-05 05:06:20.000000000","message":"slight change here:\n\n  Attach QoS policy to the network (ID only)\n\nor\n\n  Attach QoS policy to the network (name or ID)\n\ndepending on if you can specify policy by name or ID, i\u0027m not familiar with that API","commit_id":"5acbc083ab336e784f6d8e67bb1136aaa1b5dbb3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5e2bcfb3726442cb94afef57d90b48dd0109a2bf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Do not share the network between projects"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --qos-policy"},{"line_number":48,"context_line":"    Attach Qos policy ID to the network"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. _network_create-name:"},{"line_number":51,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_e350f40c","line":48,"in_reply_to":"da20952f_6bebcedc","updated":"2015-09-09 07:55:47.000000000","message":"python neutron client lets you do both.\n\nWe also need\n\n--no-qos-policy\n\nto detach a policy from network.","commit_id":"5acbc083ab336e784f6d8e67bb1136aaa1b5dbb3"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"62ba3316ce7f38125c700effafbdfd780c636c06","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                parsed_args.project_domain,"},{"line_number":121,"context_line":"            ).id"},{"line_number":122,"context_line":"            body[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":123,"context_line":"        if parsed_args.qos_policy is not None:"},{"line_number":124,"context_line":"            body[\u0027qos_policy_id\u0027] \u003d parsed_args.qos_policy"},{"line_number":125,"context_line":"        return {\u0027network\u0027: body}"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_1999be6e","line":123,"updated":"2015-09-02 20:03:25.000000000","message":"It is standard to do a name-\u003eid translation.  That would be done something like:\n\n    _id \u003d common.find(client, \u0027qos_policy\u0027, \u0027qos_policies\u0027, parsed_args.qos_policy)","commit_id":"4a212064c58709a3ebae07ad67c5169a013116a2"},{"author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"change_message_id":"197589ca7ef7a6a3a6e2dd78fe26a29f4b91dc4b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                parsed_args.project_domain,"},{"line_number":121,"context_line":"            ).id"},{"line_number":122,"context_line":"            body[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":123,"context_line":"        if parsed_args.qos_policy is not None:"},{"line_number":124,"context_line":"            body[\u0027qos_policy_id\u0027] \u003d parsed_args.qos_policy"},{"line_number":125,"context_line":"        return {\u0027network\u0027: body}"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_be43cf12","line":123,"in_reply_to":"da20952f_1999be6e","updated":"2015-09-02 23:23:39.000000000","message":"It doesn\u0027t work.\n\nResponse for list_qos_polices returns: \n{\"policies\": [{\"id\": \"7bc83911-8282-457b-81c3-388afe748bff\"}]}\n\nand in common.find; we do a lookup info \u003d data[resources]; which results in a KeyError.\n\nWe will have to change common.find and add another argument to lookup the resources. I can do that in a separate patch.","commit_id":"4a212064c58709a3ebae07ad67c5169a013116a2"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"df0b79f63840953aa743ac0c58fa39fe3e03280b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--qos-policy\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":61,"context_line":"            help\u003d\"Attach Qos policy ID to the network\""},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":64,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b190dd4f","line":61,"updated":"2015-09-03 02:26:33.000000000","message":"use single quote for consistency.\n\nIt would be nice if we support accepting QOS policy name  or ID.","commit_id":"50496edf0acbb54c5aed7d56fab9498c8c2dc088"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"abf56988ec9aee7b2c845f5365ef689b447069a8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--qos-policy\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":61,"context_line":"            help\u003d\"Attach Qos policy ID to the network\""},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":64,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_2bc0764f","line":61,"updated":"2015-09-05 05:06:20.000000000","message":"update here too","commit_id":"5acbc083ab336e784f6d8e67bb1136aaa1b5dbb3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5e2bcfb3726442cb94afef57d90b48dd0109a2bf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027--qos-policy\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":61,"context_line":"            help\u003d\"Attach Qos policy ID to the network\""},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":64,"context_line":"        admin_group.add_argument("},{"line_number":65,"context_line":"            \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_4340c035","line":62,"updated":"2015-09-09 07:55:47.000000000","message":"add --no-qos-policy (we would set policy to None...)","commit_id":"5acbc083ab336e784f6d8e67bb1136aaa1b5dbb3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"abf56988ec9aee7b2c845f5365ef689b447069a8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                parsed_args.project_domain,"},{"line_number":121,"context_line":"            ).id"},{"line_number":122,"context_line":"            body[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":123,"context_line":"        if parsed_args.qos_policy is not None:"},{"line_number":124,"context_line":"            body[\u0027qos_policy_id\u0027] \u003d parsed_args.qos_policy"},{"line_number":125,"context_line":"        return {\u0027network\u0027: body}"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_8b96624a","line":123,"updated":"2015-09-05 05:06:20.000000000","message":"if you can specify by name (which it looks like you can) then you will need to find it by calling neutronclient and getting the ID back\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/qos/policy.py#L92-L95","commit_id":"5acbc083ab336e784f6d8e67bb1136aaa1b5dbb3"}],"openstackclient/tests/network/v2/test_network.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"6c955594f88541857f4b5af5e885133a883acf53","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \"--share\","},{"line_number":92,"context_line":"            \"--project\", identity_fakes_v3.project_name,"},{"line_number":93,"context_line":"            \"--project-domain\", identity_fakes_v3.domain_name,"},{"line_number":94,"context_line":"            \"--qos-policy\", FAKE_NAME,"},{"line_number":95,"context_line":"            FAKE_NAME,"},{"line_number":96,"context_line":"        ]"},{"line_number":97,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f5243cc7","line":94,"updated":"2015-09-02 01:14:09.000000000","message":"Could you just add a FAKE_POLICY that is different from the name?","commit_id":"0a0adf537166c77dc40855d7ad61a1108324ec34"},{"author":{"_account_id":13664,"name":"Amey Bhide","email":"abhide@vmware.com","username":"abhide"},"change_message_id":"7c64a67eaa5a52df1df52a63c1299935a0ea7c79","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \"--share\","},{"line_number":92,"context_line":"            \"--project\", identity_fakes_v3.project_name,"},{"line_number":93,"context_line":"            \"--project-domain\", identity_fakes_v3.domain_name,"},{"line_number":94,"context_line":"            \"--qos-policy\", FAKE_NAME,"},{"line_number":95,"context_line":"            FAKE_NAME,"},{"line_number":96,"context_line":"        ]"},{"line_number":97,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_40bc1b6c","line":94,"in_reply_to":"da20952f_f5243cc7","updated":"2015-09-02 18:47:23.000000000","message":"Done","commit_id":"0a0adf537166c77dc40855d7ad61a1108324ec34"}]}