)]}'
{"id":"openstack%2Fpython-openstackclient~219511","triplet_id":"openstack%2Fpython-openstackclient~master~Icc63bced7347c8bbf0299a4c5821425a10892a79","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"Icc63bced7347c8bbf0299a4c5821425a10892a79","subject":"Use a common decorator to log \u0027take_action\u0027 activation","status":"MERGED","created":"2015-09-01 23:52:03.000000000","updated":"2015-09-11 02:43:55.000000000","submitted":"2015-09-11 02:43:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7530cfdbd255ac642619910c527af795fd27a221","_number":219511,"virtual_id_number":219511,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-09-02 15:52:24.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"date":"2015-09-02 16:03:12.000000000","_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-09-11 02:43:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-09-05 01:54:44.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-10 16:51:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-09-10 16:51:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-02 15:52:24.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-09-05 01:54:44.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-09-10 16:51:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-09-11 02:43:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2f2aca9e625a65d2c537b966736b1605b032f72e","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-09-01 23:52:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82607dc989f0e8a9a083c5b87db616a99ae65d30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 01:01:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python26/b5a8111/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-pep8/a7417a5/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/11/219511/1/check/gate-python-openstackclient-docs/1b1a103//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python27 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python27/e19f4b2/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-python34 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python34/fc153be/ : SUCCESS in 1m 37s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/11/219511/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/6784da9/ : SUCCESS in 1h 09m 19s\n- gate-osc-dsvm-functional http://logs.openstack.org/11/219511/1/check/gate-osc-dsvm-functional/15ac57a/ : SUCCESS in 21m 34s","accounts_in_message":[],"_revision_number":1},{"id":"61672dab929677f32331dfb0be7ac5bb8c025037","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-09-02 15:52:24.000000000","message":"Patch Set 1:\n\nThis all looks good to me, but I\u0027m not sure how Dean will react here since he is often a fan of composition.","accounts_in_message":[],"_revision_number":1},{"id":"b2c39c0d360915f5fb396074941a349d0c71e348","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-09-02 16:03:12.000000000","message":"Patch Set 1:\n\nUnsure what composition has to do here, this is basically just replacing a lot of the same log call that looks copy/pasted around (which IMHO is fragile to have duplicated)  with a single decorator that removes that fragility and delegates said logging to it instead.","accounts_in_message":[],"_revision_number":1},{"id":"9c7c2db4dfea8eeb59cf69f30ca9e718b0e7c6ef","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-05 01:54:44.000000000","message":"Patch Set 1: Code-Review+2\n\ni think this will be copy-n-pasted around the same amount as the current code, but it\u0027s less fragile, so i like it","accounts_in_message":[],"_revision_number":1},{"id":"b5a8a569516cef67f06822881d59950c9cf85fd7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-10 16:51:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nTerry is close, I\u0027m not a fan of normalizing for normalization\u0027s sake.  We copy a lot of code, partially to keep from breaking things in far-away places, particularly with multiple versions in play.  (See the incompatible change to find_resource() being proposed).\n\nI don\u0027t see this being a problem in that way though, the cleaner log output is worth the tradeoff and it should not affect existing plugins.  For them to use it, though, we need to treat this as a public interface, which we have not really formalized yet.","accounts_in_message":[],"_revision_number":1},{"id":"8b0c6e7df91dc67ab00da0f14b19baec4e5b37c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 16:51:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"567fb03ffc5ed96bfdc240c0de165e3fb92f5c71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 18:11:32.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python26/a3b089f/ : SUCCESS in 2m 59s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/11/219511/1/gate/gate-python-openstackclient-docs/2547992//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-pep8/53eb7c4/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-python27 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python27/b4366a5/ : SUCCESS in 5m 07s\n- gate-python-openstackclient-python34 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python34/00952c4/ : SUCCESS in 3m 08s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/11/219511/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/e7de26c/ : SUCCESS in 1h 04m 47s\n- gate-osc-dsvm-functional http://logs.openstack.org/11/219511/1/gate/gate-osc-dsvm-functional/a36e11d/ : FAILURE in 20m 33s","accounts_in_message":[],"_revision_number":1},{"id":"4feac39c635eecc36f08fe382729264bf29529f8","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-09-10 22:41:24.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e1c4b9db08e34092ee8333b105eacb8a54781936","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 01:26:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python26/0d942ed/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-pep8/c951d05/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/11/219511/1/check/gate-python-openstackclient-docs/10e58a6//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python27/d199538/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/11/219511/1/check/gate-python-openstackclient-python34/1b157b4/ : SUCCESS in 2m 07s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/11/219511/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/caa07ad/ : SUCCESS in 1h 23m 19s\n- gate-osc-dsvm-functional http://logs.openstack.org/11/219511/1/check/gate-osc-dsvm-functional/f77468d/ : SUCCESS in 31m 01s","accounts_in_message":[],"_revision_number":1},{"id":"b403e1ff0ecd6c4561c47bae150097dc7a6b5776","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 01:26:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"24febcca13d80bf1c1fde83d05c4ac13586fcd46","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 02:43:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python26/b577362/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/11/219511/1/gate/gate-python-openstackclient-docs/4d82f12//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-pep8/e7eac79/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-python27 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python27/0c8e395/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-python34 http://logs.openstack.org/11/219511/1/gate/gate-python-openstackclient-python34/76cc53f/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/11/219511/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/c55411f/ : SUCCESS in 1h 14m 22s\n- gate-osc-dsvm-functional http://logs.openstack.org/11/219511/1/gate/gate-osc-dsvm-functional/8ce5d0f/ : SUCCESS in 29m 18s","accounts_in_message":[],"_revision_number":1},{"id":"7530cfdbd255ac642619910c527af795fd27a221","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 02:43:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3c46ece4a496584a54b9d39b55921990db4a7b3","revisions":{"e3c46ece4a496584a54b9d39b55921990db4a7b3":{"kind":"REWORK","_number":1,"created":"2015-09-01 23:52:03.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/11/219511/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/11/219511/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/11/219511/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/11/219511/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/11/219511/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/11/219511/1"}}},"commit":{"parents":[{"commit":"f14251669f96d6010581702417828f4380144aa2","subject":"default OS_VOLUME_API_VERSION to v2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f14251669f96d6010581702417828f4380144aa2"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-09-01 23:43:07.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-09-01 23:49:54.000000000","tz":-420},"subject":"Use a common decorator to log \u0027take_action\u0027 activation","message":"Use a common decorator to log \u0027take_action\u0027 activation\n\nInstead of duplicating the same log statement throughout\nthe code, the same logic can be provided by a shared decorator\nthat abstracts away the logging capability and unifies it behind\na common function instead.\n\nChange-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e3c46ece4a496584a54b9d39b55921990db4a7b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e3c46ece4a496584a54b9d39b55921990db4a7b3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}