)]}'
{"id":"openstack%2Fpython-openstackclient~220678","triplet_id":"openstack%2Fpython-openstackclient~master~I4535b38a5639a03a9597bf83f6394f9bb45c2b9e","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1492467","hashtags":[],"change_id":"I4535b38a5639a03a9597bf83f6394f9bb45c2b9e","subject":"Fix compute API version snafu","status":"MERGED","created":"2015-09-04 21:33:22.000000000","updated":"2015-09-08 17:56:21.000000000","submitted":"2015-09-08 17:54:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"37da2350764bab27e63cbd21263f344cd18ffe95","_number":220678,"virtual_id_number":220678,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-09-08 14:18:34.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"date":"2015-09-06 05:56:13.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-09-08 17:54:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-08 17:56:21.000000000","post_submit":true,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-09-04 21:34:56.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-09-08 16:08:38.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2015-09-08 16:32:25.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-09-08 16:32:25.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-06 05:56:13.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-09-08 14:18:34.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-09-08 17:54:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-08 17:56:21.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"}],"messages":[{"id":"2152be3e17d7e4da8f6341f54d102c2bec63f837","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-04 21:33:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"acfe4560e829f756f6298522ef1f678d0ace08b7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-04 21:34:56.000000000","message":"Patch Set 1:\n\nThis should fix the functional test issue with \u0027keypair create\u0027 using API v2.2 when it shouldn\u0027t.  It is also not a complete API version discovery implementation for Compute as it doesn\u0027t actually do discovery, it just initializes the api_version argument if it is accepted.","accounts_in_message":[],"_revision_number":1},{"id":"fbf0c9c04b5c35066424f8466c5611e7c9283f83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-04 23:02:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python26/326dc0d/ : SUCCESS in 1m 43s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-pep8/64152f0/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/220678/1/check/gate-python-openstackclient-docs/67cf776//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python27/79b54f1/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python34/b29906b/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/78/220678/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/6d630c2/ : SUCCESS in 1h 22m 37s\n- gate-osc-dsvm-functional http://logs.openstack.org/78/220678/1/check/gate-osc-dsvm-functional/1d784fb/ : FAILURE in 27m 05s","accounts_in_message":[],"_revision_number":1},{"id":"9020f9bd60accac4b53f20391dbc3286a9c8432d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-06 05:56:13.000000000","message":"Patch Set 1:\n\nthis looks okay, just not sure why the functional tests are failing","accounts_in_message":[],"_revision_number":1},{"id":"f8140577b2c89c38098fce02dba3bbf90a4a1bd1","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-09-08 14:18:34.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"1a6e8ac0804f373eb682c93cf7d52492e456a44d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 15:21:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python26/268162d/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-pep8/ca27781/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/220678/1/check/gate-python-openstackclient-docs/999fcf9//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python27/f55c27f/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/78/220678/1/check/gate-python-openstackclient-python34/a783f94/ : SUCCESS in 2m 25s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/78/220678/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0b2ce6e/ : SUCCESS in 1h 02m 22s\n- gate-osc-dsvm-functional http://logs.openstack.org/78/220678/1/check/gate-osc-dsvm-functional/4e69e76/ : SUCCESS in 30m 58s","accounts_in_message":[],"_revision_number":1},{"id":"283c2afca45cd272c35aefcec3df23684cb99d6f","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-09-08 16:08:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1a427cc35bc2f1cb2eb97226be969e547651c072","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-09-08 16:32:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nFast merging to unwedge us","accounts_in_message":[],"_revision_number":1},{"id":"49dc098ccc843ba42fbadefd4dd3519d336c8ae3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 16:32:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ac472344c9ffa6c86cb807c534887ee267d6a3e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 17:54:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/220678/1/gate/gate-python-openstackclient-python26/7f4bde5/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/220678/1/gate/gate-python-openstackclient-docs/9dbe3c6//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/220678/1/gate/gate-python-openstackclient-pep8/a357065/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/220678/1/gate/gate-python-openstackclient-python27/2c5566d/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/78/220678/1/gate/gate-python-openstackclient-python34/3cb2ee8/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/78/220678/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/785ba4e/ : SUCCESS in 1h 19m 15s\n- gate-osc-dsvm-functional http://logs.openstack.org/78/220678/1/gate/gate-osc-dsvm-functional/02928e5/ : SUCCESS in 26m 03s","accounts_in_message":[],"_revision_number":1},{"id":"67227def46b3ee9883dbb6f0f5a4fd81bf0dac4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 17:54:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"c0fa784ab4e5e370f0306ff2e1e34bade8715d6f","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-09-08 17:56:21.000000000","message":"Patch Set 1:\n\ncool, thanks","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3abfea083a13c9aa69bedd10ea0286353d2f5887","revisions":{"3abfea083a13c9aa69bedd10ea0286353d2f5887":{"kind":"REWORK","_number":1,"created":"2015-09-04 21:33:22.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/78/220678/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/78/220678/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/220678/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/220678/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/220678/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/78/220678/1"}}},"commit":{"parents":[{"commit":"9210cac86a2d5d3df9989f40b1fcc605e5f78ed8","subject":"Merge \"Ignore flavor and image find errors on server show\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9210cac86a2d5d3df9989f40b1fcc605e5f78ed8"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-09-04 21:22:33.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2015-09-04 21:25:55.000000000","tz":-300},"subject":"Fix compute API version snafu","message":"Fix compute API version snafu\n\nnovaclient 2.27.0 introduced the API microversion discovery and client.Client\nnow wants an api_version argument to properly work out the correct API\nversion in use.  OSC needs to provide this when required.\n\nLetting the compute client plugin do the version validity checking makes more\nsense than encoding it into shell.py, so I\u0027ve added a new OSC plugin interface\nfunction check_api_version() that is called from shell.py if it exists.  If it\neither does not exist or it returns False the previous version checking using\nAPI_VERSIONS is still performed.\n\ncompute.client.check_api_version() conditionally imports the new\nnovaclient.api_versions module and uses it if successful.  Otherwise\ncheck_api_version() returns False and the previous code path is resumed.\n\nOne side-effect of this is that it is now valid to use --os-compute-api-version\nwith any valid microversion supported by the installed python-novaclient.\n\nCloses-Bug: #1492467\nChange-Id: I4535b38a5639a03a9597bf83f6394f9bb45c2b9e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3abfea083a13c9aa69bedd10ea0286353d2f5887"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3abfea083a13c9aa69bedd10ea0286353d2f5887"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}