)]}'
{"id":"openstack%2Fpython-openstackclient~226922","triplet_id":"openstack%2Fpython-openstackclient~master~I597c9616ad744385fc6dd92379feb03daec54458","project":"openstack/python-openstackclient","branch":"master","topic":"bugs/1418837","hashtags":[],"change_id":"I597c9616ad744385fc6dd92379feb03daec54458","subject":"Mark arguments for \u0027credential\u0027 commands as required","status":"MERGED","created":"2015-09-23 18:25:41.000000000","updated":"2015-11-04 14:33:59.000000000","submitted":"2015-11-04 14:33:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"df4e4839b2ae10d8b6bd50b5436f2310a112b688","_number":226922,"virtual_id_number":226922,"owner":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-11-04 14:33:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":2,"date":"2015-11-04 13:37:44.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-02 03:22:55.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-10-02 04:59:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":1,"date":"2015-11-03 16:58:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":1,"date":"2015-11-04 13:37:44.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-24 02:15:14.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-10-02 03:22:55.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-10-02 04:59:53.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2015-11-03 16:58:00.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2015-11-04 13:37:44.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-04 14:33:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6bb1f6b769fe07f9efb095a61d7ea3ad07a882b0","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-23 18:25:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84fa0bfd86871a822229587b70bfa0854cc9f7e5","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-23 18:30:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"46b691e214919361a9205135e9af02854d4c0843","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-23 18:32:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b1768c55298e92ea8f6a7724bc56cf180acd5e1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 19:46:53.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/226922/3/check/gate-python-openstackclient-python26/f1ad7f4/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/226922/3/check/gate-python-openstackclient-pep8/816e232/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/226922/3/check/gate-python-openstackclient-docs/9a028fb//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/226922/3/check/gate-python-openstackclient-python27/32cc69a/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/226922/3/check/gate-python-openstackclient-python34/f78ff24/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/226922/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/3dde9b7/ : SUCCESS in 54m 55s\n- gate-osc-dsvm-functional http://logs.openstack.org/22/226922/3/check/gate-osc-dsvm-functional/ec12a5e/ : SUCCESS in 22m 37s","accounts_in_message":[],"_revision_number":3},{"id":"d6cf39f3bc8562c36f4cdedfee18aff513e01b51","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-23 20:48:02.000000000","message":"Patch Set 3:\n\nLooking at OSC, there appears to be no agreement on handling of required arguments. Argparse still shows a \u0027required\u003dTrue\u0027 as optional and this is the intended behavior. A work around is to put the required arguments into a group and the help output will then show the group together. Give it a name like \"required arguments\" and you are set. I see this done for a couple of commands but I also see just the \u0027required\u003dTrue\u0027.\n\nWhich is preferred here? It is a really simple change to move the args into a group but I do not want to splinter OSC further.","accounts_in_message":[],"_revision_number":3},{"id":"5c8f60041924436a4bd11e6bc867e63a491ad0a4","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-09-24 21:15:37.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2d496a9f71e112e81cad1f03e90595d20af865be","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-24 21:24:05.000000000","message":"Patch Set 3:\n\nIs this ticket relevant?\n\nhttps://bugs.launchpad.net/python-openstackclient/+bug/1409218","accounts_in_message":[],"_revision_number":3},{"id":"186e65f8d47d0a79850999f4698a09e18259a5c7","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-09-30 22:43:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"11203400942d2e85648e1e45938fb7ea58bb70a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 23:41:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/226922/4/check/gate-python-openstackclient-python26/513183e/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/226922/4/check/gate-python-openstackclient-pep8/d4a24df/ : SUCCESS in 1m 01s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/226922/4/check/gate-python-openstackclient-docs/9433a6a//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/226922/4/check/gate-python-openstackclient-python27/8ba0175/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/226922/4/check/gate-python-openstackclient-python34/cd3004a/ : SUCCESS in 2m 31s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/226922/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7562926/ : SUCCESS in 56m 57s\n- gate-osc-dsvm-functional http://logs.openstack.org/22/226922/4/check/gate-osc-dsvm-functional/c61c1aa/ : SUCCESS in 30m 57s","accounts_in_message":[],"_revision_number":4},{"id":"47b12a5de85bf6523150d96e162dc0909071f665","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-10-02 03:22:55.000000000","message":"Patch Set 4: Code-Review+2\n\nproject is required if type is ec2[1].\n\nThis can done as follow up patch\n\n[1] https://github.com/openstack/keystone/blob/master/keystone/credential/schema.py#L36","accounts_in_message":[],"_revision_number":4},{"id":"3402914b5b46add3941140b73eef557047cf67d2","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2015-10-02 04:59:53.000000000","message":"Patch Set 4: Code-Review+1\n\nThanks Lin!","accounts_in_message":[],"_revision_number":4},{"id":"92e14f53ded6c8af76546d8be03ddf9f28476d77","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-11-03 16:58:00.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"29b99530c25231bfe86136e635b8ac8e3f779250","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-04 13:37:44.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)\n\nthanks Sean","accounts_in_message":[],"_revision_number":4},{"id":"7ff4ec5bf18d00ed0fa798904d7d0a77c50f71bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-04 13:37:49.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"55234a328ee75a72917cb24fa4422bb1a02728be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-04 14:33:57.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/22/226922/4/gate/gate-python-openstackclient-python26/baf726a/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/226922/4/gate/gate-python-openstackclient-docs/4076293//doc/build/html/ : SUCCESS in 2m 09s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/226922/4/gate/gate-python-openstackclient-pep8/43f25bc/ : SUCCESS in 1m 08s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/226922/4/gate/gate-python-openstackclient-python27/f841f2d/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/226922/4/gate/gate-python-openstackclient-python34/7d14d18/ : SUCCESS in 1m 44s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/226922/4/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/16f04c8/ : SUCCESS in 50m 58s\n- gate-osc-dsvm-functional http://logs.openstack.org/22/226922/4/gate/gate-osc-dsvm-functional/bd3ff37/ : SUCCESS in 26m 51s","accounts_in_message":[],"_revision_number":4},{"id":"00988a2d22484f316ab948d40f40eb5ac3c748a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-04 14:33:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b33cdec92ab3707886c12f49e9db27981114b35d","revisions":{"d8ede4bc88383f74118db42b56f11ac0f553429a":{"kind":"REWORK","_number":1,"created":"2015-09-23 18:25:41.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/22/226922/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/226922/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/1"}}},"commit":{"parents":[{"commit":"29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b","subject":"Merge \"Use `discover_extensions` for novaclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 17:39:13.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 18:25:22.000000000","tz":-420},"subject":"Mark arguments for \u0027credential\u0027 commands as required","message":"Mark arguments for \u0027credential\u0027 commands as required\n\nAccording to the spec, \u0027user_id\u0027, \u0027type\u0027, and \u0027blob\u0027 are all required arguments\nfor create and set but the code treats them as optional. Set the \u0027required\u0027\nflag and remove logic supporting missing arguments.\n\nChange-Id: I597c9616ad744385fc6dd92379feb03daec54458\nCloses-Bug: #1418837\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d8ede4bc88383f74118db42b56f11ac0f553429a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d8ede4bc88383f74118db42b56f11ac0f553429a"}]},"branch":"refs/heads/master"},"649323bc0a2a663d80a5da08b574c6c4536b4553":{"kind":"REWORK","_number":2,"created":"2015-09-23 18:30:41.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/22/226922/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/226922/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/2"}}},"commit":{"parents":[{"commit":"29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b","subject":"Merge \"Use `discover_extensions` for novaclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 17:39:13.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 18:30:16.000000000","tz":-420},"subject":"Mark arguments for \u0027credential\u0027 commands as required","message":"Mark arguments for \u0027credential\u0027 commands as required\n\nAccording to the spec, \u0027user_id\u0027, \u0027type\u0027, and \u0027blob\u0027 are all required arguments\nfor create and set but the code treats them as optional. Set the \u0027required\u0027\nflag and remove logic supporting missing arguments.\n\nChange-Id: I597c9616ad744385fc6dd92379feb03daec54458\nCloses-Bug: #1418837\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/649323bc0a2a663d80a5da08b574c6c4536b4553"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/649323bc0a2a663d80a5da08b574c6c4536b4553"}]},"branch":"refs/heads/master"},"52d11332b64f462ddc6ad38dc877719eb18ad287":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-09-23 18:32:49.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/22/226922/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/226922/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/3"}}},"commit":{"parents":[{"commit":"29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b","subject":"Merge \"Use `discover_extensions` for novaclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/29aad2a9b598eaf48eebb2e7233d47ed2c0eb05b"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 17:39:13.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 18:32:07.000000000","tz":-420},"subject":"Mark arguments for \u0027credential\u0027 commands as required","message":"Mark arguments for \u0027credential\u0027 commands as required\n\nAccording to the spec, \u0027user_id\u0027, \u0027type\u0027, and \u0027blob\u0027 are all required arguments\nfor \u0027credential set\u0027 but the code treats them as optional. Set the \u0027required\u0027\nflag and remove logic supporting missing arguments.\n\nChange-Id: I597c9616ad744385fc6dd92379feb03daec54458\nCloses-Bug: #1418837\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/52d11332b64f462ddc6ad38dc877719eb18ad287"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/52d11332b64f462ddc6ad38dc877719eb18ad287"}]},"branch":"refs/heads/master"},"b33cdec92ab3707886c12f49e9db27981114b35d":{"kind":"REWORK","_number":4,"created":"2015-09-30 22:43:51.000000000","uploader":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"ref":"refs/changes/22/226922/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/226922/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/226922/4"}}},"commit":{"parents":[{"commit":"678e69064854e3a3d3499171b0a29f30f2771840","subject":"Merge \"Override the debug default and help text\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/678e69064854e3a3d3499171b0a29f30f2771840"}]}],"author":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-23 17:39:13.000000000","tz":-420},"committer":{"name":"Sean Perry","email":"sean.perry@hp.com","date":"2015-09-30 22:33:45.000000000","tz":-420},"subject":"Mark arguments for \u0027credential\u0027 commands as required","message":"Mark arguments for \u0027credential\u0027 commands as required\n\nAccording to the [1], \u0027user_id\u0027, \u0027type\u0027, and \u0027blob\u0027 are all required\narguments for \u0027credential set\u0027 but the code treats them as optional. Set the\n\u0027required\u0027 flag and remove logic supporting missing arguments.\n\n[1]: https://github.com/openstack/keystone-specs/blob/master/api/v3/identity-api-v3.rst#credentials-v3credentials \"spec\"\n\nChange-Id: I597c9616ad744385fc6dd92379feb03daec54458\nCloses-Bug: #1418837\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b33cdec92ab3707886c12f49e9db27981114b35d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b33cdec92ab3707886c12f49e9db27981114b35d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}