)]}'
{"doc/source/command-objects/compute.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"059a4dd72cac94880a5e76ebe53e9bcf31a6114c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a2fa921_34809e8a","updated":"2015-10-10 06:39:25.000000000","message":"this should be split into two files: compute_agent and compute_service since those are the \"resources\" or \"objects\" or \"nouns\" ... whatever we\u0027re calling them","commit_id":"ab9b18fc127555625dc771da05390f65778d8b8b"}],"openstackclient/compute/v2/service.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"616b4ff952457f7ef3d56393f2a3357273ec3024","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Id of service.\")"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_2c07991d","line":36,"updated":"2015-10-07 03:42:37.000000000","message":"\"Compute service to delete (ID only)\"","commit_id":"c405783a231afc0be4c56749f62653375a4dbd5b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"abf5dd3219157f0a50451b805d00b3d6899ea4df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Id of service.\")"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_cf5a972a","line":36,"in_reply_to":"7a2fa921_2c07991d","updated":"2015-10-07 03:51:41.000000000","message":"I actually don\u0027t know how to trigger this so that this string actually shows up. Also this is the same help text of the \u0027nova service-delete\u0027. Would \u0027Id of compute service\u0027 be an acceptable alternative?","commit_id":"c405783a231afc0be4c56749f62653375a4dbd5b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"54c930c628113d4607e8320bab52d134e8c303fa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Id of service.\")"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_2f91cb99","line":36,"in_reply_to":"7a2fa921_cf5a972a","updated":"2015-10-07 03:58:15.000000000","message":"Nevermind on getting the help string to show up. I found it only shows when you run \u0027openstack\u0027 and then \u0027compute service delete -h\u0027. It doesn\u0027t show up with you run \u0027openstack compute service delete -h\u0027. Done.","commit_id":"c405783a231afc0be4c56749f62653375a4dbd5b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"616b4ff952457f7ef3d56393f2a3357273ec3024","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":41,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        action \u003d compute_client.services.delete"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        action(parsed_args.id)"},{"line_number":46,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_6c0d913d","line":43,"updated":"2015-10-07 03:42:37.000000000","message":"make this one line?\n\n  compute_client.services.delete(parsed_args.id)","commit_id":"c405783a231afc0be4c56749f62653375a4dbd5b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"54c930c628113d4607e8320bab52d134e8c303fa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.log.debug(\"take_action(%s)\", parsed_args)"},{"line_number":41,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        action \u003d compute_client.services.delete"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        action(parsed_args.id)"},{"line_number":46,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_4f8c477f","line":43,"in_reply_to":"7a2fa921_6c0d913d","updated":"2015-10-07 03:58:15.000000000","message":"Done","commit_id":"c405783a231afc0be4c56749f62653375a4dbd5b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c70a31dc55cf4a61e6ae9686b7c9dcf4bab3cce8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(DeleteService, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Compute service to delete (ID only)\")"},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_5cbdb866","line":34,"updated":"2015-10-07 22:52:40.000000000","message":"This argument should be called \u0027service\u0027 to match the list and set commands.","commit_id":"2dd8859d3e4bfefbd18fdfe770f944dd36de68e4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3743e1b5ebc8ad545b77a7402e5496c0eb7a87d7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(DeleteService, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Compute service to delete (ID only)\")"},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_e50167b0","line":34,"in_reply_to":"7a2fa921_5cbdb866","updated":"2015-10-08 14:02:34.000000000","message":"No, it\u0027s must be the id of the service not the service name. The nova client deletes via ID not name.\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/services.py#L86-L88","commit_id":"2dd8859d3e4bfefbd18fdfe770f944dd36de68e4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6b3b493243314f08252221ed3438f10be4ad5c5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(DeleteService, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Compute service to delete (ID only)\")"},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0976e0a3","line":34,"in_reply_to":"7a2fa921_e50167b0","updated":"2015-10-09 02:21:10.000000000","message":"alex, we\u0027re still sending then ID only, this just changes up what the user sees when they ask for help.\n\nthe help should show up as:\n\n  service delete \u003cservice\u003e\n    \u003cservice\u003e    Compute service to delete (ID only)\n\ninstead of:\n\n  service delete \u003cid\u003e\n    \u003cid\u003e    Compute service to delete (ID only)\n\nwe do this for two reasons: 1) to give the argument a bit more context (in this example it\u0027s not the best), it\u0027s especially handy when we have multiple arguments. 2) we use this convention everywhere else in openstackclient","commit_id":"2dd8859d3e4bfefbd18fdfe770f944dd36de68e4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6b3b493243314f08252221ed3438f10be4ad5c5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        parser \u003d super(DeleteService, self).get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"id\","},{"line_number":35,"context_line":"            metavar\u003d\"\u003cid\u003e\","},{"line_number":36,"context_line":"            help\u003d\"Compute service to delete (ID only)\")"},{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_c96b08b8","line":35,"updated":"2015-10-09 02:21:10.000000000","message":"this should also say \"\u003cservice\u003e\"","commit_id":"2dd8859d3e4bfefbd18fdfe770f944dd36de68e4"}],"openstackclient/tests/compute/v2/test_service.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6b3b493243314f08252221ed3438f10be4ad5c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            compute_fakes.service_id,"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        verifylist \u003d ["},{"line_number":45,"context_line":"            (\u0027id\u0027, compute_fakes.service_id),"},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_896af0b1","line":45,"updated":"2015-10-09 02:21:10.000000000","message":"this should swap to service, and all should be right in the world","commit_id":"2dd8859d3e4bfefbd18fdfe770f944dd36de68e4"},{"author":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"change_message_id":"6c10145a40bfd983a23ccfa552ce7eec7d58421d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.cmd \u003d service.DeleteService(self.app, None)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_service_delete_no_options(self):"},{"line_number":41,"context_line":"        arglist \u003d ["},{"line_number":42,"context_line":"            compute_fakes.service_id,"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_d847ac75","line":41,"updated":"2015-11-05 08:09:22.000000000","message":"I think that variable name should be snake case.","commit_id":"d1bc15f498da1a4d5f1c865d5eb6a151f472be9c"},{"author":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"change_message_id":"0d3ed795f81b96ad016eb7b43d9d7e50088bc7ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.cmd \u003d service.DeleteService(self.app, None)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_service_delete_no_options(self):"},{"line_number":41,"context_line":"        arglist \u003d ["},{"line_number":42,"context_line":"            compute_fakes.service_id,"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_b409932e","line":41,"in_reply_to":"da85f559_99ca886d","updated":"2015-11-10 06:05:14.000000000","message":"Sorry. I tried to review the other code.\nThis variable was common name in test code of OpenStack.","commit_id":"d1bc15f498da1a4d5f1c865d5eb6a151f472be9c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"34c78aa9cd065d71863f572537159fe75336e612","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.cmd \u003d service.DeleteService(self.app, None)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_service_delete_no_options(self):"},{"line_number":41,"context_line":"        arglist \u003d ["},{"line_number":42,"context_line":"            compute_fakes.service_id,"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_99ca886d","line":41,"in_reply_to":"fa80f949_d847ac75","updated":"2015-11-10 05:35:28.000000000","message":"camel case are usually used in class name, for local variable it is just small case","commit_id":"d1bc15f498da1a4d5f1c865d5eb6a151f472be9c"}]}