)]}'
{"id":"openstack%2Fpython-openstackclient~231847","triplet_id":"openstack%2Fpython-openstackclient~master~I2343c1e67843ab53773b3fca6e258dc329cd9573","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1503508","hashtags":[],"change_id":"I2343c1e67843ab53773b3fca6e258dc329cd9573","subject":"Fix non-ascii issue with object commands","status":"MERGED","created":"2015-10-07 06:26:18.000000000","updated":"2015-10-08 20:12:12.000000000","submitted":"2015-10-08 20:12:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7d375a5d4d3d426652cbd33e3ef45167e7ddf10a","_number":231847,"virtual_id_number":231847,"owner":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-10-07 15:33:42.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-10-08 20:12:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-10-07 17:18:15.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-10-07 18:01:25.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2015-10-08 19:20:19.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-10-08 19:20:19.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-07 15:33:42.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-10-08 19:20:19.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-10-08 20:12:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b5456efbe555916e088f3249b1e4408e4b0bd9fe","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-10-07 06:26:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de93538967ee651ab95ab1bf3685c6c32f66e971","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 07:18:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/47/231847/1/check/gate-python-openstackclient-python26/f1ab605/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/47/231847/1/check/gate-python-openstackclient-pep8/fcc59a6/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/47/231847/1/check/gate-python-openstackclient-docs/20d5b39//doc/build/html/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/47/231847/1/check/gate-python-openstackclient-python27/4b397ad/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/47/231847/1/check/gate-python-openstackclient-python34/c54c3fb/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/47/231847/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/068cd98/ : SUCCESS in 51m 40s\n- gate-osc-dsvm-functional http://logs.openstack.org/47/231847/1/check/gate-osc-dsvm-functional/761fd16/ : SUCCESS in 20m 13s","accounts_in_message":[],"_revision_number":1},{"id":"f98260f67efeba8b431227acae79bac15b1a6131","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-07 15:33:42.000000000","message":"Patch Set 1:\n\nshould we bother trying to do this for properties too?","accounts_in_message":[],"_revision_number":1},{"id":"c414e09ba0d09d12dac75850a5a2b5fedeb3bd42","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-10-07 17:18:15.000000000","message":"Patch Set 1:\n\ngood catch.\n\nDidn\u0027t expect that non-ascii also fails for properties","accounts_in_message":[],"_revision_number":1},{"id":"996ffb7cfb39d86902ddf515a404d54115858dc0","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-10-07 17:48:08.000000000","message":"Patch Set 1:\n\n@Steve: I looked it up, non-ascii characters are not allowed in HTTP headers.  \n\nWe have to add a validation instead to reject non-ascii values, follow-up patch then?","accounts_in_message":[],"_revision_number":1},{"id":"5114dcc44a87ae1f49f1daff9c52a1d86cf7e703","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-07 18:01:25.000000000","message":"Patch Set 1: Code-Review+2\n\n@lin, sounds good to me","accounts_in_message":[],"_revision_number":1},{"id":"81ad8c5311b1f40b4962dc870d195173f47ac614","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-10-08 19:20:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fc2fc66941f071f332f8286e1a3888077ee7fdc5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 19:20:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f58dfc373545ecc7ecc81d0038f9bd7e7f0db799","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 20:12:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/47/231847/1/gate/gate-python-openstackclient-python26/c004264/ : SUCCESS in 1m 27s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/47/231847/1/gate/gate-python-openstackclient-docs/87f4a60//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/47/231847/1/gate/gate-python-openstackclient-pep8/4529b90/ : SUCCESS in 1m 03s\n- gate-python-openstackclient-python27 http://logs.openstack.org/47/231847/1/gate/gate-python-openstackclient-python27/297f0e5/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/47/231847/1/gate/gate-python-openstackclient-python34/3e1f500/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/47/231847/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/9e3ea05/ : SUCCESS in 50m 57s\n- gate-osc-dsvm-functional http://logs.openstack.org/47/231847/1/gate/gate-osc-dsvm-functional/df9e6d3/ : SUCCESS in 18m 54s","accounts_in_message":[],"_revision_number":1},{"id":"3125acdb0b5b8c438d708deeddb67829e5f2e631","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 20:12:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"985b2cdd2c07442f4446e6164117cb8011269c8c","revisions":{"985b2cdd2c07442f4446e6164117cb8011269c8c":{"kind":"REWORK","_number":1,"created":"2015-10-07 06:26:18.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/47/231847/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/47/231847/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/231847/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/231847/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/231847/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/47/231847/1"}}},"commit":{"parents":[{"commit":"262af5416b0fad02dee93aed2193cfee761ebd83","subject":"Merge \"Add ID column to compute service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/262af5416b0fad02dee93aed2193cfee761ebd83"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-10-07 06:26:08.000000000","tz":-420},"committer":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-10-07 06:26:08.000000000","tz":-420},"subject":"Fix non-ascii issue with object commands","message":"Fix non-ascii issue with object commands\n\nEscape the container and object name whenever it is used\nas URL.\n\nChange-Id: I2343c1e67843ab53773b3fca6e258dc329cd9573\nCloses-Bug: #1503508\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/985b2cdd2c07442f4446e6164117cb8011269c8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/985b2cdd2c07442f4446e6164117cb8011269c8c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}