)]}'
{"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(CreateVolume, self).get_parser(prog_name)"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027size\u0027,"},{"line_number":37,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FZM%3D","line":35,"updated":"2013-03-04 14:01:09.000000000","message":"This should be an integer option.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(CreateVolume, self).get_parser(prog_name)"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027size\u0027,"},{"line_number":37,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8pQ%3D","line":35,"in_reply_to":"AAAAN3%2F%2F%2FZM%3D","updated":"2013-03-05 16:45:44.000000000","message":"Added type\u003dint,","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027size\u0027,"},{"line_number":37,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--snapshot_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FZE%3D","line":38,"updated":"2013-03-04 14:01:09.000000000","message":"Does size need a default of 0?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027size\u0027,"},{"line_number":37,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--snapshot_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8pM%3D","line":38,"in_reply_to":"AAAAN3%2F%2F%2FZE%3D","updated":"2013-03-05 16:45:44.000000000","message":"I dont think so, 1) nothing happens with size 0, and 2) because it is a required argument","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--snapshot_id\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":43,"context_line":"            default\u003dNone,"},{"line_number":44,"context_line":"            help\u003d\u0027ID of the snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FZI%3D","line":41,"updated":"2013-03-04 14:01:09.000000000","message":"We\u0027re trying to avoid mixing - and _ in option names. For example, this option should be \"--snapshot-id\" instead of \"--snapshot_id\". The same applies throughout the rest of this file.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            help\u003d\u0027New volume size\u0027,"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--snapshot_id\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":43,"context_line":"            default\u003dNone,"},{"line_number":44,"context_line":"            help\u003d\u0027ID of the snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8pI%3D","line":41,"in_reply_to":"AAAAN3%2F%2F%2FZI%3D","updated":"2013-03-05 16:45:44.000000000","message":"Thanks, rookie mistake, I fixed it throughout the file.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \u0027--name\u0027,"},{"line_number":48,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of the volume\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FY8%3D","line":49,"updated":"2013-03-04 14:01:09.000000000","message":"String options should have string defaults, no?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \u0027--name\u0027,"},{"line_number":48,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of the volume\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8pA%3D","line":49,"in_reply_to":"AAAAN3%2F%2F%2FY8%3D","updated":"2013-03-05 16:45:44.000000000","message":"I removed the defaults altogether, after reading more argparse docs, turns out they were unnecessary.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--description\u0027,"},{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":55,"context_line":"            default\u003dNone,"},{"line_number":56,"context_line":"            help\u003d\u0027Description of the volume\u0027,"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FY0%3D","line":55,"updated":"2013-03-04 14:01:09.000000000","message":"Use a string as a default?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--metadata\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027\u003cmetadata\u003e\u0027,"},{"line_number":85,"context_line":"            default\u003dNone,"},{"line_number":86,"context_line":"            help\u003d\u0027Optional metadata to set on volume creation\u0027,"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--imageRef\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYg%3D","line":86,"updated":"2013-03-04 14:01:09.000000000","message":"What form should this metadata take?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            help\u003d\u0027Optional metadata to set on volume creation\u0027,"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--imageRef\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003cimageRef\u003e\u0027,"},{"line_number":91,"context_line":"            default\u003dNone,"},{"line_number":92,"context_line":"            help\u003d\u0027reference to an image stored in glance\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYs%3D","line":89,"updated":"2013-03-04 14:01:09.000000000","message":"Don\u0027t mix case, use a word separator. \"--image-ref\"","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            help\u003d\u0027Optional metadata to set on volume creation\u0027,"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--imageRef\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003cimageRef\u003e\u0027,"},{"line_number":91,"context_line":"            default\u003dNone,"},{"line_number":92,"context_line":"            help\u003d\u0027reference to an image stored in glance\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8o8%3D","line":89,"in_reply_to":"AAAAN3%2F%2F%2FYs%3D","updated":"2013-03-05 16:45:44.000000000","message":"thanks.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        info \u003d {}"},{"line_number":122,"context_line":"        info.update(volume_volume._info)"},{"line_number":123,"context_line":"        return zip(*sorted(info.iteritems()))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYc%3D","line":122,"updated":"2013-03-04 14:01:09.000000000","message":"There\u0027s no need for an extra dict instance here.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--name\u0027,"},{"line_number":181,"context_line":"            metavar\u003d\u0027\u003cnew-volume-name\u003e\u0027,"},{"line_number":182,"context_line":"            help\u003d\u0027New volume name\u0027)"},{"line_number":183,"context_line":"        parser.add_argument("},{"line_number":184,"context_line":"            \u0027--description\u0027,"},{"line_number":185,"context_line":"            metavar\u003d\u0027\u003cvolume-description\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYU%3D","line":182,"updated":"2013-03-04 14:01:09.000000000","message":"String default?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        parser.add_argument("},{"line_number":184,"context_line":"            \u0027--description\u0027,"},{"line_number":185,"context_line":"            metavar\u003d\u0027\u003cvolume-description\u003e\u0027,"},{"line_number":186,"context_line":"            help\u003d\u0027New volume description\u0027)"},{"line_number":187,"context_line":"        return parser"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYQ%3D","line":186,"updated":"2013-03-04 14:01:09.000000000","message":"String default?","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if parsed_args.description:"},{"line_number":197,"context_line":"            kwargs[\u0027display_description\u0027] \u003d parsed_args.description"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if not len(kwargs):"},{"line_number":200,"context_line":"            stdout.write(\"Volume not updated, no arguments present\")"},{"line_number":201,"context_line":"            return"},{"line_number":202,"context_line":"        volume_client.volumes.update(volume.id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYM%3D","line":199,"updated":"2013-03-04 14:01:09.000000000","message":"This should just be \"if not kwargs\"","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            kwargs[\u0027display_description\u0027] \u003d parsed_args.description"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if not len(kwargs):"},{"line_number":200,"context_line":"            stdout.write(\"Volume not updated, no arguments present\")"},{"line_number":201,"context_line":"            return"},{"line_number":202,"context_line":"        volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":203,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FYA%3D","line":200,"updated":"2013-03-04 14:01:09.000000000","message":"I don\u0027t see stdout defined anywhere.","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            kwargs[\u0027display_description\u0027] \u003d parsed_args.description"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        if not len(kwargs):"},{"line_number":200,"context_line":"            stdout.write(\"Volume not updated, no arguments present\")"},{"line_number":201,"context_line":"            return"},{"line_number":202,"context_line":"        volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":203,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8lA%3D","line":200,"in_reply_to":"AAAAN3%2F%2F%2FYA%3D","updated":"2013-03-05 16:45:44.000000000","message":"using sys.stdout now, there are many uses of just references to stdout that will need to be fixed","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        info \u003d {}"},{"line_number":226,"context_line":"        info.update(volume._info)"},{"line_number":227,"context_line":"        return zip(*sorted(info.iteritems()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FX8%3D","line":226,"updated":"2013-03-04 14:01:09.000000000","message":"extra dict","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9c8732b9ff939612fce09c092ec0b903f62220f8","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        info \u003d {}"},{"line_number":226,"context_line":"        info.update(volume._info)"},{"line_number":227,"context_line":"        return zip(*sorted(info.iteritems()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8o0%3D","line":226,"in_reply_to":"AAAAN3%2F%2F%2FX8%3D","updated":"2013-03-05 16:45:44.000000000","message":"Fixed","commit_id":"637161d5e99b62efffaeb0dbd7cdcf5b27b24826"}]}