)]}'
{"id":"openstack%2Fpython-openstackclient~23323","triplet_id":"openstack%2Fpython-openstackclient~master~Id8236685d815dbf73873bab2363d82274a9aa556","project":"openstack/python-openstackclient","branch":"master","topic":"volume","hashtags":[],"change_id":"Id8236685d815dbf73873bab2363d82274a9aa556","subject":"Add volume support for openstack client","status":"MERGED","created":"2013-03-01 22:37:39.000000000","updated":"2013-03-08 19:39:30.000000000","submitted":"2013-03-08 19:39:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":20,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"29a7f31dd37eee36815ba3778571ed94dcab9dcb","_number":23323,"virtual_id_number":23323,"owner":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2013-03-08 19:39:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-08 19:36:34.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":2,"date":"2013-03-08 17:49:59.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-08 19:36:34.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"date":"2013-03-08 17:49:59.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-05 17:13:02.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-03-08 17:49:59.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-03-08 19:36:34.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-03-08 19:39:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3dd97382e110c0a9c707d4b5a8bd74eed0d12670","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 22:41:46.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23323/1/check/gate-python-openstackclient-pep8/236 : SUCCESS\n- http://logs.openstack.org/23323/1/check/gate-python-openstackclient-docs/162 : SUCCESS\n- http://logs.openstack.org/23323/1/check/gate-python-openstackclient-python26/230 : SUCCESS\n- http://logs.openstack.org/23323/1/check/gate-python-openstackclient-python27/234 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b15f25c440ecf3ad24f7fdea7d0ebf5e9e51b673","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-03-04 14:01:09.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(13 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9c8732b9ff939612fce09c092ec0b903f62220f8","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-05 16:45:44.000000000","message":"Patch Set 1: (7 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"c4f5d20a3ed8724df7147a7673345270ffe9c4d4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-05 16:47:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ce45c2f09c0c79ad8102b4bd8771a997f54b3292","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 16:48:46.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"02b839b7cd0650052c2300cdc8f7c8e4a17a1bd5","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-05 17:10:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d61bb05476331b8aadee4a9c9e61d269e6590b76","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 17:35:29.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23323/3/check/gate-python-openstackclient-pep8/249 : SUCCESS\n- http://logs.openstack.org/23323/3/check/gate-python-openstackclient-docs/175 : SUCCESS\n- http://logs.openstack.org/23323/3/check/gate-python-openstackclient-python26/243 : SUCCESS\n- http://logs.openstack.org/23323/3/check/gate-python-openstackclient-python27/247 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"7009dd961acaf6ed402f76206d4187165a02dc78","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-03-06 16:21:54.000000000","message":"Patch Set 3:\n\nThe default for an option value is None. Does our API accept None where an argument is saved as a string?","accounts_in_message":[],"_revision_number":3},{"id":"657106a38165337d51bdb9efdd70e00aa2f44501","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-06 22:15:42.000000000","message":"Patch Set 3:\n\nWhat would you think about making a bit of a change to create volume as reflected in https://wiki.openstack.org/wiki/UnifiedCLI/Mapping#volume_2, basically making \u0027name\u0027 the single positional argument and making \u0027size\u0027 a required option (oxymoron alert!).  This is more consistent with how other create commands are structured.","accounts_in_message":[],"_revision_number":3},{"id":"e06ece6e18dd41ac1fafce04020ee1031c60a6ed","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-07 20:13:49.000000000","message":"Patch Set 3:\n\ndtroyer, I\u0027m okay with what you suggested, it does make things more consistent. On another note, can you answer dhellmann\u0027s question? I think our API works fine when we don\u0027t default strings, and they have a None value. But just trying to make sure.","accounts_in_message":[],"_revision_number":3},{"id":"545e705c7b737eae48ba3f251d7c805d10668810","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-07 20:18:23.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"54fb6580c309dcb42410c61f50afb1cf27526c89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-07 20:23:23.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23323/4/check/gate-python-openstackclient-pep8/258 : SUCCESS\n- http://logs.openstack.org/23323/4/check/gate-python-openstackclient-docs/184 : SUCCESS\n- http://logs.openstack.org/23323/4/check/gate-python-openstackclient-python26/252 : SUCCESS\n- http://logs.openstack.org/23323/4/check/gate-python-openstackclient-python27/256 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"9fba9807041c72a2405f6cebab6c3d22a47a5988","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-08 17:49:59.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n@dhellman: string args that default to None show up in the database as NULL as you would expect.  Given a 0-length string (\u0027\u0027) they display as an empty field by both python and the database.\n\nThis is the same behaviour as the stock clients, not to say that they are right, just that it isn\u0027t wrong at some level...clouds are functional like this.","accounts_in_message":[],"_revision_number":4},{"id":"4de2bc944c4065ec550b576d1a873b985968743e","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-03-08 19:36:34.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\nThanks, Dean, that\u0027s exactly the answer I was looking for.","accounts_in_message":[],"_revision_number":4},{"id":"e4eb36fee739254b1753cd67a0ef5bf1dc50fc54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-08 19:36:36.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"684167eea757d9bb55fb7a45fc1f3a122032d732","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-08 19:39:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4},{"id":"8208a7ade6e18ea4b96a394717604ea8c484637a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-08 19:39:30.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23323/4/gate/gate-python-openstackclient-docs/191 : SUCCESS\n- http://logs.openstack.org/23323/4/gate/gate-python-openstackclient-pep8/266 : SUCCESS\n- http://logs.openstack.org/23323/4/gate/gate-python-openstackclient-python26/259 : SUCCESS\n- http://logs.openstack.org/23323/4/gate/gate-python-openstackclient-python27/263 : SUCCESS\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"abbbed534d296c6fe1824ee010ead65292cc3a58","revisions":{"637161d5e99b62efffaeb0dbd7cdcf5b27b24826":{"kind":"REWORK","_number":1,"created":"2013-03-01 22:37:39.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/23/23323/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/23323/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/1"}}},"commit":{"parents":[{"commit":"287c23ca4b023a53898e839dc2247d83b437c7f8","subject":"Merge \"Added compute flavor support.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/287c23ca4b023a53898e839dc2247d83b437c7f8"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-01 22:36:08.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-01 22:36:08.000000000","tz":-360},"subject":"Add volume support for openstack client","message":"Add volume support for openstack client\n\ncreate/list/delete/show/set for volume commands\n\nChange-Id: Id8236685d815dbf73873bab2363d82274a9aa556\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/637161d5e99b62efffaeb0dbd7cdcf5b27b24826"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/637161d5e99b62efffaeb0dbd7cdcf5b27b24826"}]},"branch":"refs/heads/master"},"72ff6c9d5858ebc9b991c43ab97a6d87b2301e1b":{"kind":"REWORK","_number":2,"created":"2013-03-05 16:47:28.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/23/23323/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/23323/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/2"}}},"commit":{"parents":[{"commit":"287c23ca4b023a53898e839dc2247d83b437c7f8","subject":"Merge \"Added compute flavor support.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/287c23ca4b023a53898e839dc2247d83b437c7f8"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-01 22:36:08.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-05 16:47:06.000000000","tz":-360},"subject":"Add volume support for openstack client","message":"Add volume support for openstack client\n\nfix with dhellmann\u0027s comments\ncreate/list/delete/show/set for volume commands\n\nChange-Id: Id8236685d815dbf73873bab2363d82274a9aa556\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/72ff6c9d5858ebc9b991c43ab97a6d87b2301e1b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/72ff6c9d5858ebc9b991c43ab97a6d87b2301e1b"}]},"branch":"refs/heads/master"},"374cf77c724035b4db73f2b47085e29690dc8295":{"kind":"REWORK","_number":3,"created":"2013-03-05 17:10:55.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/23/23323/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/23323/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/3"}}},"commit":{"parents":[{"commit":"ed809e059a85f70e8f89d1a59e533064b9e9143e","subject":"Add quota v1 support for volume","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ed809e059a85f70e8f89d1a59e533064b9e9143e"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-01 22:36:08.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-05 17:10:44.000000000","tz":-360},"subject":"Add volume support for openstack client","message":"Add volume support for openstack client\n\nrebase\nfix with dhellmann\u0027s comments\ncreate/list/delete/show/set for volume commands\n\nChange-Id: Id8236685d815dbf73873bab2363d82274a9aa556\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/374cf77c724035b4db73f2b47085e29690dc8295"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/374cf77c724035b4db73f2b47085e29690dc8295"}]},"branch":"refs/heads/master"},"abbbed534d296c6fe1824ee010ead65292cc3a58":{"kind":"REWORK","_number":4,"created":"2013-03-07 20:18:23.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/23/23323/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/23323/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/23323/4"}}},"commit":{"parents":[{"commit":"5377da34065afdf96f2dd873419d77583844dfdd","subject":"Add metadata support for volume type","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5377da34065afdf96f2dd873419d77583844dfdd"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-01 22:36:08.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-07 20:18:18.000000000","tz":-360},"subject":"Add volume support for openstack client","message":"Add volume support for openstack client\n\nfix with dtroyer\u0027s comments\nrebase\nfix with dhellmann\u0027s comments\ncreate/list/delete/show/set for volume commands\n\nChange-Id: Id8236685d815dbf73873bab2363d82274a9aa556\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abbbed534d296c6fe1824ee010ead65292cc3a58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abbbed534d296c6fe1824ee010ead65292cc3a58"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}