)]}'
{"id":"openstack%2Fpython-openstackclient~23981","triplet_id":"openstack%2Fpython-openstackclient~master~If534ccd1d8a3abc6d235c60ec9a964b88e3fa66d","project":"openstack/python-openstackclient","branch":"master","topic":"TypeExtraSpecs","hashtags":[],"change_id":"If534ccd1d8a3abc6d235c60ec9a964b88e3fa66d","subject":"Add extra-specs support for volume-type","status":"MERGED","created":"2013-03-09 06:11:58.000000000","updated":"2013-03-21 20:39:50.000000000","submitted":"2013-03-21 20:39:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f7f16165e29c14454f1804a37af4a8668af13250","_number":23981,"virtual_id_number":23981,"owner":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2013-03-21 20:39:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2013-03-21 20:35:43.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-21 19:38:40.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2013-03-21 20:35:43.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-21 19:38:40.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-21 19:38:40.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-03-21 20:35:43.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-03-21 20:39:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b58d5d396d9cc0547f978743df394f56f25e91ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-09 06:16:00.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23981/1/check/gate-python-openstackclient-pep8/272 : SUCCESS\n- http://logs.openstack.org/23981/1/check/gate-python-openstackclient-docs/197 : SUCCESS\n- http://logs.openstack.org/23981/1/check/gate-python-openstackclient-python26/265 : SUCCESS\n- http://logs.openstack.org/23981/1/check/gate-python-openstackclient-python27/269 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"1c7923a504eface61e503fc507fc104611e9b3ea","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-09 06:47:37.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nI\u0027m pondering the set/unset model where in other places we use options rather than a second positional argument.  That would be a required change if changing the volume type name is possible.\n\nAlso, I think we\u0027re going to need to qualify \u0027type\u0027.  It\u0027s too general and likely to be used in other APIs also.  \u0027volume-type\u0027 or \u0027voltype\u0027 or \u0027vol-type\u0027?  nova cli uses secgroup to shorten security-group.  I don\u0027t think we\u0027ve set an OSC precedent yet?","accounts_in_message":[],"_revision_number":1},{"id":"12c1809df9f0d0b0675535cdb005df61b0142202","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-09 18:40:31.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4a3a57d7937825c75ef09949b6917c1034dc70ac","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-10 03:57:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d1684159e34f277331da5474992fa7a88063d871","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-10 04:02:16.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23981/2/check/gate-python-openstackclient-pep8/276 : SUCCESS\n- http://logs.openstack.org/23981/2/check/gate-python-openstackclient-docs/201 : SUCCESS\n- http://logs.openstack.org/23981/2/check/gate-python-openstackclient-python26/269 : SUCCESS\n- http://logs.openstack.org/23981/2/check/gate-python-openstackclient-python27/273 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"fabdfaa077dc411a15952e07343981511d61278c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-10 04:12:19.000000000","message":"Patch Set 2:\n\n@dtroyer, \n\nRegarding your first comment; yes, I noticed the set/unset model doesn\u0027t fit perfectly in the case where meta-data is used, because of the needed second positional argument. The scenario you described will happen when we try to update the metadata for a \u0027volume\u0027 object, since it can update metadata/name and description.\n\nI\u0027m wondering if we want to reserve set/unset for metadata, and maybe use edit/update as the \u0027verb\u0027 for tasks like updating name/description... but that seems like an awful lot of work. \n\nregarding your second comment; I agree, that \u0027type\u0027 is too generic; and AFAIK, we don\u0027t have a standard in OSC thus far, so I\u0027m okay with either, vol-type or volume-type (ones with hyphens) seem best, not a big fan of voltype - that split second of ambiguity when reading it bugs me.","accounts_in_message":[],"_revision_number":2},{"id":"7d3d85d8950ad82f9536f796c49f9eea0a3895ec","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-15 19:20:28.000000000","message":"Patch Set 2: Do not merge\n\nset/unset is what it is...\n\nbut let\u0027s go ahead with \u0027volume-type\u0027 rather than just \u0027type\u0027.  We use it elsewhere, like as an option in the \u0027create volume\u0027 command.","accounts_in_message":[],"_revision_number":2},{"id":"b7536aad1ee520900502e9ce70d33cf4c119586e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-19 19:28:46.000000000","message":"Patch Set 2: Work In Progress","accounts_in_message":[],"_revision_number":2},{"id":"93bf8dffc84304a2513a34fded47cb90a3aec779","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-03-21 15:12:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6926d235b296ac867a4e6273691097b4431daa57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 15:17:43.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23981/3/check/gate-python-openstackclient-pep8/303 : SUCCESS\n- http://logs.openstack.org/23981/3/check/gate-python-openstackclient-docs/227 : SUCCESS\n- http://logs.openstack.org/23981/3/check/gate-python-openstackclient-python26/295 : SUCCESS\n- gate-python-openstackclient-python26-rhel6 : LOST (non-voting)\n- http://logs.openstack.org/23981/3/check/gate-python-openstackclient-python27/299 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"219050a5062abeb633c9ef38ab796487eb71fc70","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-21 19:38:40.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nThanks Steve, I think this will be cleaner.","accounts_in_message":[],"_revision_number":3},{"id":"68a485b6c045002ce084a5bdafb6ca8348415277","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-03-21 20:35:43.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8d6bf6892127418c7db3e5d4086f4080746ed0a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 20:35:47.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"8aaf36a27a0a5284c95983c41ac14a5e65574c29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 20:39:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"ba8b010fdb061e324276e65b441b2cba8cbd5e43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 20:39:50.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23981/3/gate/gate-python-openstackclient-docs/229 : SUCCESS\n- http://logs.openstack.org/23981/3/gate/gate-python-openstackclient-pep8/305 : SUCCESS\n- http://logs.openstack.org/23981/3/gate/gate-python-openstackclient-python26/297 : SUCCESS\n- http://logs.openstack.org/23981/3/gate/gate-python-openstackclient-python27/301 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b175184f239d3933435045505750c0fa1cd8cc0c","revisions":{"865db4171ffcb3a240661b8bbd9353ca46fe1788":{"kind":"REWORK","_number":1,"created":"2013-03-09 06:11:58.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/81/23981/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/81/23981/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/1"}}},"commit":{"parents":[{"commit":"0c252b615d235e2cc5138cafbd873101115800ae","subject":"Merge \"add domain, credential to identity v3 api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0c252b615d235e2cc5138cafbd873101115800ae"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-09 06:10:05.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-09 06:10:05.000000000","tz":-360},"subject":"Add extra-specs support for volume-type","message":"Add extra-specs support for volume-type\n\nJust noticed there is an option in cinder for a command called\nextra-specs-list, only relates to volume-types, to list the\nmeta-data key/value pair. Added that functionality.\nAlso made minor changes so delete/set/unset can be called by name.\n\nChange-Id: If534ccd1d8a3abc6d235c60ec9a964b88e3fa66d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/865db4171ffcb3a240661b8bbd9353ca46fe1788"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/865db4171ffcb3a240661b8bbd9353ca46fe1788"}]},"branch":"refs/heads/master"},"f7c65c8fd5e93a548b126046598c76021278459d":{"kind":"REWORK","_number":2,"created":"2013-03-10 03:57:16.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/81/23981/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/81/23981/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/2"}}},"commit":{"parents":[{"commit":"0c252b615d235e2cc5138cafbd873101115800ae","subject":"Merge \"add domain, credential to identity v3 api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0c252b615d235e2cc5138cafbd873101115800ae"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-09 06:10:05.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-10 03:56:41.000000000","tz":-360},"subject":"Add extra-specs support for volume-type","message":"Add extra-specs support for volume-type\n\nchanged command to --long, added a formatter for key\u003dvalue\nJust noticed there is an option in cinder for a command called\nextra-specs-list, only relates to volume-types, to list the\nmeta-data key/value pair. Added that functionality.\nAlso made minor changes so delete/set/unset can be called by name.\n\nChange-Id: If534ccd1d8a3abc6d235c60ec9a964b88e3fa66d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7c65c8fd5e93a548b126046598c76021278459d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f7c65c8fd5e93a548b126046598c76021278459d"}]},"branch":"refs/heads/master"},"b175184f239d3933435045505750c0fa1cd8cc0c":{"kind":"REWORK","_number":3,"created":"2013-03-21 15:12:30.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/81/23981/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/81/23981/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/81/23981/3"}}},"commit":{"parents":[{"commit":"95c6e5f11d22ac34d73170e071aceaae6680847b","subject":"Add endpoint v3 functionality","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/95c6e5f11d22ac34d73170e071aceaae6680847b"}]}],"author":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-09 06:10:05.000000000","tz":-360},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2013-03-21 15:12:10.000000000","tz":-300},"subject":"Add extra-specs support for volume-type","message":"Add extra-specs support for volume-type\n\nchanged to volume-type\nchanged command to --long, added a formatter for key\u003dvalue\nJust noticed there is an option in cinder for a command called\nextra-specs-list, only relates to volume-types, to list the\nmeta-data key/value pair. Added that functionality.\nAlso made minor changes so delete/set/unset can be called by name.\n\nChange-Id: If534ccd1d8a3abc6d235c60ec9a964b88e3fa66d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b175184f239d3933435045505750c0fa1cd8cc0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b175184f239d3933435045505750c0fa1cd8cc0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}