)]}'
{"openstackclient/compute/v2/console.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"da1446afbc2a62bf5c910cfdb9d00a3eccbd8823","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        assert(int(line) \u003e\u003d 0)"},{"line_number":32,"context_line":"    except Exception:"},{"line_number":33,"context_line":"        raise argparse.ArgumentTypeError("},{"line_number":34,"context_line":"            \"Line number must be a positive integer or zero\")"},{"line_number":35,"context_line":"    return int(line)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_e2b5667e","line":34,"updated":"2015-11-08 04:42:06.000000000","message":"add tests to validate this new check?","commit_id":"0afdc0bd99e1d6c6c28a89ea02a173353f58b10c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4d180f491ef750e4e7106d8f5314ad240c12952","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstackclient.common import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def check_negative(line):"},{"line_number":30,"context_line":"    try:"},{"line_number":31,"context_line":"        assert(int(line) \u003e\u003d 0)"},{"line_number":32,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_93c140e7","line":29,"updated":"2015-11-09 07:30:59.000000000","message":"i\u0027d rather see this as a new parserAction, like these: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/parseractions.py\n\nthis way we can keep `type\u003dint`, and the action should just validate that the value is \u003e\u003d 0","commit_id":"e69718eeadff02c0747ecda49614901f043de270"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"f832e41d3477a8fceff2c8e148309e17405476a7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstackclient.common import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def check_negative(line):"},{"line_number":30,"context_line":"    try:"},{"line_number":31,"context_line":"        assert(int(line) \u003e\u003d 0)"},{"line_number":32,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_275cca4a","line":29,"in_reply_to":"da85f559_93c140e7","updated":"2015-11-09 09:29:02.000000000","message":"Done","commit_id":"e69718eeadff02c0747ecda49614901f043de270"}]}