)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b3a9056624d41bd1a30b9c5aea8c51c8c5a8ee41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix inappropriate error message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"show action with name argument returns \u0027Could not find resource\u0027 error"},{"line_number":10,"context_line":"even when name object exists but not authorized."},{"line_number":11,"context_line":"This patch fixes it to return appropriate error message."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_73c133e4","line":9,"updated":"2015-11-16 22:13:23.000000000","message":"From a security perspective, the existence of resources should not be leaked to users not authorized.","commit_id":"ac8faeee5f76d0f69b2772f1e7d32b91194bad87"}],"openstackclient/common/utils.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8050ebf9c3539b4316b713d214117b6a97c68886","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # in case the list fails for some reason"},{"line_number":137,"context_line":"        raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    # if we hit here, we\u0027ve failed, report back this error:"},{"line_number":140,"context_line":"    msg \u003d \"Could not find resource %s\" % name_or_id"},{"line_number":141,"context_line":"    raise exceptions.CommandError(msg)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_40d0961f","line":139,"updated":"2015-11-05 12:37:58.000000000","message":"if we\u0027re going to raise at line 137, then we can delete this block","commit_id":"5ea7b1acaa4a7fd06b223abbc01aa39688836c02"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"95ffe4d1477bd54dfcd8c3765cc2e19597de03d5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # in case the list fails for some reason"},{"line_number":137,"context_line":"        raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    # if we hit here, we\u0027ve failed, report back this error:"},{"line_number":140,"context_line":"    msg \u003d \"Could not find resource %s\" % name_or_id"},{"line_number":141,"context_line":"    raise exceptions.CommandError(msg)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ebec1f2b","line":139,"in_reply_to":"fa80f949_40d0961f","updated":"2015-11-10 00:33:06.000000000","message":"Deleting this block broke test.\nSo, this block move to L134 as in patch set 2.","commit_id":"5ea7b1acaa4a7fd06b223abbc01aa39688836c02"},{"author":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"change_message_id":"f49cfd14b0ea6f41eefcf2b64babf731fe26bd02","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    resource.get(\u0027name\u0027) \u003d\u003d name_or_id):"},{"line_number":131,"context_line":"                return resource"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            # if we hit here, we\u0027ve failed, report back this error:"},{"line_number":134,"context_line":"            msg \u003d \"Could not find resource %s\" % name_or_id"},{"line_number":135,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_1317d948","line":133,"updated":"2015-11-12 08:58:46.000000000","message":"Since the cause is known, I think that \"if we hit here,\" should not use.\nSo, I think should be such as a comment below.\n”we found no match, we\u0027ve failed, report back this error.\"","commit_id":"e697edaa4f5da4c8f32f232e344aeca3cafe46f0"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"adf40a52c995609835d8f8d558235f9ab09343d1","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    resource.get(\u0027name\u0027) \u003d\u003d name_or_id):"},{"line_number":131,"context_line":"                return resource"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            # if we hit here, we\u0027ve failed, report back this error:"},{"line_number":134,"context_line":"            msg \u003d \"Could not find resource %s\" % name_or_id"},{"line_number":135,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a8cdfd87","line":133,"in_reply_to":"da85f559_1317d948","updated":"2015-11-13 04:54:04.000000000","message":"I updated to  ”we found no match, report back this error.\"","commit_id":"e697edaa4f5da4c8f32f232e344aeca3cafe46f0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f3b62fe0ba9f6c8d5edbf2099fc46bed94346781","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            pass"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    for resource in manager.list():"},{"line_number":104,"context_line":"        # short circuit and return the first match"},{"line_number":105,"context_line":"        if (resource.get(\u0027id\u0027) \u003d\u003d name_or_id or"},{"line_number":106,"context_line":"                resource.get(\u0027name\u0027) \u003d\u003d name_or_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_45be90ff","line":103,"updated":"2016-03-31 18:15:43.000000000","message":"A unit test would be nice","commit_id":"8e813e5c71f1cbcf253dc4ffca1e446e4afc81f3"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"5a9005d20deb66f8c142351ea168a2ae485f8db2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            pass"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    for resource in manager.list():"},{"line_number":104,"context_line":"        # short circuit and return the first match"},{"line_number":105,"context_line":"        if (resource.get(\u0027id\u0027) \u003d\u003d name_or_id or"},{"line_number":106,"context_line":"                resource.get(\u0027name\u0027) \u003d\u003d name_or_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_fbae327f","line":103,"in_reply_to":"ba0121b8_45be90ff","updated":"2016-04-01 16:35:53.000000000","message":"Done","commit_id":"8e813e5c71f1cbcf253dc4ffca1e446e4afc81f3"}]}
