)]}'
{"openstackclient/volume/v2/volume_type.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eaa94b54d273c6bd4ad76381b40b13410a3bac3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"--description\","},{"line_number":42,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":43,"context_line":"            help\u003d\"New volume type description\","},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        public_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":46,"context_line":"        public_group.add_argument("},{"line_number":47,"context_line":"            \"--public\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c825dcc2","line":44,"updated":"2015-11-08 19:52:31.000000000","message":"we should take this opportunity to clean this up, we should make it so only parsed_args.public is needed, take a look at: https://github.com/openstack/python-openstackclient/blob/4759a84703cabbbc2449281e1b34dbf43da9bad4/openstackclient/compute/v2/service.py#L77-L89\n\nwe should also default this to public by default","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"e98a3a69102d84940c73adbaa7d7509254a7d4a8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"--description\","},{"line_number":42,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":43,"context_line":"            help\u003d\"New volume type description\","},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        public_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":46,"context_line":"        public_group.add_argument("},{"line_number":47,"context_line":"            \"--public\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4fd9d7f2","line":44,"in_reply_to":"da85f559_c825dcc2","updated":"2015-11-09 14:07:20.000000000","message":"Done","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eaa94b54d273c6bd4ad76381b40b13410a3bac3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        volume_client \u003d self.app.client_manager.volume"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        kwargs \u003d {}"},{"line_number":75,"context_line":"        if parsed_args.public:"},{"line_number":76,"context_line":"            kwargs[\u0027is_public\u0027] \u003d True"},{"line_number":77,"context_line":"        if parsed_args.private:"},{"line_number":78,"context_line":"            kwargs[\u0027is_public\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_2817c852","line":75,"updated":"2015-11-08 19:52:31.000000000","message":"we can remove most of this block with just:\n\n  kwargs[\u0027is_public\u0027] \u003d parsed_args.public\n\nonce the commands are cleaned up","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"e98a3a69102d84940c73adbaa7d7509254a7d4a8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        volume_client \u003d self.app.client_manager.volume"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        kwargs \u003d {}"},{"line_number":75,"context_line":"        if parsed_args.public:"},{"line_number":76,"context_line":"            kwargs[\u0027is_public\u0027] \u003d True"},{"line_number":77,"context_line":"        if parsed_args.private:"},{"line_number":78,"context_line":"            kwargs[\u0027is_public\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_efe52ba8","line":75,"in_reply_to":"da85f559_2817c852","updated":"2015-11-09 14:07:20.000000000","message":"Done","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eaa94b54d273c6bd4ad76381b40b13410a3bac3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    formatters\u003d{\u0027Extra Specs\u0027: utils.format_dict},"},{"line_number":143,"context_line":"                ) for s in data))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class SetVolumeType(command.Command):"},{"line_number":147,"context_line":"    \"\"\"Set volume type properties\"\"\""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4b26c6bb","line":145,"updated":"2015-11-08 19:52:31.000000000","message":"oh no, no support for public|private for set :(","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"e98a3a69102d84940c73adbaa7d7509254a7d4a8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    formatters\u003d{\u0027Extra Specs\u0027: utils.format_dict},"},{"line_number":143,"context_line":"                ) for s in data))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class SetVolumeType(command.Command):"},{"line_number":147,"context_line":"    \"\"\"Set volume type properties\"\"\""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6f9ffb03","line":145,"in_reply_to":"da85f559_4b26c6bb","updated":"2015-11-09 14:07:20.000000000","message":"I think this place dose not need to be changed. It is set extra specs here, not the access.","commit_id":"22a1fbb3258bb996376fdf27d63b76ac19e48372"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"374634eca2821e925a642a9e70eaed64e38a757e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":43,"context_line":"            help\u003d\"New volume type description\","},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \"--public\","},{"line_number":47,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":48,"context_line":"            default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_18dc72e3","line":45,"updated":"2015-11-09 16:01:21.000000000","message":"close, but we shouldn\u0027t/can\u0027t remove the --private option, since we\u0027ll break backwards compatibility.\n\n        public_group \u003d parser.add_mutually_exclusive_group()\n        public_group.add_argument(\n            \"--public\",\n            dest\u003d\"public\",\n            default\u003dTrue,\n            help\u003d\"Volume type is accessible to the public\",\n            action\u003d\"store_true\")\n        public_group.add_argument(\n            \"--private\",\n            dest\u003d\"public\",\n            help\u003d\"Volume type is not accessible to the public\",\n            action\u003d\"store_false\")","commit_id":"7a5db5036efbbe9981836417f49f932134adeab3"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"d00b3d6c123c1fab6ee87fce68af75b8128690a7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":43,"context_line":"            help\u003d\"New volume type description\","},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \"--public\","},{"line_number":47,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":48,"context_line":"            default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e98e2778","line":45,"in_reply_to":"da85f559_18dc72e3","updated":"2015-11-11 05:49:47.000000000","message":"Done. Really thank you, Steve!","commit_id":"7a5db5036efbbe9981836417f49f932134adeab3"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"fe66b2e621ba539d98522119ead819f491569829","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            action\u003d\"store_true\")"},{"line_number":52,"context_line":"        public_group.add_argument("},{"line_number":53,"context_line":"            \"--private\","},{"line_number":54,"context_line":"            dest\u003d\"public\","},{"line_number":55,"context_line":"            help\u003d\"Volume type is not accessible to the public\","},{"line_number":56,"context_line":"            action\u003d\"store_false\")"},{"line_number":57,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e4608ed1","line":54,"updated":"2015-11-11 06:22:45.000000000","message":"I think the dest here is \"private\"","commit_id":"5de1b853f66604c65564278088721856efc994dd"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"46e30a1b7e2e90b94aedb972404a99e3bdee6b1f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            action\u003d\"store_true\")"},{"line_number":52,"context_line":"        public_group.add_argument("},{"line_number":53,"context_line":"            \"--private\","},{"line_number":54,"context_line":"            dest\u003d\"public\","},{"line_number":55,"context_line":"            help\u003d\"Volume type is not accessible to the public\","},{"line_number":56,"context_line":"            action\u003d\"store_false\")"},{"line_number":57,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_c40b0a8d","line":54,"in_reply_to":"da85f559_44ce3a83","updated":"2015-11-11 06:40:08.000000000","message":"Done","commit_id":"5de1b853f66604c65564278088721856efc994dd"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"4a4d563c00c508d283c055905b85861f2a8a50cf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            action\u003d\"store_true\")"},{"line_number":52,"context_line":"        public_group.add_argument("},{"line_number":53,"context_line":"            \"--private\","},{"line_number":54,"context_line":"            dest\u003d\"public\","},{"line_number":55,"context_line":"            help\u003d\"Volume type is not accessible to the public\","},{"line_number":56,"context_line":"            action\u003d\"store_false\")"},{"line_number":57,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_44ce3a83","line":54,"in_reply_to":"da85f559_e4608ed1","updated":"2015-11-11 06:34:12.000000000","message":"Hi Rong,\n\nYou could have a look at the comment from Steve on patch set 1. The dest here is set to \u0027public\u0027, because we want to remove the \u0027private\u0027 dest.","commit_id":"5de1b853f66604c65564278088721856efc994dd"}]}