)]}'
{"id":"openstack%2Fpython-openstackclient~243393","triplet_id":"openstack%2Fpython-openstackclient~master~Ia6603855fc480af129e7fb5c265b61dbae2fa604","project":"openstack/python-openstackclient","branch":"master","topic":"reset-state","hashtags":[],"change_id":"Ia6603855fc480af129e7fb5c265b61dbae2fa604","subject":"Add \"server reset state\" command to osc.","status":"ABANDONED","created":"2015-11-10 02:48:48.000000000","updated":"2016-05-30 03:01:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"35d99ea83c8d96d70a21c4662be9615d05cc93c0","_number":243393,"virtual_id_number":243393,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2016-01-27 00:40:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"date":"2015-11-10 07:32:51.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":-1,"date":"2015-11-12 17:43:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-11-11 03:08:37.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-05-28 06:51:11.000000000","_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"date":"2015-11-11 03:08:26.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-11 03:08:26.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-11-11 03:08:37.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-12 17:43:43.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-01-27 00:40:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-05-28 06:51:11.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"}],"messages":[{"id":"9fdbb8e3df38770540e3b970d1cb530dd3920e11","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-10 02:48:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f497311f8ff28190267daa477a2a140800c6a04d","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-10 02:52:45.000000000","message":"Patch Set 1:\n\nBecause there are some problems in the current unit test framework, as BP [1] described, this patch doesn\u0027t add test cases for the new command. The tests will be added as this BP [1] going on.\n\n[1] https://blueprints.launchpad.net/python-openstackclient/+spec/osc-unit-test-framework-improvement","accounts_in_message":[],"_revision_number":1},{"id":"5de591dbf966794759897d37edd2ccdc85971c0c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 03:54:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python26/6639e8c/ : SUCCESS in 5m 09s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-pep8/f5293b9/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/243393/1/check/gate-python-openstackclient-docs/fd5df0f//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python27/037084d/ : SUCCESS in 2m 01s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python34/187cfca/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/243393/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/87cab03/ : SUCCESS in 1h 05m 24s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/243393/1/check/gate-osc-dsvm-functional/abdeb7b/ : FAILURE in 21m 19s","accounts_in_message":[],"_revision_number":1},{"id":"0c8f0d7be9af657e329b313c414b3a1f3148bce5","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-10 04:10:36.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6b7d420aa0b859005b60fa3625b25b2b7851e4b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 05:25:32.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python26/deffa33/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-pep8/7dc5cd7/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/243393/1/check/gate-python-openstackclient-docs/62d9e96//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python27/508e854/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/243393/1/check/gate-python-openstackclient-python34/7e3d0c4/ : SUCCESS in 1m 50s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/243393/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/70801b0/ : FAILURE in 1h 14m 49s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/243393/1/check/gate-osc-dsvm-functional/8e574f6/ : FAILURE in 30m 24s","accounts_in_message":[],"_revision_number":1},{"id":"10a9b9c0902d6ffddd6d67f46a02c167d5f2b4f3","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-10 05:51:48.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"e35615b4d66c6b0438e6df1859b4febb259956ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 06:37:54.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python26/d5e2b46/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-pep8/451c052/ : SUCCESS in 1m 00s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/243393/2/check/gate-python-openstackclient-docs/144376a//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python27/f1feff2/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python34/3d96b06/ : SUCCESS in 1m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/243393/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/3dbae37/ : FAILURE in 24m 08s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/243393/2/check/gate-osc-dsvm-functional/95a6af4/ : FAILURE in 45m 10s","accounts_in_message":[],"_revision_number":2},{"id":"63678728db01ab999c9baa423984b263b9291a20","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-10 07:32:51.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"3d40d4f2fc82cad4de54f171fc75a9a5b587cfce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 08:51:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python26/ef35373/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-pep8/c44a022/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/243393/2/check/gate-python-openstackclient-docs/b7d7bd9//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python27/5241267/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/243393/2/check/gate-python-openstackclient-python34/2a423ad/ : SUCCESS in 2m 56s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/243393/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0d462a2/ : SUCCESS in 1h 16m 37s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/243393/2/check/gate-osc-dsvm-functional/ac51205/ : SUCCESS in 31m 07s","accounts_in_message":[],"_revision_number":2},{"id":"4596e7cd7fa5e44f7d2c1a2c37a10decc097d46e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-11-12 17:43:43.000000000","message":"Patch Set 2: Code-Review-1\n\nI think the state of the VM is a property of the server, not a resource.  This really should be\"\n\n  server set --state reset\n\nor something similar.\n\n--state may need to be more specific if a server has more than one state property.","accounts_in_message":[],"_revision_number":2},{"id":"92e577dab6a19201157dc1a6cb23896b1859e15c","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-13 04:17:54.000000000","message":"Patch Set 2:\n\nHi Dean,\n\nAbout the cmd design,\n\n1. What does property mean here ?  Seeing from the code, the property \u003d\u003d metadata. But vm_state is not in instance metadata.\n\n2. I think root password is not a property of an instance either. It depends on OS. For example, in Windows, it is called administrator password. (Here, I think we can change it to admin password. On this point, novaclient is better.)\n\nSo should the direction be that \"server set\" will be used to set anything setable to an instance ?\n\nI think, shall we introduce two commands: set-property and set-metadata.\n- set-property: set instance properties (set state here)\n- set-metadata: set instance metadata\n\n3. Indeed, there are vm_state, power_state, task_state in an instance. But power_state and task_state should not be setable to users. They are maintained by Nova.\n\nThx. :)","accounts_in_message":[],"_revision_number":2},{"id":"591a7fbe14773ebc7c1e4142a481e89c5d758f05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 00:40:45.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"9c40652b74f8f90ffd9681df1bd81165c16e1cf9","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-05-28 08:32:57.000000000","message":"Patch Set 2:\n\nHi Tang Chen:\n\nset server state is very important command for us, I see latest update of the patch is at 4 months ago, so I\u0027m ready to push a new patch to implement the command, and I think implementing it in blueprint cmd-with-multi-servsers looks not exact, so I draft a new BP to ship it.\n\nhttps://blueprints.launchpad.net/python-openstackclient/+spec/server-reset-state","accounts_in_message":[],"_revision_number":2},{"id":"acb85e874cd992fc5878bc31aa2585e30d5fc541","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-30 03:01:20.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"307cca4a2addd38dd94f7c404272ab68164c0719","revisions":{"5fa7f5ca051dd6b8484a72a0eb0830c8b98d6ed8":{"kind":"REWORK","_number":1,"created":"2015-11-10 02:48:48.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/243393/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/243393/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/1"}}},"commit":{"parents":[{"commit":"a337f664d23cea334be4618a0049a9f124df777c","subject":"Enable \"openstack server pause\" command to take multiple servers.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a337f664d23cea334be4618a0049a9f124df777c"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-10 06:55:15.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-11 01:38:19.000000000","tz":480},"subject":"Add \"server reset state\" command to osc.","message":"Add \"server reset state\" command to osc.\n\nThere is no \"reset-state\" command in osc. If the instance is in error state,\nthere is no way to reset it back to active. This patch adds the command.\n\nIn this patch, a server\u0027s \"state\" is seen as a new type of object, and \"reset\"\nis seen as a new action. And following the \"object-1 action object-2\" rule,\nthe command can be used like this: \"osc server reset state XXX\".\n\nChange-Id: Ia6603855fc480af129e7fb5c265b61dbae2fa604\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5fa7f5ca051dd6b8484a72a0eb0830c8b98d6ed8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5fa7f5ca051dd6b8484a72a0eb0830c8b98d6ed8"}]},"branch":"refs/heads/master"},"307cca4a2addd38dd94f7c404272ab68164c0719":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-11-10 05:51:48.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/243393/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/243393/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/243393/2"}}},"commit":{"parents":[{"commit":"a337f664d23cea334be4618a0049a9f124df777c","subject":"Enable \"openstack server pause\" command to take multiple servers.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a337f664d23cea334be4618a0049a9f124df777c"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-10 06:55:15.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-10 05:51:48.000000000","tz":0},"subject":"Add \"server reset state\" command to osc.","message":"Add \"server reset state\" command to osc.\n\nThere is no \"reset-state\" command in osc. If the instance is in error state,\nthere is no way to reset it back to active. This patch adds the command.\n\nIn this patch, a server\u0027s \"state\" is seen as a new type of object, and \"reset\"\nis seen as a new action. And following the \"object-1 action object-2\" rule,\nthe command can be used like this: \"osc server reset state XXX\".\n\nChange-Id: Ia6603855fc480af129e7fb5c265b61dbae2fa604\nImplements: blueprint cmd-with-multi-servers\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/307cca4a2addd38dd94f7c404272ab68164c0719"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/307cca4a2addd38dd94f7c404272ab68164c0719"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}