)]}'
{"id":"openstack%2Fpython-openstackclient~244479","triplet_id":"openstack%2Fpython-openstackclient~master~I0adc559e48d5074a615ea1f6f4823451a5d209a2","project":"openstack/python-openstackclient","branch":"master","topic":"Tiny_coding_style_fix","hashtags":[],"change_id":"I0adc559e48d5074a615ea1f6f4823451a5d209a2","subject":"A tiny fix for coding style","status":"ABANDONED","created":"2015-11-12 07:34:33.000000000","updated":"2015-11-13 05:18:40.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"69dcab498453d6d8b870680b12352630b11a6652","_number":244479,"virtual_id_number":244479,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-11-13 05:16:17.000000000","_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-11-12 09:30:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":-1,"date":"2015-11-12 14:00:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-12 08:19:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},{"value":-1,"date":"2015-11-12 18:28:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-12 08:19:18.000000000","updated_by":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"reviewer":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"state":"REVIEWER"},{"updated":"2015-11-12 09:30:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-12 14:00:36.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-12 18:28:22.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"63799df60611c2a5383d4556ad4cc0667194f2ee","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-12 07:34:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa48d62bd918cdf15fd06fd7e04bbd7fe08ffc71","author":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"date":"2015-11-12 07:57:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nSorry.\nMy comment of the previous review was insufficient.","accounts_in_message":[],"_revision_number":1},{"id":"3d454f3cb7ca00b1f465271efe58700f15305061","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-12 08:12:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7d3cdd22c64fbbfd153a5067811b9c89377a214f","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-12 08:14:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"82f473d51332a18c5a6795266b214516f13293c7","author":{"_account_id":18835,"name":"Toshiya Shiga","email":"tos-shiga@yk.jp.nec.com","username":"tos-shiga"},"date":"2015-11-12 08:19:18.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks!\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"86591349620d17f734e5f099fbf21eaf31a6357e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 09:30:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/79/244479/2/check/gate-python-openstackclient-python26/3326cf1/ : FAILURE in 1m 13s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/79/244479/2/check/gate-python-openstackclient-pep8/73e074f/ : FAILURE in 1m 09s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/79/244479/2/check/gate-python-openstackclient-docs/5d43e70//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-openstackclient-python27 http://logs.openstack.org/79/244479/2/check/gate-python-openstackclient-python27/7c20eaf/ : FAILURE in 1m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/79/244479/2/check/gate-python-openstackclient-python34/4cbc7e5/ : FAILURE in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/79/244479/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/57f903e/ : SUCCESS in 1h 13m 50s\n- gate-osc-dsvm-functional http://logs.openstack.org/79/244479/2/check/gate-osc-dsvm-functional/22efe51/ : SUCCESS in 21m 48s","accounts_in_message":[],"_revision_number":2},{"id":"089078b983116b9323d66f23ee55431768e18970","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-12 14:00:36.000000000","message":"Patch Set 2: Code-Review-1\n\nlooks like it\u0027s invalid syntax, i guess cause it\u0027s after kwargs","accounts_in_message":[],"_revision_number":2},{"id":"fcf2e0dd1fb5fca43fd2669dc87dca5fecfe95e9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-11-12 18:28:22.000000000","message":"Patch Set 2: Code-Review-1\n\nyeah, while I would love for this to work, it isn\u0027t actually legal following a *x or **x argument.","accounts_in_message":[],"_revision_number":2},{"id":"2b9f18b7a6efbee490743ffe1513d48592a8f586","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-13 05:16:17.000000000","message":"Patch Set 2:\n\nThis patch teaches me a python rule :) \n  The **kwargs must always be the last parameters.","accounts_in_message":[],"_revision_number":2},{"id":"e216e7893d6af0d8fd4ea00e2c8b132ae52d1de6","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-13 05:18:40.000000000","message":"Abandoned\n\nNo need to add trailing comma behind the last **kwargs.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"50a70acbf6fd278187c28f2810fffe2fe700839b","revisions":{"bb0e93cdba425b148022e3f488ded62a9edb68b7":{"kind":"REWORK","_number":1,"created":"2015-11-12 07:34:33.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/79/244479/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/79/244479/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/1"}}},"commit":{"parents":[{"commit":"c39708beff9640dd77617e7d49486f936ad5912b","subject":"Merge \"Trivial: Fix wrong param name in comment.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c39708beff9640dd77617e7d49486f936ad5912b"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-12 07:26:39.000000000","tz":-300},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-12 07:26:45.000000000","tz":-300},"subject":"A tiny fix for coding style","message":"A tiny fix for coding style\n\nAdd a last trailing comma is optional but good coding style\n\nChange-Id: I0adc559e48d5074a615ea1f6f4823451a5d209a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bb0e93cdba425b148022e3f488ded62a9edb68b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bb0e93cdba425b148022e3f488ded62a9edb68b7"}]},"branch":"refs/heads/master"},"50a70acbf6fd278187c28f2810fffe2fe700839b":{"kind":"REWORK","_number":2,"created":"2015-11-12 08:14:27.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/79/244479/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/79/244479/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/79/244479/2"}}},"commit":{"parents":[{"commit":"c39708beff9640dd77617e7d49486f936ad5912b","subject":"Merge \"Trivial: Fix wrong param name in comment.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c39708beff9640dd77617e7d49486f936ad5912b"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-12 07:26:39.000000000","tz":-300},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-12 08:08:39.000000000","tz":-300},"subject":"A tiny fix for coding style","message":"A tiny fix for coding style\n\nAdd a last trailing comma is optional but good coding style\n\nChange-Id: I0adc559e48d5074a615ea1f6f4823451a5d209a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/50a70acbf6fd278187c28f2810fffe2fe700839b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/50a70acbf6fd278187c28f2810fffe2fe700839b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}