)]}'
{"id":"openstack%2Fpython-openstackclient~247967","triplet_id":"openstack%2Fpython-openstackclient~master~I8ffc8e233f8710034329ed33fccb2c734898ec2d","project":"openstack/python-openstackclient","branch":"master","topic":"bp/osc-unit-test-framework-improvement","hashtags":[],"change_id":"I8ffc8e233f8710034329ed33fccb2c734898ec2d","subject":"Use class FakeServer in TestServerCreate.","status":"MERGED","created":"2015-11-20 08:34:51.000000000","updated":"2015-11-25 01:49:20.000000000","submitted":"2015-11-25 01:49:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"204918770b8076cc4cb89dfbfe021c91102a9f41","_number":247967,"virtual_id_number":247967,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-11-25 01:49:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-11-25 00:03:29.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-11-23 05:08:09.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-24 22:22:29.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-24 22:22:29.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"date":"2015-11-20 11:37:00.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-20 11:37:00.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-11-23 05:08:09.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-24 22:22:29.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-11-25 01:49:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c74c6fdb4d6af3b4aa48cbad43c92b1fb448c374","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-20 08:34:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"04273b83c71c94dbe8e5b9989c15c1856661e2e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-20 09:33:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/67/247967/1/check/gate-python-openstackclient-python26/a222be4/ : SUCCESS in 3m 19s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/67/247967/1/check/gate-python-openstackclient-pep8/c50ad9f/ : FAILURE in 1m 03s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/67/247967/1/check/gate-python-openstackclient-docs/7a2ae72//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-openstackclient-python27 http://logs.openstack.org/67/247967/1/check/gate-python-openstackclient-python27/c2ff192/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/67/247967/1/check/gate-python-openstackclient-python34/201b740/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/67/247967/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7c548b6/ : SUCCESS in 56m 24s\n- gate-osc-dsvm-functional http://logs.openstack.org/67/247967/1/check/gate-osc-dsvm-functional/fc4b3d0/ : SUCCESS in 29m 04s","accounts_in_message":[],"_revision_number":1},{"id":"96bc679c0ce0315990c0488f838fc3704ce5bcf6","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-20 09:50:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"aa78b37803c0eb8762d55eff50db66e7b0b72eb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-20 11:17:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python26/2c999a7/ : SUCCESS in 2m 14s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-pep8/8589579/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/67/247967/2/check/gate-python-openstackclient-docs/ce230be//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-python27 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python27/84fb56c/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python34/7fa2640/ : SUCCESS in 1m 55s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/67/247967/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e57d9e8/ : SUCCESS in 1h 14m 12s\n- gate-osc-dsvm-functional http://logs.openstack.org/67/247967/2/check/gate-osc-dsvm-functional/dfd2597/ : SUCCESS in 34m 44s","accounts_in_message":[],"_revision_number":2},{"id":"6842c9d42eb2334ed1541474353a596639cc6991","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-23 05:08:09.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1e9d1e0c41a7e26f15bc54db4735f3a95914bb81","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-11-24 22:22:29.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9b47bde0bf88b6d4c2743600753db99a38b1fd0f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-24 22:22:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d31bd0c79d4e837e554b701f3aa48a7f144d5136","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-24 23:34:45.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python26/1e2a554/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/67/247967/2/gate/gate-python-openstackclient-docs/e75e547//doc/build/html/ : SUCCESS in 2m 11s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-pep8/7ffc2c2/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-python27 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python27/064f740/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python34/4b16255/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/67/247967/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a74889e/ : SUCCESS in 1h 12m 06s\n- gate-osc-dsvm-functional http://logs.openstack.org/67/247967/2/gate/gate-osc-dsvm-functional/e71945a/ : FAILURE in 21m 29s","accounts_in_message":[],"_revision_number":2},{"id":"1479c410619d5c27c230d14a5dbf67dad02885eb","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-25 00:03:29.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"fe512bee8fe4a293d4c0986e59b2f5490bdf3a63","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 00:57:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python26/2f5509f/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-pep8/ede0e5e/ : SUCCESS in 1m 04s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/67/247967/2/check/gate-python-openstackclient-docs/f3a5856//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-openstackclient-python27 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python27/fdba7d8/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-python34 http://logs.openstack.org/67/247967/2/check/gate-python-openstackclient-python34/8a5807f/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/67/247967/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/9a1d1f1/ : SUCCESS in 52m 00s\n- gate-osc-dsvm-functional http://logs.openstack.org/67/247967/2/check/gate-osc-dsvm-functional/89a5590/ : SUCCESS in 23m 47s","accounts_in_message":[],"_revision_number":2},{"id":"ddf6df80cc0e0902f1c1770c48103bb11a2b272c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 00:57:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"38bd2723778bece1a472b4bf05c6e045a74a7f22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 01:49:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python26/e54c74a/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/67/247967/2/gate/gate-python-openstackclient-docs/b5d8027//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-pep8/abaa515/ : SUCCESS in 59s\n- gate-python-openstackclient-python27 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python27/26d459e/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/67/247967/2/gate/gate-python-openstackclient-python34/bf1b320/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/67/247967/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/ba3a586/ : SUCCESS in 51m 56s\n- gate-osc-dsvm-functional http://logs.openstack.org/67/247967/2/gate/gate-osc-dsvm-functional/c7bd13e/ : SUCCESS in 20m 24s","accounts_in_message":[],"_revision_number":2},{"id":"6e09ad2adbf29ac460ac379008ef8cf2da1b7028","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 01:49:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"815cd8a1991b88511e6a6afca926a3c104e9e7a8","revisions":{"0ec12c74c98bf44a37eaf1429345e071ec19d376":{"kind":"REWORK","_number":1,"created":"2015-11-20 08:34:51.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/67/247967/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/67/247967/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/1"}}},"commit":{"parents":[{"commit":"65e6c7bc63d1a2137ae454f792b17feba7fab9b8","subject":"Merge \"Add unit tests for \"server pause\" command.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/65e6c7bc63d1a2137ae454f792b17feba7fab9b8"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 05:33:20.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 05:33:20.000000000","tz":480},"subject":"Use class FakeServer in TestServerCreate.","message":"Use class FakeServer in TestServerCreate.\n\nIn the current TestServerCreate, there are several problems:\n\n1. The fake create() returns a server with no \u0027networks\u0027 field.\n   The new_server is used to fake the created server which is\n   supposed to be returned by create(), but it has a \u0027networks\u0027\n   field.\n\n   They have the same name and id, but they are actually not\n   the same server.\n\n   As a result, when checking the return value from create(),\n   \u0027networks\u0027 is not checked.\n\n2. The fake server is not accessable in the test functions.\n   So each time a test function wants to get the server name\n   or id, it has to use the constants defined in compute_fakes.\n\n   This is not good. We should make the fake server accessable\n   in all test functions to ensure they actually get the same\n   server.\n\nThis patch fix them both by using the new class FakeServer to\nfake a server.\n\nChange-Id: I8ffc8e233f8710034329ed33fccb2c734898ec2d\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ec12c74c98bf44a37eaf1429345e071ec19d376"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ec12c74c98bf44a37eaf1429345e071ec19d376"}]},"branch":"refs/heads/master"},"815cd8a1991b88511e6a6afca926a3c104e9e7a8":{"kind":"REWORK","_number":2,"created":"2015-11-20 09:50:26.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/67/247967/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/67/247967/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/67/247967/2"}}},"commit":{"parents":[{"commit":"65e6c7bc63d1a2137ae454f792b17feba7fab9b8","subject":"Merge \"Add unit tests for \"server pause\" command.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/65e6c7bc63d1a2137ae454f792b17feba7fab9b8"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 05:33:20.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 05:33:20.000000000","tz":480},"subject":"Use class FakeServer in TestServerCreate.","message":"Use class FakeServer in TestServerCreate.\n\nIn the current TestServerCreate, there are several problems:\n\n1. The fake create() returns a server with no \u0027networks\u0027 field.\n   The new_server is used to fake the created server which is\n   supposed to be returned by create(), but it has a \u0027networks\u0027\n   field.\n\n   They have the same name and id, but they are actually not\n   the same server.\n\n   As a result, when checking the return value from create(),\n   \u0027networks\u0027 is not checked.\n\n2. The fake server is not accessable in the test functions.\n   So each time a test function wants to get the server name\n   or id, it has to use the constants defined in compute_fakes.\n\n   This is not good. We should make the fake server accessable\n   in all test functions to ensure they actually get the same\n   server.\n\nThis patch fix them both by using the new class FakeServer to\nfake a server.\n\nChange-Id: I8ffc8e233f8710034329ed33fccb2c734898ec2d\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/815cd8a1991b88511e6a6afca926a3c104e9e7a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/815cd8a1991b88511e6a6afca926a3c104e9e7a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}