)]}'
{"id":"openstack%2Fpython-openstackclient~247968","triplet_id":"openstack%2Fpython-openstackclient~master~Icdcc90cc93ed1080187fb0edca885b0db56ab35d","project":"openstack/python-openstackclient","branch":"master","topic":"bp/osc-unit-test-framework-improvement","hashtags":[],"change_id":"Icdcc90cc93ed1080187fb0edca885b0db56ab35d","subject":"Use class FakeServer in TestServerDelete.","status":"MERGED","created":"2015-11-20 08:34:51.000000000","updated":"2015-11-25 02:34:11.000000000","submitted":"2015-11-25 02:34:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e90326d4b0a3b473fbdd0669232a2e72e88b581a","_number":247968,"virtual_id_number":247968,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-11-25 02:34:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-11-25 00:05:28.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-11-23 05:08:36.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-24 22:23:02.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-24 22:23:02.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"date":"2015-11-20 11:37:44.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-20 11:37:44.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-11-23 05:08:36.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-24 22:23:02.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-11-25 02:34:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dcf98fea62a11682f6a9167071557924acb49a1c","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-20 08:34:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f4a022fce2191a75a4caa91af2ab842e649a38f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-20 09:50:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3058a51f5035bbe6f4c0192b349afc39394d0f78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-20 10:58:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python26/2ccd93e/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-pep8/9f1947a/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/68/247968/2/check/gate-python-openstackclient-docs/4e328fe//doc/build/html/ : SUCCESS in 2m 29s\n- gate-python-openstackclient-python27 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python27/8a7df5c/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python34/89a7827/ : SUCCESS in 1m 54s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/68/247968/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/462f6ac/ : SUCCESS in 59m 55s\n- gate-osc-dsvm-functional http://logs.openstack.org/68/247968/2/check/gate-osc-dsvm-functional/cb8e05f/ : SUCCESS in 22m 30s","accounts_in_message":[],"_revision_number":2},{"id":"34fc8640629752719c732b319ece71f4a3675c07","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-23 05:08:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2992d69863f9c689c6e73130f20ae71f0d72926f","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-11-24 22:23:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"18532884bca09338a3df48e00dfe939bb68ade4e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-24 22:23:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"6eee715bbc6be715236097e5a4bb534ceee712ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-24 23:35:01.000000000","message":"Patch Set 2: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":2},{"id":"f54f58182974254fd5d0324cbdfdc4fd4a42c0aa","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-25 00:05:28.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"47e7d8db6f5079f7b313ba5120a129fa04cbf96a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 01:20:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python26/b473663/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-pep8/06e4a9a/ : SUCCESS in 1m 08s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/68/247968/2/check/gate-python-openstackclient-docs/c8198a7//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-python27 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python27/0ab8e6e/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/68/247968/2/check/gate-python-openstackclient-python34/202b5a3/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/68/247968/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/92ab765/ : SUCCESS in 1h 11m 20s\n- gate-osc-dsvm-functional http://logs.openstack.org/68/247968/2/check/gate-osc-dsvm-functional/a0545e1/ : SUCCESS in 22m 32s","accounts_in_message":[],"_revision_number":2},{"id":"93680ade74065745f0ca2765fe6177c4e116e115","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 01:20:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"88ef15a9d0e553f1c1709adef68f0f3b20e1c571","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 02:34:10.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/68/247968/2/gate/gate-python-openstackclient-python26/1d24217/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/68/247968/2/gate/gate-python-openstackclient-docs/929330a//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/68/247968/2/gate/gate-python-openstackclient-pep8/540e934/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-python27 http://logs.openstack.org/68/247968/2/gate/gate-python-openstackclient-python27/bee3a58/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-python34 http://logs.openstack.org/68/247968/2/gate/gate-python-openstackclient-python34/d4b69cc/ : SUCCESS in 1m 21s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/68/247968/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a0173cb/ : SUCCESS in 1h 12m 36s\n- gate-osc-dsvm-functional http://logs.openstack.org/68/247968/2/gate/gate-osc-dsvm-functional/a10b5b1/ : SUCCESS in 22m 24s","accounts_in_message":[],"_revision_number":2},{"id":"2679513ea99e8c0f0d080590281f3773b108fb0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 02:34:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1cf5c5525b2402cfa8ab84103f1849dde6d5ce1a","revisions":{"ab285e8e51906b705d45af43a24aad17507c6f88":{"kind":"REWORK","_number":1,"created":"2015-11-20 08:34:51.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/68/247968/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/68/247968/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/1"}}},"commit":{"parents":[{"commit":"0ec12c74c98bf44a37eaf1429345e071ec19d376","subject":"Use class FakeServer in TestServerCreate.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ec12c74c98bf44a37eaf1429345e071ec19d376"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 08:10:48.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 08:10:48.000000000","tz":480},"subject":"Use class FakeServer in TestServerDelete.","message":"Use class FakeServer in TestServerDelete.\n\nThere are the same problems with TestServerCreate in TestServerDelete.\nUse the new class FakeServer to fix them.\n\nChange-Id: Icdcc90cc93ed1080187fb0edca885b0db56ab35d\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab285e8e51906b705d45af43a24aad17507c6f88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab285e8e51906b705d45af43a24aad17507c6f88"}]},"branch":"refs/heads/master"},"1cf5c5525b2402cfa8ab84103f1849dde6d5ce1a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-11-20 09:50:26.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/68/247968/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/68/247968/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/68/247968/2"}}},"commit":{"parents":[{"commit":"815cd8a1991b88511e6a6afca926a3c104e9e7a8","subject":"Use class FakeServer in TestServerCreate.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/815cd8a1991b88511e6a6afca926a3c104e9e7a8"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 08:10:48.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-11-21 09:49:03.000000000","tz":480},"subject":"Use class FakeServer in TestServerDelete.","message":"Use class FakeServer in TestServerDelete.\n\nThere are the same problems with TestServerCreate in TestServerDelete.\nUse the new class FakeServer to fix them.\n\nChange-Id: Icdcc90cc93ed1080187fb0edca885b0db56ab35d\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1cf5c5525b2402cfa8ab84103f1849dde6d5ce1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1cf5c5525b2402cfa8ab84103f1849dde6d5ce1a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}