)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d0d6ae57768a54fb7791ef52c76d93d371f6ad89","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xiexs \u003cxiexs@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-23 22:29:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status and server columns for \"openstack image list\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Actually, the status and server columns is useful for the user."},{"line_number":10,"context_line":"So, it`s better to output these info by default(or, user had"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_332359a9","line":7,"updated":"2015-11-24 03:51:38.000000000","message":"remove server from here\n\n`Add status column to \"openstack image list\"`","commit_id":"a929542a02955d74fcd4a74f430da122adfdbf28"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"76d649def62dca5e83877a5e77c4f930b1cfdec8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xiexs \u003cxiexs@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-23 22:29:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status and server columns for \"openstack image list\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Actually, the status and server columns is useful for the user."},{"line_number":10,"context_line":"So, it`s better to output these info by default(or, user had"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_d33f6d23","line":7,"in_reply_to":"ba8a016a_332359a9","updated":"2015-11-24 04:22:09.000000000","message":"Sorry, i forgot this. Thanks a lot","commit_id":"a929542a02955d74fcd4a74f430da122adfdbf28"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d0d6ae57768a54fb7791ef52c76d93d371f6ad89","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add status and server columns for \"openstack image list\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Actually, the status and server columns is useful for the user."},{"line_number":10,"context_line":"So, it`s better to output these info by default(or, user had"},{"line_number":11,"context_line":"to specify the extra option, i.e. --long)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_933485de","line":9,"updated":"2015-11-24 03:51:38.000000000","message":"and here","commit_id":"a929542a02955d74fcd4a74f430da122adfdbf28"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d0d6ae57768a54fb7791ef52c76d93d371f6ad89","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add status and server columns for \"openstack image list\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Actually, the status and server columns is useful for the user."},{"line_number":10,"context_line":"So, it`s better to output these info by default(or, user had"},{"line_number":11,"context_line":"to specify the extra option, i.e. --long)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id2a9f86f0de5310f8f5ff9a46bf1b7411094b519"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_b32f4987","line":10,"updated":"2015-11-24 03:51:38.000000000","message":"add a space after `default`","commit_id":"a929542a02955d74fcd4a74f430da122adfdbf28"}],"openstackclient/image/v1/image.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ad4edbc398dcaf117718c1e34178f0defc5c5cf9","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        # Always set kwargs[\u0027detailed\u0027] to True, and then filter the columns"},{"line_number":358,"context_line":"        # according to whether the --long option is specified or not."},{"line_number":359,"context_line":"        kwargs[\u0027detailed\u0027] \u003d True"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if parsed_args.long:"},{"line_number":362,"context_line":"            columns \u003d ("},{"line_number":363,"context_line":"                \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_b9234355","line":360,"updated":"2015-11-29 08:26:46.000000000","message":"You could mention that we specifically need to do this to get the status column, otherwise in 6 months when I read this code I wont know why we did this","commit_id":"a2d5fd70a0f73817e369ad9e06b09fac03fd4059"}],"openstackclient/tests/image/v1/test_image.py":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"2084637c87d541678451582471721368853cc7f6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        # DisplayCommandBase.take_action() returns two tuples"},{"line_number":262,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":263,"context_line":"        self.api_mock.image_list.assert_called_with("},{"line_number":264,"context_line":"            detailed\u003dTrue,"},{"line_number":265,"context_line":"            marker\u003dimage_fakes.image_id,"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4c516035","line":264,"updated":"2015-11-27 12:09:04.000000000","message":"Is this needed if you always set it to true?","commit_id":"a2d5fd70a0f73817e369ad9e06b09fac03fd4059"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"82e391ddfe4bdbd182b060a2fadb1478421df33a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        # DisplayCommandBase.take_action() returns two tuples"},{"line_number":262,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":263,"context_line":"        self.api_mock.image_list.assert_called_with("},{"line_number":264,"context_line":"            detailed\u003dTrue,"},{"line_number":265,"context_line":"            marker\u003dimage_fakes.image_id,"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8a2f2887","line":264,"in_reply_to":"9a8ffd7b_4c516035","updated":"2015-11-27 12:28:26.000000000","message":"Yes, just like the comments i added in the line 357 of image.py, we had to let it be true to return the detailed info, and then filter them.\nBut it is only an internal logic above, so it doesn\u0027t matter to end users.","commit_id":"a2d5fd70a0f73817e369ad9e06b09fac03fd4059"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"2084637c87d541678451582471721368853cc7f6","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        datalist \u003d (("},{"line_number":272,"context_line":"            image_fakes.image_id,"},{"line_number":273,"context_line":"            image_fakes.image_name,"},{"line_number":274,"context_line":"            \u0027\u0027,"},{"line_number":275,"context_line":"        ), )"},{"line_number":276,"context_line":"        self.assertEqual(datalist, tuple(data))"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_6f3216f4","line":274,"updated":"2015-11-27 12:09:04.000000000","message":"Would it be a good idea to add status to the image fake?","commit_id":"a2d5fd70a0f73817e369ad9e06b09fac03fd4059"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"82e391ddfe4bdbd182b060a2fadb1478421df33a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        datalist \u003d (("},{"line_number":272,"context_line":"            image_fakes.image_id,"},{"line_number":273,"context_line":"            image_fakes.image_name,"},{"line_number":274,"context_line":"            \u0027\u0027,"},{"line_number":275,"context_line":"        ), )"},{"line_number":276,"context_line":"        self.assertEqual(datalist, tuple(data))"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_cf7b0227","line":274,"in_reply_to":"9a8ffd7b_6f3216f4","updated":"2015-11-27 12:28:26.000000000","message":"I will improve these cases after the patch merged.\nhttps://review.openstack.org/#/c/248565/\nSo, currently, just let it be \u0027\u0027.","commit_id":"a2d5fd70a0f73817e369ad9e06b09fac03fd4059"}]}