)]}'
{"id":"openstack%2Fpython-openstackclient~249628","triplet_id":"openstack%2Fpython-openstackclient~master~I19209952de69626dfa3caadc5d1cc69b7feadeba","project":"openstack/python-openstackclient","branch":"master","topic":"server_fake","hashtags":[],"change_id":"I19209952de69626dfa3caadc5d1cc69b7feadeba","subject":"Move FakeServer to tests.common.v2.compute.fakes","status":"MERGED","created":"2015-11-25 08:18:00.000000000","updated":"2015-11-26 04:03:02.000000000","submitted":"2015-11-26 04:03:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"99a3008638bb43b73feea6a5cbf25f06c2a2c35b","_number":249628,"virtual_id_number":249628,"owner":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-11-26 04:03:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-11-25 14:57:28.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-11-26 02:36:22.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2015-11-26 02:36:22.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-11-25 08:19:20.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-25 08:19:20.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2015-11-25 14:57:28.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-11-26 02:36:22.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-26 04:03:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"46cf20bb332eabde106aafad244f1b41e4646a5a","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-11-25 08:18:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"067543337a1b2f2535b90ad68a64ff86f01178ba","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-25 09:06:12.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Cheng,\n\nI was trying to make this FakeServer class usable for all test components, compute, network, image, and so on. As you can see, in image tests, they fake servers, but just name and id. \n\nFor now, I cannot find any other use cases except compute. But I hope it can be put in the tests/fake.py .\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"3de6505df99db982d9fef0b2bd5a08b12145564f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 09:15:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/28/249628/1/check/gate-python-openstackclient-python26/4cbba11/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/28/249628/1/check/gate-python-openstackclient-pep8/589850d/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/28/249628/1/check/gate-python-openstackclient-docs/638082f//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/28/249628/1/check/gate-python-openstackclient-python27/8b86486/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-python34 http://logs.openstack.org/28/249628/1/check/gate-python-openstackclient-python34/056e63b/ : SUCCESS in 1m 50s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/28/249628/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8ba21eb/ : SUCCESS in 54m 48s\n- gate-osc-dsvm-functional http://logs.openstack.org/28/249628/1/check/gate-osc-dsvm-functional/3cae20c/ : SUCCESS in 23m 12s","accounts_in_message":[],"_revision_number":1},{"id":"7e587f7483f18c45280e3372c39a066a7c61f7fa","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-25 09:15:44.000000000","message":"Patch Set 1: -Code-Review\n\nWell, but on the other hand, I actually tell who will use this class in the future and how. So I don\u0027t have strong objection to this. I think I\u0027ll vote 0.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"5be85455a785e4d565af57250ddcee6ad91155bd","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-11-25 09:16:56.000000000","message":"Patch Set 1:\n\nSorry, there is a typo in the comment above.\n\nI actually cannot tell ......","accounts_in_message":[],"_revision_number":1},{"id":"ba88e751347d17b20100c6bd2fd82f1bf50d2e67","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-11-25 14:57:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"eaa3a0b9bf7e5e6ef4bcb067b37f12f1551d1eb9","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-26 02:36:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nalright, let\u0027s move it here","accounts_in_message":[],"_revision_number":1},{"id":"98b5d88a2bf9f19a4c7f243b781f30663518e477","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-26 02:36:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"10b105fae388e34aaf1ea0cf4e9c35a21c6b0ab1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-26 04:03:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/28/249628/1/gate/gate-python-openstackclient-python26/6148d4d/ : SUCCESS in 1m 27s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/28/249628/1/gate/gate-python-openstackclient-docs/6652de5//doc/build/html/ : SUCCESS in 2m 11s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/28/249628/1/gate/gate-python-openstackclient-pep8/72b5fd7/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/28/249628/1/gate/gate-python-openstackclient-python27/ba3523a/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/28/249628/1/gate/gate-python-openstackclient-python34/341c1c7/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/28/249628/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/b3fec6d/ : SUCCESS in 1h 25m 53s\n- gate-osc-dsvm-functional http://logs.openstack.org/28/249628/1/gate/gate-osc-dsvm-functional/fbc3e51/ : SUCCESS in 32m 57s","accounts_in_message":[],"_revision_number":1},{"id":"d030b6402e0e7c46285eed91b0f0a04d3784ca24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-26 04:03:02.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b3c2668c341da42ce7f193b1035f7ab352538d95","revisions":{"b3c2668c341da42ce7f193b1035f7ab352538d95":{"kind":"REWORK","_number":1,"created":"2015-11-25 08:18:00.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/28/249628/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/28/249628/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/249628/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/249628/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/249628/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/28/249628/1"}}},"commit":{"parents":[{"commit":"c0676fe17f10310041964fa1008fe966f5efbe91","subject":"Merge \"Trivial: Add missing doc for parameter in wait_for_delete().\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c0676fe17f10310041964fa1008fe966f5efbe91"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-11-25 08:17:49.000000000","tz":-480},"committer":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-11-25 08:17:49.000000000","tz":-480},"subject":"Move FakeServer to tests.common.v2.compute.fakes","message":"Move FakeServer to tests.common.v2.compute.fakes\n\nFakeServer should not be in tests.fakes since this should\nbe just for generic re-usable classes.\n\nChange-Id: I19209952de69626dfa3caadc5d1cc69b7feadeba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b3c2668c341da42ce7f193b1035f7ab352538d95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b3c2668c341da42ce7f193b1035f7ab352538d95"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}