)]}'
{"id":"openstack%2Fpython-openstackclient~251620","triplet_id":"openstack%2Fpython-openstackclient~master~I7bc909057125013fb9d215e92c61f847300f93e2","project":"openstack/python-openstackclient","branch":"master","topic":"bp/osc-network-unit-test-refactor","hashtags":[],"change_id":"I7bc909057125013fb9d215e92c61f847300f93e2","subject":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork","status":"MERGED","created":"2015-12-01 03:14:26.000000000","updated":"2015-12-06 07:14:10.000000000","submitted":"2015-12-06 04:04:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"810aa0b2321a6624ed72b0b6e951aedd3f115e67","_number":251620,"virtual_id_number":251620,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-06 04:04:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},{"value":0,"date":"2015-12-04 08:24:00.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-12-06 02:57:40.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-12-04 07:20:41.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-12-05 16:36:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2015-12-04 06:47:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":1,"date":"2015-12-06 02:57:40.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-01 13:39:29.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2015-12-04 07:20:41.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-05 16:36:12.000000000","updated_by":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"reviewer":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"state":"REVIEWER"},{"updated":"2015-12-06 02:57:40.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-12-06 04:04:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3a0080940bdc83b80bef9c23e39bbaa23fe13518","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-01 03:14:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20abebbf06e8b3fef183508f377bb066ece7ac7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-01 04:36:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/1/check/gate-python-openstackclient-pep8/4254245/ : FAILURE in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/1/check/gate-python-openstackclient-docs/b1a1340//doc/build/html/ : SUCCESS in 52s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/1/check/gate-python-openstackclient-python27/87ce2a8/ : SUCCESS in 49s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/1/check/gate-python-openstackclient-python34/0df8b7c/ : SUCCESS in 53s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d5e9580/ : SUCCESS in 1h 13m 37s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/1/check/gate-osc-dsvm-functional/aff8eda/ : SUCCESS in 28m 51s","accounts_in_message":[],"_revision_number":1},{"id":"6322e88143cedc1a8846f6f82903d3bd1b3e54e8","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-01 05:26:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"aa617f80562edd583486d2ca33517ffcd4268cd9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-01 06:53:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/2/check/gate-python-openstackclient-pep8/85b2916/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/2/check/gate-python-openstackclient-docs/22ed394//doc/build/html/ : SUCCESS in 2m 17s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/2/check/gate-python-openstackclient-python27/5d4aa33/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/2/check/gate-python-openstackclient-python34/340704f/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/21ff0ba/ : SUCCESS in 1h 13m 57s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/2/check/gate-osc-dsvm-functional/025fc61/ : SUCCESS in 25m 49s","accounts_in_message":[],"_revision_number":2},{"id":"2a82dc5e7cfe2ce0852954812fbb27508b4777d8","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2015-12-01 13:39:29.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"630320fbab40fe0d63773689893c6b756de3a856","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-03 05:26:11.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"574f8014fc6dd89c580062d8bcb7509457b1972a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 06:38:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/3/check/gate-python-openstackclient-pep8/ad37e5b/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/3/check/gate-python-openstackclient-docs/3969124//doc/build/html/ : SUCCESS in 2m 01s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/3/check/gate-python-openstackclient-python27/1c24894/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/3/check/gate-python-openstackclient-python34/4ff1ec2/ : SUCCESS in 2m 23s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/b8fe170/ : SUCCESS in 1h 09m 54s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/3/check/gate-osc-dsvm-functional/8cf2766/ : SUCCESS in 27m 07s","accounts_in_message":[],"_revision_number":3},{"id":"70dabd2c6e63d8a78603423e201500574af6fcac","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-04 06:47:05.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7f60d550591233328559873cde3cea4302945c0c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-04 07:20:41.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"abfe970da72f9bd89ad3a3b81203137e3e926aae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-04 08:21:13.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-pep8/2d31d36/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/4/check/gate-python-openstackclient-docs/73dabd5//doc/build/html/ : SUCCESS in 2m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-python27/3226e10/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-python34/ece247c/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/89f7e1c/ : SUCCESS in 1h 25m 30s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/4/check/gate-osc-dsvm-functional/dbda1c3/ : FAILURE in 29m 09s","accounts_in_message":[],"_revision_number":4},{"id":"4076e26e0d6eb5e87e2874749607b524719965fc","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-04 08:24:00.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"b180ba9a561f5ecb6070f3c55781e22c4b7404dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-04 09:27:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-pep8/1035788/ : SUCCESS in 1m 04s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/4/check/gate-python-openstackclient-docs/01de9c0//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-python27/7aa4fa5/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/4/check/gate-python-openstackclient-python34/5e2154c/ : SUCCESS in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/83ac544/ : SUCCESS in 1h 00m 22s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/4/check/gate-osc-dsvm-functional/d7edcdc/ : SUCCESS in 24m 59s","accounts_in_message":[],"_revision_number":4},{"id":"0950934d7865a0d6597d53da5c781ae185b2f14d","author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"date":"2015-12-05 16:36:12.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"4d8c861a69b4d1acd32f8f786f7c3e560da36619","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-12-06 02:57:40.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"506c4d980c7bf1c5c4f24c8f0272af90a1bf4104","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-06 02:57:45.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"da1473220c9e6f18ab4a9670a375c3163e45890c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-06 04:04:11.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/20/251620/4/gate/gate-python-openstackclient-docs/294bdca//doc/build/html/ : SUCCESS in 2m 21s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/20/251620/4/gate/gate-python-openstackclient-pep8/2db80fa/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/20/251620/4/gate/gate-python-openstackclient-python27/343f7d3/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python34 http://logs.openstack.org/20/251620/4/gate/gate-python-openstackclient-python34/ada62d8/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/20/251620/4/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/710a197/ : SUCCESS in 1h 02m 39s\n- gate-osc-dsvm-functional http://logs.openstack.org/20/251620/4/gate/gate-osc-dsvm-functional/d19301c/ : SUCCESS in 24m 49s","accounts_in_message":[],"_revision_number":4},{"id":"f88679b6ed5b73c5b1ea0c5d97f0747838df0290","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-06 04:04:13.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4},{"id":"81df028a2935e880d2fac324cac3a7e246086f61","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-06 07:14:10.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0cc1492ccdf44312ea50630d92ac121ea8e579a8","revisions":{"7bade5d8018d119cd2e823137b46f650c4563699":{"kind":"REWORK","_number":1,"created":"2015-12-01 03:14:26.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/20/251620/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/251620/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/1"}}},"commit":{"parents":[{"commit":"dfa10834d1e87e90e3fd8a68b4352d92e7cd1a02","subject":"Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dfa10834d1e87e90e3fd8a68b4352d92e7cd1a02"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 02:23:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 03:13:31.000000000","tz":480},"subject":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork","message":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork\n\nThere are severail problems in TestShowNetwork:\n1. NETWORK_ITEM is not used.\n2. Some redundant code.\n3. The param n_mock is used to fake find_attr(), but the name is confusing.\n   So rename it to find_attr().\n\nThis patch fixes them.\n\nChange-Id: I7bc909057125013fb9d215e92c61f847300f93e2\nImplements: blueprint osc-network-unit-test-refactor\nRelated-to: blueprint neutron-client\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bade5d8018d119cd2e823137b46f650c4563699"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7bade5d8018d119cd2e823137b46f650c4563699"}]},"branch":"refs/heads/master"},"ee9192ef00a61f3497b305c491951f18cf46012a":{"kind":"REWORK","_number":2,"created":"2015-12-01 05:26:35.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/20/251620/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/251620/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/2"}}},"commit":{"parents":[{"commit":"dfa10834d1e87e90e3fd8a68b4352d92e7cd1a02","subject":"Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dfa10834d1e87e90e3fd8a68b4352d92e7cd1a02"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 02:23:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 03:13:31.000000000","tz":480},"subject":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork","message":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork\n\nThere are severail problems in TestShowNetwork:\n1. NETWORK_ITEM is not used.\n2. Some redundant code.\n3. The param n_mock is used to fake find_attr(), but the name is confusing.\n   So rename it to find_attr().\n\nThis patch fixes them.\n\nChange-Id: I7bc909057125013fb9d215e92c61f847300f93e2\nImplements: blueprint osc-network-unit-test-refactor\nRelated-to: blueprint neutron-client\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ee9192ef00a61f3497b305c491951f18cf46012a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ee9192ef00a61f3497b305c491951f18cf46012a"}]},"branch":"refs/heads/master"},"1057dea9d11e8c05cc7bf9be9adbf0c1c2d96cf4":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-12-03 05:26:11.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/20/251620/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/251620/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/3"}}},"commit":{"parents":[{"commit":"e9e31dfd350be11975ba4a328cacd685fe2384d1","subject":"Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e9e31dfd350be11975ba4a328cacd685fe2384d1"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 02:23:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-04 05:20:38.000000000","tz":480},"subject":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork","message":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork\n\nThere are severail problems in TestShowNetwork:\n1. NETWORK_ITEM is not used.\n2. Some redundant code.\n3. The param n_mock is used to fake find_attr(), but the name is confusing.\n   So rename it to find_attr().\n\nThis patch fixes them.\n\nChange-Id: I7bc909057125013fb9d215e92c61f847300f93e2\nImplements: blueprint osc-network-unit-test-refactor\nRelated-to: blueprint neutron-client\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1057dea9d11e8c05cc7bf9be9adbf0c1c2d96cf4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1057dea9d11e8c05cc7bf9be9adbf0c1c2d96cf4"}]},"branch":"refs/heads/master"},"0cc1492ccdf44312ea50630d92ac121ea8e579a8":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2015-12-04 06:47:05.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/20/251620/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/20/251620/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/20/251620/4"}}},"commit":{"parents":[{"commit":"84cf168d1c13f4654b04bbca00b3bbc1e6a9f6a1","subject":"Refactor TestSetNetwork: Use TestNetwork in TestSetNetwork","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/84cf168d1c13f4654b04bbca00b3bbc1e6a9f6a1"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 02:23:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-05 02:52:05.000000000","tz":480},"subject":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork","message":"Refactor TestShowNetwork: Use TestNetwork in TestShowNetwork\n\nThere are severail problems in TestShowNetwork:\n1. NETWORK_ITEM is not used.\n2. Some redundant code.\n3. The param n_mock is used to fake find_attr(), but the name is confusing.\n   So rename it to find_attr().\n\nThis patch fixes them.\n\nChange-Id: I7bc909057125013fb9d215e92c61f847300f93e2\nImplements: blueprint osc-network-unit-test-refactor\nRelated-to: blueprint neutron-client\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cc1492ccdf44312ea50630d92ac121ea8e579a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cc1492ccdf44312ea50630d92ac121ea8e579a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}