)]}'
{"id":"openstack%2Fpython-openstackclient~251646","triplet_id":"openstack%2Fpython-openstackclient~master~Ibaf3c1e349633223fca19937bbd9060d4f9ecbda","project":"openstack/python-openstackclient","branch":"master","topic":"fix_service_set","hashtags":[],"change_id":"Ibaf3c1e349633223fca19937bbd9060d4f9ecbda","subject":"Remove list output from \"compute service set\"","status":"MERGED","created":"2015-12-01 05:54:48.000000000","updated":"2015-12-18 21:40:22.000000000","submitted":"2015-12-18 21:40:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"711578a1d05a2c3bc102c3bdb7645cbf9833d0c1","_number":251646,"virtual_id_number":251646,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":2,"date":"2015-12-18 21:40:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-12-15 14:32:48.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-12-15 07:40:16.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-18 20:26:49.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-12-18 20:26:49.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-15 07:40:16.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-15 14:32:48.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-12-18 20:26:49.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-12-18 21:40:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"05f42df96b7d517bf315f71b5ef190830af27ce7","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-12-01 05:54:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f61d7b38117f15df94dc2958fff429e8d9dd3e29","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-12-01 06:13:10.000000000","message":"Patch Set 1:\n\nHi, Steve,\n  Thanks for your comments on the bug #1517804, and I posted a patch to fix as you advice.\n  But i still confused about whether we need to echo the status after \u0027set\u0027 or not, because i found some \u0027set\u0027 command also echoing something, for instance, SetFlavor,SetAggregate and so forth.\n  And if no need, should we unify all these \u0027set\u0027 commands?\n  Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"9321b3185c38d3e3a63db42c919fe69501c9bf62","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:16:06.000000000","message":"Patch Set 1:\n\n@xiexs, oh? then those are incorrect, unless there is a special requirement that those commands list things, i think we want set to return nothing (except in the case of errors)","accounts_in_message":[],"_revision_number":1},{"id":"dcb75fd5250b4be6a84de13bcb51c2788f731e5a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:16:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5ec023adf14f0793c3aaa2949a242aa3b43f4bf0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:17:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1cbdcf0d686650dc309eaffc713cec35df687a9b","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-12-01 06:18:13.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"65c4e640273116ab5f78992dc9cb4972d0529734","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-12-01 06:30:16.000000000","message":"Patch Set 2:\n\nHi, Steve,\n  I looked at these \u0027set\u0027 commands roughly, all seem no special need to echo something, so it\u0027s a matter of design style, i think.","accounts_in_message":[],"_revision_number":2},{"id":"276796f3d40deea5b9f9d22dbaf8fec0ca156b8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-01 08:03:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/46/251646/2/check/gate-python-openstackclient-pep8/df3df8b/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/46/251646/2/check/gate-python-openstackclient-docs/9289fa6//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/46/251646/2/check/gate-python-openstackclient-python27/591f3b2/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-python34 http://logs.openstack.org/46/251646/2/check/gate-python-openstackclient-python34/8daa2a1/ : SUCCESS in 1m 46s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/46/251646/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/ae38176/ : SUCCESS in 1h 30m 45s\n- gate-osc-dsvm-functional http://logs.openstack.org/46/251646/2/check/gate-osc-dsvm-functional/64e6b36/ : SUCCESS in 49m 29s","accounts_in_message":[],"_revision_number":2},{"id":"4b8b758c9e16bbd7105acdc5617430bca05b79c3","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-03 18:22:43.000000000","message":"Patch Set 2:\n\nI can\u0027t find this in my notes, but my gut reaction is that set is very similar to create, and can have a side effect that may be useful to have returned at the completion of the command.\n\nI do agree that this needs to be the same for all OSC set commands, which ever way we decide.  That alone may make it better to continue to return the modified record.","accounts_in_message":[],"_revision_number":2},{"id":"d83b3ec0829d12e9ecd2ba18eb91eb41584dfc67","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-12-07 12:57:54.000000000","message":"Patch Set 2:\n\nHi, Steve and Dean,\n  Thanks for your comments.\n  Could we make the behavior of this command to be consistent\n with \"nova service-enable\" to return the service status after \nthis command executing?","accounts_in_message":[],"_revision_number":2},{"id":"634b8369055ac410429f65f8ff88f81d0d947db5","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-15 07:34:26.000000000","message":"Patch Set 2:\n\nDean, overwhelmingly we only use Lister when actually using List.\n\nRefer to http://codesearch.openstack.org/?q\u003dlister.Lister\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dpython-openstackclient\n\nThere are only instances where List isn\u0027t used, this patch SetService and ShowHost (we should look into that after this patch).\n\nFurthermore, command.Command is mainly used for \"Set\", \"Delete\" and \"Add/Remove\" type operations: http://codesearch.openstack.org/?q\u003dcommand.Command\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dpython-openstackclient\n\nLastly, show.ShowOne has the most disagreements (with 11). With identity, object and volume being mostly consistent with only using it for Create and Show operations. But it looks like compute has quite a few instances of \"ShowOne\" being used for Add/Remove and Set: http://codesearch.openstack.org/?q\u003dshow.ShowOne\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dpython-openstackclient\n\nThe full list of set/add/remove operations using \"ShowOne\" instead of \"Command\" is:\n\n  SetAgent\n  AddAggregate\n  RemoveAggregate\n  SetAggregate\n  SetFlavor\n  UnsetFlavor\n  SetSecurityGroup\n  UnsetSecurityGroup\n  RebuildServer\n  RescueServer\n  AddRole (v2)\n\nI guess this leaves us with something to talk about at our next meeting!","accounts_in_message":[],"_revision_number":2},{"id":"f1c511b7bf9e42bda16b93cfc12aec32b3245d57","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-15 07:40:16.000000000","message":"Patch Set 2: Code-Review+2\n\nI\u0027m still of the opinion that \"set\" should be using command.Command. So i\u0027m +2. I think we use that in the majority of the spots, and it\u0027s what we\u0027ve been telling other plugins to do. zaqar: (https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/queues/v1/cli.py#L125) and ironic: https://github.com/openstack/python-ironicclient/blob/master/ironicclient/osc/v1/baremetal.py#L205\n\nbah, looks like sahara is using show :( \nhttps://github.com/openstack/python-saharaclient/blob/master/saharaclient/osc/v1/images.py#L195","accounts_in_message":[],"_revision_number":2},{"id":"3fd3fc5642fb07fa7e4dbbafb8e9b4e8d1e1157c","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-12-15 14:32:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a3c082726da61f17af18735aea0af8bb9d2f6cc6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-15 22:54:15.000000000","message":"Patch Set 2:\n\nThis set command using List rather than Show is an anomaly; I probably thought the three-column output was more useful for some reason.\n\nI am still hesitant to remove all set output, something is nagging me that it is useful in some cases but I don\u0027t have the counter example at hand right now.","accounts_in_message":[],"_revision_number":2},{"id":"0da4bbad0c120a798647b788c4848aa65c3b36e9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-18 20:26:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3a0307e024083d3d059ee9d288a23027d26adc79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-18 20:26:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7b8c82125de0757995967614bef94eba9917c65c","date":"2015-12-18 21:40:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"3518ba33f3c54fbe641a3822328d2f01a905fcd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-18 21:40:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/46/251646/2/gate/gate-python-openstackclient-docs/ddc576c//doc/build/html/ : SUCCESS in 2m 36s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/46/251646/2/gate/gate-python-openstackclient-pep8/f038e19/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python27 http://logs.openstack.org/46/251646/2/gate/gate-python-openstackclient-python27/104f8aa/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-python34 http://logs.openstack.org/46/251646/2/gate/gate-python-openstackclient-python34/d6e4575/ : SUCCESS in 2m 03s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/46/251646/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/3b8e6a9/ : SUCCESS in 57m 43s\n- gate-osc-dsvm-functional http://logs.openstack.org/46/251646/2/gate/gate-osc-dsvm-functional/6611121/ : SUCCESS in 25m 27s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fad7126e7929621e37a021ee474b6aa771a92912","revisions":{"06e7b01cae024a03e6f7725cd3badd621d6bfac4":{"kind":"REWORK","_number":1,"created":"2015-12-01 05:54:48.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/46/251646/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/251646/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/1"}}},"commit":{"parents":[{"commit":"cb73e781e0b8d6a8104e3434dcf727f2e2dd4a9e","subject":"Merge \"Introduce FakeVolume class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb73e781e0b8d6a8104e3434dcf727f2e2dd4a9e"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-12-02 05:45:58.000000000","tz":480},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-12-02 05:53:56.000000000","tz":480},"subject":"Fix a bug of \"compute service set\"","message":"Fix a bug of \"compute service set\"\n\nReplace the super class from lister.Lister to command.Command,\nas no need to display the status for the \"set\" command.\n\nChange-Id: Ibaf3c1e349633223fca19937bbd9060d4f9ecbda\nCloses-Bug: #1517804\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06e7b01cae024a03e6f7725cd3badd621d6bfac4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06e7b01cae024a03e6f7725cd3badd621d6bfac4"}]},"branch":"refs/heads/master"},"fad7126e7929621e37a021ee474b6aa771a92912":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-12-01 06:18:13.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/46/251646/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/46/251646/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/46/251646/2"}}},"commit":{"parents":[{"commit":"cb73e781e0b8d6a8104e3434dcf727f2e2dd4a9e","subject":"Merge \"Introduce FakeVolume class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb73e781e0b8d6a8104e3434dcf727f2e2dd4a9e"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-12-02 05:45:58.000000000","tz":480},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-12-01 06:18:13.000000000","tz":0},"subject":"Remove list output from \"compute service set\"","message":"Remove list output from \"compute service set\"\n\nReplace the super class from lister.Lister to command.Command,\nas no need to display the status for the \"set\" command.\n\nChange-Id: Ibaf3c1e349633223fca19937bbd9060d4f9ecbda\nCloses-Bug: #1517804\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fad7126e7929621e37a021ee474b6aa771a92912"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fad7126e7929621e37a021ee474b6aa771a92912"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}