)]}'
{"id":"openstack%2Fpython-openstackclient~251658","triplet_id":"openstack%2Fpython-openstackclient~master~I70613843f82d74732bd32a457cd4a31aba57825f","project":"openstack/python-openstackclient","branch":"master","topic":"server-list-improve","hashtags":[],"change_id":"I70613843f82d74732bd32a457cd4a31aba57825f","subject":"Support \"server list\" searching by both image name and ID.","status":"MERGED","created":"2015-12-01 06:08:35.000000000","updated":"2015-12-03 20:37:00.000000000","submitted":"2015-12-03 20:36:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"974c2e40979dcc6e5fa1856d4ddc05eb253c7417","_number":251658,"virtual_id_number":251658,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-03 20:36:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-12-02 15:07:05.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-12-01 06:59:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2015-12-03 17:49:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-12-02 10:24:30.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2015-12-03 17:49:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-01 06:59:30.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-02 10:24:30.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-03 17:49:52.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-12-03 20:36:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ffed0d859e53aec92803a81e8adf7f2066ae4e19","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-01 06:08:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea18e8db47805279c595f97565b45735d34b8b26","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-01 06:12:58.000000000","message":"Patch Set 1:\n\nAbout the unit test, there is no unit tests for class ListServer in OSC now. So will add a complete unit test class for it in another patch following BP: \n\n- https://blueprints.launchpad.net/python-openstackclient/+spec/osc-unit-test-framework-improvement","accounts_in_message":[],"_revision_number":1},{"id":"d9f6fd5575300cd5e8b45874048e2d4d2c50e683","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:19:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"61c1bcabfa27cd61b29e39c4c55eaf629e2a53d7","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:59:19.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"dea5906834d9332c64e0302059e17280014cbb00","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:59:22.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"c70dd216c89c9c49babfe8a2e39eaaf70ff507c3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-01 06:59:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c30e61a2ade67efdfa6ff6de00afb594eff54ac8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-01 08:28:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/58/251658/3/check/gate-python-openstackclient-pep8/7fc0335/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/58/251658/3/check/gate-python-openstackclient-docs/efce60a//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-openstackclient-python27 http://logs.openstack.org/58/251658/3/check/gate-python-openstackclient-python27/aa2e03f/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/58/251658/3/check/gate-python-openstackclient-python34/8e30a5e/ : SUCCESS in 1m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/58/251658/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e943b09/ : SUCCESS in 1h 25m 21s\n- gate-osc-dsvm-functional http://logs.openstack.org/58/251658/3/check/gate-osc-dsvm-functional/fc8d23a/ : SUCCESS in 31m 57s","accounts_in_message":[],"_revision_number":3},{"id":"4f1ec280c54eb87a6cff34755b9cab2f17e37a3a","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-02 10:24:30.000000000","message":"Patch Set 3:\n\nwhy only apply this to List command? Can we apply this to other commands too as this introduce inconsistency with the api","accounts_in_message":[],"_revision_number":3},{"id":"9c56d8d159c519be2d7f9186f08aabeec840a773","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-02 15:07:05.000000000","message":"Patch Set 3:\n\nHi Cheng,\n\nYes, I planed to do so. But I found most of the existing commands have already supported this feature. So I\u0027ll list up all the commands and options which we need to do so, and then send patches for them. \n\nSo I think we can merge these two first.\n\nThanks. :)","accounts_in_message":[],"_revision_number":3},{"id":"6a5238569571ca000047e33ac4d4b1607e8aab78","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-02 15:58:09.000000000","message":"Patch Set 3:\n\nHi Cheng,\n\nBTW, do we have to keep the consistency between command and api ?  I don\u0027t think so.","accounts_in_message":[],"_revision_number":3},{"id":"7b07f96160c4f101624f9a5e03ace4a4e919d6f4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-03 17:49:52.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nConsistency with the REAT API and the CLI is not the primary concern here, when we can add value to the end user we should even if the REST API does not support it.  In some cases this even means doing sorts or filtering entirely in the client...","accounts_in_message":[],"_revision_number":3},{"id":"47584a621713905177f27df202ff3ed35d142dc1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 17:50:21.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"309351db62329888e395b2527f57e94958108015","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 20:36:59.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/58/251658/3/gate/gate-python-openstackclient-docs/d2ba138//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/58/251658/3/gate/gate-python-openstackclient-pep8/a38f6b3/ : SUCCESS in 1m 24s\n- gate-python-openstackclient-python27 http://logs.openstack.org/58/251658/3/gate/gate-python-openstackclient-python27/08bc7c1/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-python34 http://logs.openstack.org/58/251658/3/gate/gate-python-openstackclient-python34/69630e4/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/58/251658/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/26a3fc5/ : SUCCESS in 51m 45s\n- gate-osc-dsvm-functional http://logs.openstack.org/58/251658/3/gate/gate-osc-dsvm-functional/178a015/ : SUCCESS in 21m 40s","accounts_in_message":[],"_revision_number":3},{"id":"2cc71425e12a72f3bdb7380b6da679fabbd63d0c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 20:37:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"106f928cb66fbfb3fb99f32b9d3e8ffdbda04d75","revisions":{"0ae48f1c73fbbaae030ade8afebadf5215de97b4":{"kind":"REWORK","_number":1,"created":"2015-12-01 06:08:35.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/58/251658/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/251658/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/1"}}},"commit":{"parents":[{"commit":"f0af3f5c92745580d124bdb21004fc09a6c42815","subject":"Support \"server list\" searching by both flavor name and ID.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f0af3f5c92745580d124bdb21004fc09a6c42815"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 06:02:12.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 06:02:12.000000000","tz":480},"subject":"Support \"server list\" searching by both image name and ID.","message":"Support \"server list\" searching by both image name and ID.\n\nNova API only supports list servers searching by image ID.\nIn OSC, we can support both image name and ID by mapping\nthe name to ID.\n\nThis patch also fix the inconsistent doc in .py and .rst files.\n\nChange-Id: I70613843f82d74732bd32a457cd4a31aba57825f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ae48f1c73fbbaae030ade8afebadf5215de97b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ae48f1c73fbbaae030ade8afebadf5215de97b4"}]},"branch":"refs/heads/master"},"c9964ea597f84846dbf4a2e17becf5ea55f0e1fb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-12-01 06:59:19.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/58/251658/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/251658/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/2"}}},"commit":{"parents":[{"commit":"f0af3f5c92745580d124bdb21004fc09a6c42815","subject":"Support \"server list\" searching by both flavor name and ID.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f0af3f5c92745580d124bdb21004fc09a6c42815"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 06:02:12.000000000","tz":480},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2015-12-01 06:59:19.000000000","tz":0},"subject":"Support \"server list\" searching by both image name and ID.","message":"Support \"server list\" searching by both image name and ID.\n\nNova API only supports list servers searching by image ID.\nIn OSC, we can support both image name and ID by mapping\nthe name to ID.\n\nThis patch also fix the inconsistent doc in .py and .rst files.\n\nCloses-Bug: 1521492\n\nChange-Id: I70613843f82d74732bd32a457cd4a31aba57825f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c9964ea597f84846dbf4a2e17becf5ea55f0e1fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c9964ea597f84846dbf4a2e17becf5ea55f0e1fb"}]},"branch":"refs/heads/master"},"106f928cb66fbfb3fb99f32b9d3e8ffdbda04d75":{"kind":"NO_CHANGE","_number":3,"created":"2015-12-01 06:59:22.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/58/251658/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/251658/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/251658/3"}}},"commit":{"parents":[{"commit":"0069a0196717eb7ba60bcda5b89bf87608cc01dd","subject":"Support \"server list\" searching by both flavor name and ID.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0069a0196717eb7ba60bcda5b89bf87608cc01dd"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-02 06:02:12.000000000","tz":480},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2015-12-01 06:59:22.000000000","tz":0},"subject":"Support \"server list\" searching by both image name and ID.","message":"Support \"server list\" searching by both image name and ID.\n\nNova API only supports list servers searching by image ID.\nIn OSC, we can support both image name and ID by mapping\nthe name to ID.\n\nThis patch also fix the inconsistent doc in .py and .rst files.\n\nCloses-Bug: 1521492\n\nChange-Id: I70613843f82d74732bd32a457cd4a31aba57825f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/106f928cb66fbfb3fb99f32b9d3e8ffdbda04d75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/106f928cb66fbfb3fb99f32b9d3e8ffdbda04d75"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}