)]}'
{"id":"openstack%2Fpython-openstackclient~252248","triplet_id":"openstack%2Fpython-openstackclient~master~Iefa453fe4adad06f2a0601a052c01e74004be5b7","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1521896","hashtags":[],"change_id":"Iefa453fe4adad06f2a0601a052c01e74004be5b7","subject":"Fix exception when doing volume set operation","status":"MERGED","created":"2015-12-02 08:26:03.000000000","updated":"2015-12-03 16:15:58.000000000","submitted":"2015-12-03 16:15:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fda5099b33b65f814227dddc2e044144da35d3ba","_number":252248,"virtual_id_number":252248,"owner":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-03 16:15:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-12-03 14:42:05.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-03 08:30:39.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2015-12-03 14:42:05.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-03 08:30:39.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-03 14:42:05.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-03 16:15:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d9694314ae918cb6e92cfead968000e1944b69ad","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2015-12-02 08:26:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ad6e72692cb93234ffece39b4f2bb464a636743","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2015-12-02 08:30:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"06631f9d132d15532e259f7324776e29c7320d1f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-02 09:32:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/48/252248/2/check/gate-python-openstackclient-pep8/43b1109/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/48/252248/2/check/gate-python-openstackclient-docs/508f659//doc/build/html/ : SUCCESS in 1m 55s\n- gate-python-openstackclient-python27 http://logs.openstack.org/48/252248/2/check/gate-python-openstackclient-python27/1952d2d/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/48/252248/2/check/gate-python-openstackclient-python34/c121113/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/48/252248/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fb7567d/ : SUCCESS in 57m 25s\n- gate-osc-dsvm-functional http://logs.openstack.org/48/252248/2/check/gate-osc-dsvm-functional/6e2dc80/ : SUCCESS in 29m 52s","accounts_in_message":[],"_revision_number":2},{"id":"36cb9e83a12269d8537fd95f48c317b1dca2f12b","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-02 10:28:44.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nSetVolume should be extending from command.Command, it is expected that Set command does not return anything","accounts_in_message":[],"_revision_number":2},{"id":"30c521fcbfdef8ae43185d4ad108732c0bd56e77","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2015-12-03 01:36:12.000000000","message":"Patch Set 2:\n\n@Lin Hua Cheng\n\nHi, do you mean we just change the SetVolume\u0027s parent classs to command.Command?","accounts_in_message":[],"_revision_number":2},{"id":"74f44283dfac1edf41a96f3c7a2b2e27eb64cca7","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-03 07:11:15.000000000","message":"Patch Set 2:\n\nyes","accounts_in_message":[],"_revision_number":2},{"id":"899777ed5533f658602690e48214d39bc1613cb7","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2015-12-03 07:27:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3d56c9685d35dbd4c3ae9b0814a6a11dfe510ecd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 08:30:03.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/48/252248/3/check/gate-python-openstackclient-pep8/0fb1bc9/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/48/252248/3/check/gate-python-openstackclient-docs/0836710//doc/build/html/ : SUCCESS in 2m 35s\n- gate-python-openstackclient-python27 http://logs.openstack.org/48/252248/3/check/gate-python-openstackclient-python27/b05fc5e/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-python34 http://logs.openstack.org/48/252248/3/check/gate-python-openstackclient-python34/3ae2f30/ : SUCCESS in 2m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/48/252248/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/dfbeca1/ : SUCCESS in 56m 41s\n- gate-osc-dsvm-functional http://logs.openstack.org/48/252248/3/check/gate-osc-dsvm-functional/f59618c/ : SUCCESS in 28m 19s","accounts_in_message":[],"_revision_number":3},{"id":"6228ca519458919683cfa32c7eab9161ec52b3d1","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-03 08:30:39.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e4a853b6456aa55de916ca7c4d10f383a698dc6a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-03 14:42:05.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"c27259b08af7d4f87cdab6c0eae6828d5da61f2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 14:42:13.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"cdf2f0abaae2a5d1acd00a1b06e6911d76e4bd91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 16:15:56.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/48/252248/3/gate/gate-python-openstackclient-docs/0c10b2c//doc/build/html/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/48/252248/3/gate/gate-python-openstackclient-pep8/76dae4b/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/48/252248/3/gate/gate-python-openstackclient-python27/950ccb1/ : SUCCESS in 1m 34s\n- gate-python-openstackclient-python34 http://logs.openstack.org/48/252248/3/gate/gate-python-openstackclient-python34/9475f44/ : SUCCESS in 2m 56s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/48/252248/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/d6a4a9f/ : SUCCESS in 1h 28m 42s\n- gate-osc-dsvm-functional http://logs.openstack.org/48/252248/3/gate/gate-osc-dsvm-functional/0b27be3/ : SUCCESS in 24m 29s","accounts_in_message":[],"_revision_number":3},{"id":"a794b9dad1096044c3e7961677e4e878c81b1bc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 16:15:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"197d86dffa4ba7eefbf6f18381ff1ced9dc7f23f","revisions":{"bcd4c5e67d0f9028a018dd106c7d6fc44ac565a5":{"kind":"REWORK","_number":1,"created":"2015-12-02 08:26:03.000000000","uploader":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"ref":"refs/changes/48/252248/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/48/252248/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/1"}}},"commit":{"parents":[{"commit":"27869c0f3ffca5bd15700a198dd9e5929ea4d77d","subject":"Merge \"Remove old fake flavor data.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/27869c0f3ffca5bd15700a198dd9e5929ea4d77d"}]}],"author":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-01 10:42:54.000000000","tz":480},"committer":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-02 08:25:07.000000000","tz":480},"subject":"Fix exception when doing volume set operation","message":"Fix exception when doing volume set operation\n\nThe take_action() function of SetVolume returns None\nafter setting volume operation. It will raise an exception.\nThis patch is going to fix the issue by returning the\nfileds which are modified during the operation.\n\nChange-Id: Iefa453fe4adad06f2a0601a052c01e74004be5b7\nCloses-bug: 1521896\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bcd4c5e67d0f9028a018dd106c7d6fc44ac565a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bcd4c5e67d0f9028a018dd106c7d6fc44ac565a5"}]},"branch":"refs/heads/master"},"a20812b3cf826f81b2d0f6137ee3806c66408d41":{"kind":"REWORK","_number":2,"created":"2015-12-02 08:30:03.000000000","uploader":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"ref":"refs/changes/48/252248/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/48/252248/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/2"}}},"commit":{"parents":[{"commit":"27869c0f3ffca5bd15700a198dd9e5929ea4d77d","subject":"Merge \"Remove old fake flavor data.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/27869c0f3ffca5bd15700a198dd9e5929ea4d77d"}]}],"author":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-01 10:42:54.000000000","tz":480},"committer":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-02 08:29:44.000000000","tz":480},"subject":"Fix exception when doing volume set operation","message":"Fix exception when doing volume set operation\n\nThe take_action() function of SetVolume returns None\nafter setting volume operation. It will raise an exception.\nThis patch is going to fix the issue by returning the\nfileds which are modified during the operation.\n\nChange-Id: Iefa453fe4adad06f2a0601a052c01e74004be5b7\nCloses-bug: 1521896\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a20812b3cf826f81b2d0f6137ee3806c66408d41"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a20812b3cf826f81b2d0f6137ee3806c66408d41"}]},"branch":"refs/heads/master"},"197d86dffa4ba7eefbf6f18381ff1ced9dc7f23f":{"kind":"REWORK","_number":3,"created":"2015-12-03 07:27:10.000000000","uploader":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"ref":"refs/changes/48/252248/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/48/252248/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/48/252248/3"}}},"commit":{"parents":[{"commit":"27869c0f3ffca5bd15700a198dd9e5929ea4d77d","subject":"Merge \"Remove old fake flavor data.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/27869c0f3ffca5bd15700a198dd9e5929ea4d77d"}]}],"author":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-01 10:42:54.000000000","tz":480},"committer":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2015-12-03 07:25:12.000000000","tz":480},"subject":"Fix exception when doing volume set operation","message":"Fix exception when doing volume set operation\n\nThe v2 SetVolume extends from show.ShowOne and returns None\nafter setting volume operation. It will raise an exception.\nThis patch is going to fix the issue by changing the parent\nclass of SetVolume to command.Command.\n\nChange-Id: Iefa453fe4adad06f2a0601a052c01e74004be5b7\nCloses-bug: 1521896\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/197d86dffa4ba7eefbf6f18381ff1ced9dc7f23f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/197d86dffa4ba7eefbf6f18381ff1ced9dc7f23f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}