)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e6918dfa009d3925466acc040c02277c644f7e99","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0027router_external\u0027: _format_router_external,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def _make_client_sdk(instance):"},{"line_number":47,"context_line":"    \"\"\"Return a network proxy\"\"\""},{"line_number":48,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1151950e","line":45,"updated":"2015-12-05 05:59:32.000000000","message":"This should be common to all network commands, consider moving this out later","commit_id":"92340c63de5e6f9c3365c05e8df6631d7ef0827a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"0c22c2479161cf1d26e72e9ef4713d3570033b9e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0027router_external\u0027: _format_router_external,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def _make_client_sdk(instance):"},{"line_number":47,"context_line":"    \"\"\"Return a network proxy\"\"\""},{"line_number":48,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_2ae696b4","line":45,"in_reply_to":"7a740942_1151950e","updated":"2015-12-05 14:46:48.000000000","message":"It will be moved to client.py in this patch:\n\nhttps://review.openstack.org/#/c/253348/","commit_id":"92340c63de5e6f9c3365c05e8df6631d7ef0827a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9c7b49ba15fc64251bb135458100c3a255243ed0","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027 % parsed_args)"},{"line_number":191,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        data \u003d client.api.network_list(external\u003dparsed_args.external)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.long:"},{"line_number":196,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_88d2085b","side":"PARENT","line":193,"updated":"2015-12-07 14:26:17.000000000","message":"Please remove the network_list() since it appears to be no longer used.","commit_id":"481b711faefe21738da20187cef80fc5fa63fce4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"97a1d64c4c66c06b99ac4a8ad38f613fd8ee2cb5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027 % parsed_args)"},{"line_number":191,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        data \u003d client.api.network_list(external\u003dparsed_args.external)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.long:"},{"line_number":196,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_343fad25","side":"PARENT","line":193,"in_reply_to":"7a740942_591e3460","updated":"2015-12-07 15:29:40.000000000","message":"I\u0027m okay with the cleanup in another patch set if others are too.","commit_id":"481b711faefe21738da20187cef80fc5fa63fce4"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"852443aaa2d3e54867a6300c285707f7c7494c83","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027 % parsed_args)"},{"line_number":191,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        data \u003d client.api.network_list(external\u003dparsed_args.external)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.long:"},{"line_number":196,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_591e3460","side":"PARENT","line":193,"in_reply_to":"7a740942_88d2085b","updated":"2015-12-07 15:04:33.000000000","message":"Actually I don\u0027t quite know what is the api dir for. It looks like something similar to SDK.  Can we do the cleanup in another patch ?  I think not only this network_list() needs to cleanup. And also, I think we should discuss in which direction the api dir should go.","commit_id":"481b711faefe21738da20187cef80fc5fa63fce4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"241aeebd201d1461b62655d092beb9b47bc7df42","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027 % parsed_args)"},{"line_number":191,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        data \u003d client.api.network_list(external\u003dparsed_args.external)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.long:"},{"line_number":196,"context_line":"            columns \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_6829dc36","side":"PARENT","line":193,"in_reply_to":"7a740942_88d2085b","updated":"2015-12-07 14:29:01.000000000","message":"You may be able to delete the entire module since I don\u0027t see dhcp_agent_list() used either.","commit_id":"481b711faefe21738da20187cef80fc5fa63fce4"}]}