)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"44026a5669885206e2f573a040c6db09ec711319","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"},{"line_number":47,"context_line":"    return conn.network"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _prep_network_detail(net):"},{"line_number":51,"context_line":"    \"\"\"Prepare network object for output\"\"\""},{"line_number":52,"context_line":"    if \u0027subnets\u0027 in net:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_21100da8","line":49,"updated":"2015-12-04 19:12:27.000000000","message":"This method is no longer being used and can be removed.","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f1c789c96261fdacebd07fc1d8ffa8a0caa9facb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"},{"line_number":47,"context_line":"    return conn.network"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _prep_network_detail(net):"},{"line_number":51,"context_line":"    \"\"\"Prepare network object for output\"\"\""},{"line_number":52,"context_line":"    if \u0027subnets\u0027 in net:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_fc994e6f","line":49,"in_reply_to":"7a740942_21100da8","updated":"2015-12-04 19:29:33.000000000","message":"Done","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"}],"openstackclient/tests/network/v2/test_network.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"44026a5669885206e2f573a040c6db09ec711319","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                          parsed_args)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"@mock.patch(\u0027openstackclient.network.v2.network._make_client_sdk\u0027)"},{"line_number":537,"context_line":"class TestShowNetwork(TestNetwork):"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    # The network to set."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_6167f525","line":536,"updated":"2015-12-04 19:12:27.000000000","message":"Is there a better way to handle this?  It seems very messy to have to pass this method on all tests.","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f1c789c96261fdacebd07fc1d8ffa8a0caa9facb","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                          parsed_args)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"@mock.patch(\u0027openstackclient.network.v2.network._make_client_sdk\u0027)"},{"line_number":537,"context_line":"class TestShowNetwork(TestNetwork):"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    # The network to set."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7c779e3a","line":536,"in_reply_to":"7a740942_6167f525","updated":"2015-12-04 19:29:33.000000000","message":"For now, I cannot find a better way to split Terry\u0027s patch. We should make the being modified command use sdks while keeping the others using neutron client. But make_client() cannot support both at the same time.","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8180309599b1cb4458b54e046203fe576883e39e","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                          parsed_args)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"@mock.patch(\u0027openstackclient.network.v2.network._make_client_sdk\u0027)"},{"line_number":537,"context_line":"class TestShowNetwork(TestNetwork):"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    # The network to set."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_a8f619f7","line":536,"in_reply_to":"7a740942_7c779e3a","updated":"2015-12-04 23:02:03.000000000","message":"I understand.  Do you plan to make this temporary as part of switching network CRUD from neutron client to SDK?  I would prefer not to use this for security group and security group rule CRUD.","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"3e86b2fca3ff3e177de35a4d576269560554069d","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                          parsed_args)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"@mock.patch(\u0027openstackclient.network.v2.network._make_client_sdk\u0027)"},{"line_number":537,"context_line":"class TestShowNetwork(TestNetwork):"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    # The network to set."}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7b555a4e","line":536,"in_reply_to":"7a740942_a8f619f7","updated":"2015-12-05 03:48:13.000000000","message":"This will be removed in the end, here:\n\nhttps://review.openstack.org/#/c/253348/\n\nAnd if you can post patches after this patch-set is merged, you don\u0027t need to do so in your patch-set. \n\nSorry I didn\u0027t tell you the plan clearly. It\u0027s not convenience to talk in IRC because of the time zones.  :)","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"44026a5669885206e2f573a040c6db09ec711319","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Get the command object to test"},{"line_number":568,"context_line":"        self.cmd \u003d network.ShowNetwork(self.app, self.namespace)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_show_all_options(self, _make_client_sdk):"},{"line_number":571,"context_line":"        _make_client_sdk.return_value \u003d self.app.client_manager.network"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_c18a69bf","line":570,"updated":"2015-12-04 19:12:27.000000000","message":"Why was test_show_no_options removed?","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"3e86b2fca3ff3e177de35a4d576269560554069d","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Get the command object to test"},{"line_number":568,"context_line":"        self.cmd \u003d network.ShowNetwork(self.app, self.namespace)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_show_all_options(self, _make_client_sdk):"},{"line_number":571,"context_line":"        _make_client_sdk.return_value \u003d self.app.client_manager.network"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_5b4adead","line":570,"in_reply_to":"7a740942_6836f1e8","updated":"2015-12-05 03:48:13.000000000","message":"What test ?  The test without specifying the identifier ?","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8180309599b1cb4458b54e046203fe576883e39e","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Get the command object to test"},{"line_number":568,"context_line":"        self.cmd \u003d network.ShowNetwork(self.app, self.namespace)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_show_all_options(self, _make_client_sdk):"},{"line_number":571,"context_line":"        _make_client_sdk.return_value \u003d self.app.client_manager.network"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_6836f1e8","line":570,"in_reply_to":"7a740942_bccf467e","updated":"2015-12-04 23:02:03.000000000","message":"You are correct.  How about adding such a test now?","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f1c789c96261fdacebd07fc1d8ffa8a0caa9facb","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Get the command object to test"},{"line_number":568,"context_line":"        self.cmd \u003d network.ShowNetwork(self.app, self.namespace)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_show_all_options(self, _make_client_sdk):"},{"line_number":571,"context_line":"        _make_client_sdk.return_value \u003d self.app.client_manager.network"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_bccf467e","line":570,"in_reply_to":"7a740942_c18a69bf","updated":"2015-12-04 19:29:33.000000000","message":"Because in the original code, they were the same. There is no option in this command.","commit_id":"52f4f4710e7688c74b77945df66fd1402c85423f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"21747a31de8ffe7e7ee5e546ce73c6b6535e5642","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        # Get the command object to test"},{"line_number":569,"context_line":"        self.cmd \u003d network.ShowNetwork(self.app, self.namespace)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def test_show_no_options(self, _make_client_sdk):"},{"line_number":572,"context_line":"        _make_client_sdk.return_value \u003d self.app.client_manager.network"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        arglist \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_7f7d376d","line":571,"updated":"2015-12-06 15:02:47.000000000","message":"Hi Richard,\n\nThe no option test case has been added. :)","commit_id":"3c341019cea2fb4da015f2ab871631afab9a1020"}]}