)]}'
{"openstackclient/network/client.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fdbc42fc154d6476e3ba581c69fb35b6fe895467","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    \"\"\"Returns a network proxy\"\"\""},{"line_number":35,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"},{"line_number":36,"context_line":"    LOG.debug(\u0027Connection: %s\u0027, conn)"},{"line_number":37,"context_line":"    return conn.network"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_714c9942","line":36,"updated":"2015-12-05 12:17:15.000000000","message":"Add another line of debug for network specific details?","commit_id":"1930459650a1bc184ec0ff9343d7e2a7a74a651c"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1a60df931ecde48485a7575a3cecf5584b20642b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    \"\"\"Returns a network proxy\"\"\""},{"line_number":35,"context_line":"    conn \u003d connection.Connection(authenticator\u003dinstance.session.auth)"},{"line_number":36,"context_line":"    LOG.debug(\u0027Connection: %s\u0027, conn)"},{"line_number":37,"context_line":"    return conn.network"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4a47624b","line":36,"in_reply_to":"7a740942_714c9942","updated":"2015-12-05 14:44:06.000000000","message":"Will see what info we can log :)","commit_id":"1930459650a1bc184ec0ff9343d7e2a7a74a651c"}],"openstackclient/network/common.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a070072cbb3886fdfc20f5ad845837b8fc1a2e3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    :param resources: plural name of resource"},{"line_number":24,"context_line":"    :param name_or_id: name or id of resource user is looking for"},{"line_number":25,"context_line":"    :param name_attr: key to the name attribute for the resource"},{"line_number":26,"context_line":"    :param sdk_enable: True if the client is using openstack-sdk"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    For example:"},{"line_number":29,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_7ebe7666","line":26,"updated":"2015-12-07 14:59:52.000000000","message":"The network client is now switched to the SDK with this patch set so why is this a parameter necessary?","commit_id":"cb4403aa7a7ddb3d76538b0e41f9f9cbc2927093"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"29b41788330d37888e178a46238ff6800a88a220","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    :param resources: plural name of resource"},{"line_number":24,"context_line":"    :param name_or_id: name or id of resource user is looking for"},{"line_number":25,"context_line":"    :param name_attr: key to the name attribute for the resource"},{"line_number":26,"context_line":"    :param sdk_enable: True if the client is using openstack-sdk"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    For example:"},{"line_number":29,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_9401c107","line":26,"in_reply_to":"7a740942_7ebe7666","updated":"2015-12-07 15:18:27.000000000","message":"Seems you are right. I forgot that it is under network dir.","commit_id":"cb4403aa7a7ddb3d76538b0e41f9f9cbc2927093"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2db73159a90ec8d67b49c60e4306d28478ed0b53","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstackclient.common import exceptions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def find(client, resource, resources, name_or_id, name_attr\u003d\u0027name\u0027):"},{"line_number":18,"context_line":"    \"\"\"Find a network resource"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    :param client: network client"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_b51ab47b","side":"PARENT","line":17,"updated":"2015-12-07 17:09:05.000000000","message":"I didn\u0027t change the prototype because it is also called in api.py, which I will cleanup in another patch. In this patch, I don\u0027t plan to touch any api file.","commit_id":"391ac9db49b86a95df000bc611d51a9620282aae"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a5f30bcdb0fa8653150df95d5ac2929283d301f5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    For example:"},{"line_number":25,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    list_method \u003d getattr(client, \"find_%s\" % resource)"},{"line_number":28,"context_line":"    data \u003d list_method(name_or_id, ignore_missing\u003dFalse)"},{"line_number":29,"context_line":"    return data.id"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_40b35750","line":27,"updated":"2015-12-08 14:12:34.000000000","message":"The call is for find so why is this being changed to \"list_method\"?","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a52b05fa1be4c72ea5bdcc18b6c7e9d61d40f16f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    For example:"},{"line_number":25,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    list_method \u003d getattr(client, \"find_%s\" % resource)"},{"line_number":28,"context_line":"    data \u003d list_method(name_or_id, ignore_missing\u003dFalse)"},{"line_number":29,"context_line":"    return data.id"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_a7fb2a46","line":27,"in_reply_to":"7a740942_27817afb","updated":"2015-12-08 16:10:05.000000000","message":"Thanks, we can do the refactoring in another patch set.","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"685898d804668c8d400b0ec5b5c1d865d03fc700","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    For example:"},{"line_number":25,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    list_method \u003d getattr(client, \"find_%s\" % resource)"},{"line_number":28,"context_line":"    data \u003d list_method(name_or_id, ignore_missing\u003dFalse)"},{"line_number":29,"context_line":"    return data.id"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_f137b7fc","line":27,"in_reply_to":"7a740942_40b35750","updated":"2015-12-08 15:03:26.000000000","message":"Sorry, I didn\u0027t write my plan here.\n\nI didn\u0027t change the name to avoid changing too much code in the test file. As you can see, there are too many things we need to clean up, resources is not needed, name_attr is not useful, and so on. But this patch is large enough. \n\nFurther more, the method is find_%s, so it could be used to find every thing. In the long term, this find() should be moved to a common file, I think. \n\nSo, can we just leave it here, and figure out a way to clean all this up ?","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"afbb33ee3dea3403afbe0d854e490e43863b5325","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    For example:"},{"line_number":25,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    list_method \u003d getattr(client, \"find_%s\" % resource)"},{"line_number":28,"context_line":"    data \u003d list_method(name_or_id, ignore_missing\u003dFalse)"},{"line_number":29,"context_line":"    return data.id"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_27817afb","line":27,"in_reply_to":"7a740942_64a460b9","updated":"2015-12-08 16:04:28.000000000","message":"It is called in compute/v2/server.py, when creating a new server.","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a404438f0ef4c94e8f098a46849504f0dcd4e877","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    For example:"},{"line_number":25,"context_line":"        n \u003d find(netclient, \u0027network\u0027, \u0027networks\u0027, \u0027matrix\u0027)"},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    list_method \u003d getattr(client, \"find_%s\" % resource)"},{"line_number":28,"context_line":"    data \u003d list_method(name_or_id, ignore_missing\u003dFalse)"},{"line_number":29,"context_line":"    return data.id"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_64a460b9","line":27,"in_reply_to":"7a740942_f137b7fc","updated":"2015-12-08 15:51:57.000000000","message":"Is this method used any longer?  It no longer appears to be called in network.py.","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"}],"openstackclient/tests/network/test_common.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f8b110e48902dae4239e08be778f1fcb691313be","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstackclient.common import exceptions"},{"line_number":17,"context_line":"from openstackclient.network import common"},{"line_number":18,"context_line":"from openstackclient.tests import utils"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a740942_2eef38ea","line":15,"updated":"2015-12-08 05:32:44.000000000","message":"remove this import","commit_id":"561f700acf7f290a05d6a74b4efa1d098f9d4626"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a5f30bcdb0fa8653150df95d5ac2929283d301f5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(TestFind, self).setUp()"},{"line_number":28,"context_line":"        self.mock_client \u003d mock.Mock()"},{"line_number":29,"context_line":"        self.list_resources \u003d mock.Mock()"},{"line_number":30,"context_line":"        self.mock_client.find_resource \u003d self.list_resources"},{"line_number":31,"context_line":"        self.resource \u003d mock.Mock()"},{"line_number":32,"context_line":"        self.resource.id \u003d ID"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_60953385","line":29,"updated":"2015-12-08 14:12:34.000000000","message":"This should be called find_resources given its use on the next line.","commit_id":"4be716eb27752d715ea1140b76e4a03907edd87f"}]}